Closed Bug 651968 Opened 9 years ago Closed 9 years ago

Fix libsydneyaudio's ossaudio backend on OpenBSD (and probably other BSDs)

Categories

(Core :: Audio/Video, defect)

All
OpenBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: gaston, Assigned: gaston)

References

Details

Attachments

(1 file)

Followup to https://bugzilla.mozilla.org/show_bug.cgi?id=648726, even if i know libsydneyaudio is targetted for the attic (https://bugzilla.mozilla.org/show_bug.cgi?id=623444), now i'm building trunk, and i need the attached patch to make it correctly build and link :
- on OpenBSD and NetBSD, soundcard.h needs to be included instead of sys/soundcard.h (FreeBSD has sys/soundcard.h, i suppose too for DragonflyBSD)
- -lossaudio needs to be added to EXTRA_DSO_LDOPTS for libxul and gklayout (not sure for the latter, but audio libs are added for MacOS there too...)
- NetBSD and OpenBSD have oss v3.0.1, and it builds fine with it so lower the requirement.
Blocks: openbsdmeta
I doubt it'll make it to any tree/branch, but at least the patch won't be lost. It's in bugzilla if anyone needs it.
Attachment #527647 - Flags: review?(jones.chris.g)
Comment on attachment 527647 [details] [diff] [review]
Fix libsydneyaudio oss backend on *BSD

Seems OK to me but this is Matthew's territory.
Attachment #527647 - Flags: review?(jones.chris.g) → review?(kinetik)
Given the lack of move in https://bugzilla.mozilla.org/show_bug.cgi?id=623444, can this be considered for inclusion in the meantime ?
Attachment #527647 - Flags: review?(kinetik) → review+
Keywords: checkin-needed
Assignee: nobody → landry
http://hg.mozilla.org/projects/cedar/rev/dc03ec9b962e
Flags: in-testsuite?
Keywords: checkin-needed
Whiteboard: [fixed-in-cedar]
Flags: in-testsuite? → in-testsuite-
Pushed http://hg.mozilla.org/mozilla-central/rev/dc03ec9b962e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla6
Blocks: 657715
No longer blocks: 657715
Depends on: 657715
You need to log in before you can comment on or make changes to this bug.