651968 - Fix libsydneyaudio's ossaudio backend on OpenBSD (and probably other BSDs)

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Landry Breuil (:gaston)]

Followup to https://bugzilla.mozilla.org/show_bug.cgi?id=648726, even if i know libsydneyaudio is targetted for the attic (https://bugzilla.mozilla.org/show_bug.cgi?id=623444), now i'm building trunk, and i need the attached patch to make it correctly build and link :
- on OpenBSD and NetBSD, soundcard.h needs to be included instead of sys/soundcard.h (FreeBSD has sys/soundcard.h, i suppose too for DragonflyBSD)
- -lossaudio needs to be added to EXTRA_DSO_LDOPTS for libxul and gklayout (not sure for the latter, but audio libs are added for MacOS there too...)
- NetBSD and OpenBSD have oss v3.0.1, and it builds fine with it so lower the requirement.

Comment 1

[Landry Breuil (:gaston)]

Attachment: Fix libsydneyaudio oss backend on *BSD

I doubt it'll make it to any tree/branch, but at least the patch won't be lost. It's in bugzilla if anyone needs it.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 527647 [details] [diff] [review]
Fix libsydneyaudio oss backend on *BSD

Seems OK to me but this is Matthew's territory.

Comment 3

[Landry Breuil (:gaston)]

Given the lack of move in https://bugzilla.mozilla.org/show_bug.cgi?id=623444, can this be considered for inclusion in the meantime ?

Comment 4

[Boris Zbarsky [:bzbarsky]]

http://hg.mozilla.org/projects/cedar/rev/dc03ec9b962e

Comment 5

[Boris Zbarsky [:bzbarsky]]

Pushed http://hg.mozilla.org/mozilla-central/rev/dc03ec9b962e