Status
People
(Reporter: philip.chee, Assigned: philip.chee)
Tracking
SeaMonkey Tracking Flags
(seamonkey2.35 fixed, seamonkey2.36 fixed)
Details
Attachments
(1 attachment)
|
1.20 KB,
patch
|
iann_bugzilla
:
review+
iann_bugzilla
:
approval-comm-release+
|
Details | Diff | Splinter Review |
(In Bug 653605 comment #5) > We now build SeaMonkey with safe-browsing unconditionally. => WONTFIX. I was wrong. We do need to add MOZ_SAFE_BROWSING=1 because stuff in toolkit and gecko test for this.
|
Assignee | |
Comment 2•4 years ago
|
||
While testing my patch for Bug 1124503 discovered MOZ_SAFE_BROWSING wasn't defined. > +MOZ_SAFE_BROWSING=1 MOZ_SAFE_BROWSING has been in browser/confvars.sh since creation Note: MOZ_SAFE_BROWSING implicitly turns on MOZ_URL_CLASSIFIER We explicitly define MOZ_URL_CLASSIFIER=1 in our confvars.sh unlike all other toolkit applications. > +MOZ_SERVICES_CLOUDSYNC=1 Bug 1052009 - Enable CloudSync in Nightly. > -JSGC_GENERATIONAL=1 Bug 1107349 - Always build in generational GC support
Attachment #8567985 -
Flags: review?(iann_bugzilla)
Attachment #8567985 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Comment 3•4 years ago
|
||
Pushed to comm-central http://hg.mozilla.org/comm-central/rev/a7bc583a6720
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-seamonkey2.36:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.36
|
|
Assignee | |
Updated•4 years ago
|
Blocks: SM2.35-Uplift
|
|
Assignee | |
Updated•4 years ago
|
status-seamonkey2.35:
--- → affected
Flags: needinfo?(iann_bugzilla)
Comment on attachment 8567985 [details] [diff] [review] Patch V1 add MOZ_SAFE_BROWSING etc [Triage Comment] a=me for 2.35
Flags: needinfo?(iann_bugzilla)
Attachment #8567985 -
Flags: approval-comm-release+
|
|
Assignee | |
Comment 5•4 years ago
|
||
http://hg.mozilla.org/releases/comm-release/rev/23c3589a4c6c SEAMONKEY_2_35_RELEASE_BRANCH
You need to log in
before you can comment on or make changes to this bug.
Description
•