Closed Bug 1135604 Opened 8 years ago Closed 8 years ago

Add MOZ_SAFE_BROWSING to confvars.sh and minor updates

Categories

(SeaMonkey :: Build Config, defect)

Product:
SeaMonkey
Component:
Build Config
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.35 fixed, seamonkey2.36 fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.36
Tracking Flags:
Tracking Status
seamonkey2.35 --- fixed
seamonkey2.36 --- fixed

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(1 file)

Patch V1 add MOZ_SAFE_BROWSING etc
1.20 KB, patch
iannbugzilla
: review+
iannbugzilla
: approval-comm-release+
Details | Diff | Splinter Review 
(In Bug 653605 comment #5)
> We now build SeaMonkey with safe-browsing unconditionally. => WONTFIX.
I was wrong. We do need to add MOZ_SAFE_BROWSING=1 because stuff in toolkit and gecko test for this.
While testing my patch for Bug 1124503 discovered MOZ_SAFE_BROWSING wasn't defined.
> +MOZ_SAFE_BROWSING=1
MOZ_SAFE_BROWSING has been in browser/confvars.sh since creation
Note: MOZ_SAFE_BROWSING implicitly turns on MOZ_URL_CLASSIFIER
We explicitly define MOZ_URL_CLASSIFIER=1 in our confvars.sh unlike all other toolkit applications.

> +MOZ_SERVICES_CLOUDSYNC=1
Bug 1052009 - Enable CloudSync in Nightly.

> -JSGC_GENERATIONAL=1
Bug 1107349 - Always build in generational GC support
Attachment #8567985 - Flags: review?(iann_bugzilla)
Attachment #8567985 - Flags: review?(iann_bugzilla) → review+
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/a7bc583a6720
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-seamonkey2.36: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.36
Blocks: SM2.35-Uplift
status-seamonkey2.35: --- → affected
Flags: needinfo?(iann_bugzilla)
Comment on attachment 8567985 [details] [diff] [review]
Patch V1 add MOZ_SAFE_BROWSING etc

[Triage Comment]
a=me for 2.35
Flags: needinfo?(iann_bugzilla)
Attachment #8567985 - Flags: approval-comm-release+
You need to log in before you can comment on or make changes to this bug.