User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/534.30 (KHTML, like Gecko) Chrome/12.0.742.100 Safari/534.30 Steps to reproduce: Press Ctrl+Shift+O on a collapsed thread (the menu item is disabled too) Actual results: Nothing Expected results: Should have opened the thread in a new tab as it does when the thread is expanded
This would cause issues if you have mail.strict_threading set to false. Consider messages: - Message A, Subject = Foo - Message B, Subject = Re: Foo, *no references header* The thread pane will thread message A and message B together because they share the same subject, but Gloda will fail to figure out these messages are related, because Gloda only trusts References: and In-Reply-To headers. Then, hitting "Show in conversation" on the collapsed thread will take the first message, run a gloda query, and display the results of the query in a new tab, that is, message A only. This will be slightly confusing, but not much more confusing than what happens already if you do show in conversation when the thread is expanded. Plus, I'm pretty sure we have no UI for these options. Thoughts?
Created attachment 547469 [details] [diff] [review] Always enable open in conversation Well I guess it's a worthwhile addition, and since the prefs that might lead to weird behaviors are hidden, I guess it's worth having.
Note that this doesn't actually show the menu item, it just enables the keyboard shortcut and the Message > Open In Conversation menu entry. I guess I could make sure the menu entry is shown but that probably requires a ui-r and a strings change.
Blake, you might want to voice your opinion on the issue. Enabling the menu item would show a "open message in conversation" menu item while a collapsed thread is shown. This can be confusing, and we might need to turn it into a "open thread in conversation", possibly with a separate menu item. This is much more involved than the patch I submitted, and I'm not sure it's worth it, when you can simply expand the thread and then do "open in conversation"...
Comment on attachment 547469 [details] [diff] [review] Always enable open in conversation Review of attachment 547469 [details] [diff] [review]: ----------------------------------------------------------------- The patch works for a single thread, but behaves strangely when multiple threads are selected. "Open in Conversation" is enabled in that case, yet trying to open all the thread in a conversation only opens the first thread. Bug 550775 discussed some ways to handle it (I think we should open a single conversation tab with all the conversations listed). I think this would entail modifying the gConversationOpener object and possibly the conversation tab implementation to handle multiple conversations at once. I also think we should show the context menu item for "Open in Conversation" when multiple messages are selected, but that's pretty easy to do.
I think "Open in Conversation" should be enabled when a thread is selected, too. How much more work are we talking about? (Also, similarly to the way "Open Message" opens one tab per message, I think "Open in Conversation" should open one tab per conversation. As a side benefit, that should be easier to do. ;) Thanks, Blake.
This should be revisited as 546621 bubbles up