668631 - Dragging message(s) over a folder doesn't give highlight the drop folder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Benjamin Smedberg]

Attachment: Screenshot of drag

I frequently drag messages to folders in the folder pane. In the previous version of Thunderbird, when I dragged over the folder the folder would highlight. This was very useful because I knew I had "hit" the correct folder. Now I get no visual feedback that I've got the correct folder because it doesn't highlight.

Thunderbird 5.0 (release), Windows.

Comment 2

[rsx11m]

Reopening since this has tracking+ already, thus reversing the dupe.
See bug 668477 comment #1 though for dependency on the desktop theme.

Comment 4

[Richard Marti (:Paenglab)]

Attachment: Highlight the drop folder

This patch highlights the drop folder. I tried to add a border but this didn't work well for the -moz-tree-cell. I gave the gradient a little more intense color to see it also through the moved message.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 543485 [details] [diff] [review]
Highlight the drop folder

Review of attachment 543485 [details] [diff] [review]:
-----------------------------------------------------------------

Other than the tiny nit below, I like it!  r=me.

Thanks,
Blake.

::: mail/themes/qute/mail/mailWindow1-aero.css
@@ +154,5 @@
>    }
>  
> +  #folderTree treechildren::-moz-tree-cell(dropOn) {
> +    background-image: -moz-linear-gradient(rgba(255, 255, 255, .7),
> +                      rgba(255, 255, 255, .45));

This should line up with the other "rgba".

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Patch for check-in addressing comment

Carrying over the r+

Asking for approval‑comm‑beta and approval‑comm‑aurora because this shouldn't break something and already a lot of TB5 users are mentioning this problem.

Comment 7

[Jonathan Protzenko [:protz]]

http://hg.mozilla.org/comm-central/rev/86474babc711

Comment 8

[Rain [:rain1] (inactive)]

https://hg.mozilla.org/releases/comm-aurora/rev/356946b0d1c2
https://hg.mozilla.org/releases/comm-beta/rev/68acb7f9015f