Closed
Bug 671553
Opened 13 years ago
Closed 13 years ago
Remove the navigation toolbar's custom button appearance in small icons mode; invert icons on dark personas and glass
Categories
(Firefox :: Theme, enhancement)
Tracking
()
RESOLVED
FIXED
Firefox 8
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(3 files, 3 obsolete files)
No description provided.
Attachment #545910 -
Flags: ui-review?(shorlander)
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #545910 -
Attachment is obsolete: true
Attachment #546204 -
Flags: review?(shorlander)
Attachment #545910 -
Flags: ui-review?(shorlander)
Assignee | ||
Comment 2•13 years ago
|
||
another untested patch!
Attachment #546204 -
Attachment is obsolete: true
Attachment #546273 -
Flags: review?(shorlander)
Attachment #546204 -
Flags: review?(shorlander)
Assignee | ||
Comment 3•13 years ago
|
||
typo eliminated
Attachment #546273 -
Attachment is obsolete: true
Attachment #546274 -
Flags: review?(shorlander)
Attachment #546273 -
Flags: review?(shorlander)
Assignee | ||
Comment 4•13 years ago
|
||
I'm back home and was finally able to test this. The latest patch appears to be working as expected.
Comment 5•13 years ago
|
||
Comment on attachment 546274 [details] [diff] [review]
patch v3
Review of attachment 546274 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Currently missing inverted icons for New Tab, Panorama and dropdown markers. Should we handle those in followup bugs?
Attachment #546274 -
Flags: review?(shorlander) → review+
Comment 6•13 years ago
|
||
Assignee | ||
Comment 7•13 years ago
|
||
(In reply to comment #5)
> Currently missing inverted icons for New Tab, Panorama and
> dropdown markers. Should we handle those in followup bugs?
Yes. Bug 580194, I guess.
Assignee | ||
Comment 8•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/ed75122f827c
http://hg.mozilla.org/mozilla-central/rev/6ffb760a41ca
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 8
Comment 9•13 years ago
|
||
Nice work! But I found an issue.
Put the sync button next to the tabs. Now do a sync.
The sync button changes to a back button. Please fix this.
Comment 10•13 years ago
|
||
Note: this happens only with the default theme.
Assignee | ||
Comment 11•13 years ago
|
||
Please file a new bug.
Comment 12•13 years ago
|
||
Comment 13•13 years ago
|
||
Thanks, Dão. Looks good - much cleaner.
Comment 14•13 years ago
|
||
Comment 15•13 years ago
|
||
(In reply to bogas04 from comment #14)
> Created attachment 552949 [details]
> Must be implemented on Tab Scroll Buttons too
The remaining work is being tracked in Bug 580194
Comment 17•13 years ago
|
||
The new inverted icons are a good idea, but the removal of the button styles for the navigation toolbar was a very bad one. This has caused grief for many users and skin writers. See why at http://forums.mozillazine.org/viewtopic.php?f=38&t=2357753
This bug actually does two completely separate things and should have been split in two.
We now have a bug tracker to revert the navigation bar change introduced here: bug #700972
You need to log in
before you can comment on or make changes to this bug.
Description
•