Today I noticed that the nightly version doesn't do the auto-detect anymore (forcing ui.trackpoint_hack.enabled to 1 helps), while Firefox 5.0 works correctly. I'm using an old driver, Synaptics version 188.8.131.52, on a UltraNavPS2 device. I think that the reason is that the call to IsObsoleteSynapticsDriver was removed (which I was relying on) and replaced with a check for the Elan Tech driver. http://hg.mozilla.org/mozilla-central/diff/1d90c5f569a2/widget/src/windows/nsWindow.cpp This seems to be a different issue than bug 622410.
The change came from bug 640587, which is now on its way to Firefox 6.0
Yeah, the call to IsObsoleteSynapticsDriver should not have been removed as part of the bug 640587 fix.
Jo, can you test this tryserver build that has the IsObsoleteSyntapicsDriver call restored? Please try it without the ui.trackpoint_hack.enabled pref set. https://email@example.com/try-win32/firefox-8.0a1.en-US.win32.zip
Yes, this solves the problem for me.
Great. So I want to wait til I'm back in the office next week and verify I haven't broken the other scrolling hacks before requesting review.
Please see https://bugzilla.mozilla.org/show_bug.cgi?id=538189 for similar problems in Thunderbird 5.0 and latest-earlybird 7.0a2 .
Created attachment 549924 [details] [diff] [review] Fix Synaptics touchpad scrolling hack requirement detection Verified that this doesn't cause the Elantech hack detection to break.
Comment on attachment 549924 [details] [diff] [review] Fix Synaptics touchpad scrolling hack requirement detection The regression causes touchpad scrolling not to work for users on Thinkpads (and perhaps other machines with Synaptics-based touchpads) using drivers that aren't up to date.
Comment on attachment 549924 [details] [diff] [review] Fix Synaptics touchpad scrolling hack requirement detection Approved for beta (6) and aurora (7).
verfied as fixed in : Mozilla/5.0 (Windows NT 5.1; rv:8.0a1) Gecko/20110803 Firefox/8.0a1 Mozilla/5.0 (Windows NT 5.1; rv:7.0a2) Gecko/20110803 Firefox/7.0a2 there's no update for 6.0 beta available yet, so that couldn't be verified
Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20100101 Firefox/6.0 - beta 5 Jo, can you also please check on the latest beta and modify the status if everything is in order? http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/6.0b5-candidates/
Yes, that works. Mozilla/5.0 (Windows NT 5.1; rv:6.0) Gecko/20100101 Firefox/6.0 The User-Agent doesn't tell me the version of course, but browser.startup.homepage_override.buildID was set to 20110804030150
Thanks for verifying, Jo!