68109 - Use Default button in AddBookmark dialog doesn't work

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P2)

Description

[db]

Build 2001020712, I can not select which folder to use for new bookmarks. In the
bookmarks dialog,  I though that i could select the folder and then in the View
meny do "Set as new bookmark folder". But nothing happens. Then I found a
similar setting in the preferences, but it does not work there either.

I have an old bookmarks file from previuos mozilla, like a week ago. And in that
file the property NEW_BOOKMARK_FOLDER="true" is set on the correct folder, but
that's not where new entries end up.

Comment 1

[Henri Sivonen (:hsivonen)]

*** Bug 68108 has been marked as a duplicate of this bug. ***

Comment 2

[Keyser Sose]

Reporter there were various bugs with Mozilla new bookmarks recently. Try
downloading the latest nightly at http://www.mozillazine.org/build_comments/ and
creating a new profile. See if that fixes the problem. Report back either way
thanks. :)

Comment 3

[db]

Same problem with 2001020908

Comment 4

[Keyser Sose]

Marking nEW as per reporters comments.

Comment 5

[Boris Zbarsky [:bzbarsky]]

adding dependency from the duplicate

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 68546 has been marked as a duplicate of this bug. ***

Comment 7

[Håkan Waara]

WORKSFORME using build 20010227, Windows 98.

Reporter, can you still reproduce this with a new nightly build? If not, please
resolve this bug as WORKSFORME.

Thanks!

Comment 8

[Ben Bucksch (:BenB)]

Actually, it got worse: bug 71950.

Comment 9

[gary_Cope]

I tested this out with build 2001042012 win32talkback and noted the following:

1. choosing a default folder from bookmarks manager using "Set as New Bookmark
Folder" from view menu.

2.File a bookmark using "Add Bookmark". The bookmark is filed in correct
place(ie. the default folder previously selected).

3. File a bookmark using "Add Bookmark As..." and select the "Use Default"
button. The bookmark is added to the main bookmarks folder, NOT the default
folder selected in bookmark manager.

It would appear that this bug is partially fixed but still needs to correct 3.

Also changing Platform/OS  from pc/linux to All/All.

Comment 10

[Fabian Guisset]

As Ben asked me to do, I changed the ref= on the tree of addBookmark.xul from
NC:BookmarksRoot to NC:NewBookmarkFolder. The result was a blank tree, even
though I double-checked that I had a folder set as default (in the bookmarks
manager, selected a folder and clicked on the menu item "Set as New Bookmark
Folder". The fact that the tree view is now empty probably means something that
I don't grasp yet. Any RDF freak out there? 

Comment 11

[Alexander Dietrich]

I think Gary Cope's comment about problem #3 is right. The problem seems to be
that clicking on "Use Default" should cause the default folder to be selected in
the list, for visual feedback as well, but it isn't. (Does this mean parents of
the new bookmarks folder get opened automatically ?)

In addition to that, there should be more visual feedback in the bookmark
manager in regard to the special folders. Netscape 4.x had special icons for
toolbar and new bookmarks, why not use them again ?

Oh, and another real bug related to this: the menu items "View -> Set as xyz
folder" are not all greyed out when you are on the folder in question. "Set as
Personal Toolbar folder" is grey when you are on the toolbar folder, but the
other two are not, giving you no clue if your choice was accepted.

Comment 12

[Fabian Guisset]

One issue per bug, please, thanks.
The problem is that for some reason NC:NewBookmarkFolder looks empty in that dialog.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

Worksforme, 09/24/2001

Comment 14

[Derek Lee]

I am having the same problem here: 

"Set as New Bookmarks Folder" does absolutely nothing.

I am using Mozilla 0.9.4 Build 2001091712 on Redhat 7 (Linux 2.4.3, XFree86 4.0.3)
The bookmarks were migrated from my Netscape 4.77 folder.

Ben Goodger: what platform/build are you using that "works for you"?

Comment 15

[Ben Goodger (use ben at mozilla dot org for email)]

Windows 2000. 

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter 
email notifications caused by this by searching for 'ilikegoats'.

Comment 17

[Paul Chen]

marking p2 and mozilla0.9.7

Comment 18

[Paul Chen]

As far as I can tell, "Set as New Bookmark Folder" appears to work for "Add 
Bookmarks" under win32 and linux (2001103106 build under RH7.1). My powerbook 
is currently compiling the big patch for 84947, so I can't test mac right at 
the moment. "Use Default" is definitely broken in the File Bookmark dialog. It 
looks like the useDefaultFolder funciton in addBookmark.js doesn't work.

Comment 19

[Paul Chen]

Changing summary to "Use Default button in AddBookmark dialog doesn't work"

Comment 20

[Paul Chen]

Pushing out to mozilla0.9.9

Comment 21

[Chris Lyon]

*** Bug 113666 has been marked as a duplicate of this bug. ***

Comment 22

[Blake Ross]

This happens because only the personal toolbar folder has the special uri.  The 
other two, bookmarks and search, have NC_NS + "SpecialFolder" arcs that have 
these special literals (NC:NewBookmarksFolder, etc.)

Comment 23

[Peter Trudelle]

mass reassign of pchen bookmark bugs to ben

Comment 24

[Ben Goodger (use ben at mozilla dot org for email)]

either fix this or remove the button

Comment 25

[Peter Trudelle]

Marlon, what's a good way to allow the user to revert to saving  a bookmark in
the standard location after they have selected some other folder to put it in
from the list? (assuming we were to remove this button) 

navtriage team sez nsbeta1+

Comment 26

[Blake Ross]

I don't think this should be a hard fix, so I don't think this button should be
removed.

Comment 27

[marlon bishop]

perhaps i am misunderstanding something here, but i don't think the button
should be removed. 

Comment 28

[Peter Trudelle]

Mass move of nsbeta1+ bugs that didn't have a valid MachV milestone to mozilla1.0.

Comment 29

[Blake Ross]

Attachment: patch

Comment 30

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 71160 [details] [diff] [review]
patch

sr=[e-mail]

Comment 31

[Blake Ross]

-> me

Comment 32

[Joe Hewitt (gone)]

Comment on attachment 71160 [details] [diff] [review]
patch

r=hewitt

Comment 33

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 34

[Blake Ross]

Fixed.

Comment 35

[Claudius Gayle]

VERIFIED Fixed with 20020308 builds