Move help viewer to comm-central

RESOLVED FIXED in seamonkey2.47

Status

defect
RESOLVED FIXED
8 years ago
3 years ago

People

(Reporter: matjk7, Assigned: frg)

Tracking

Trunk
seamonkey2.47
Dependency tree / graph

SeaMonkey Tracking Flags

(seamonkey2.47 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

AFAICT help viewer is only used by SeaMonkey, so this code shouldn't live on mozilla-central.
Flags: in-testsuite-
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 425541
XULRunner applications use the help viewer as well. See bug 425541.
Actually this isn't a duplicate as IanN pointed out over irc.
Assignee: nobody → frgrahl
Blocks: 1243203
Status: RESOLVED → REOPENED
Flags: in-testsuite-
Resolution: DUPLICATE → ---
Posted patch 686168-SuiteHelpAdd.patch (obsolete) — Splinter Review
Patch to move the help viewer over.
Attachment #8771867 - Flags: review?(iann_bugzilla)
Status: REOPENED → ASSIGNED
No longer blocks: 1243203
Depends on: 1243203
Component: Build Config → Help Viewer
Product: Core → SeaMonkey
patching file suite/common/jar.mn
Hunk #1 FAILED at 0
Hunk #2 FAILED at 125
2 out of 2 hunks FAILED -- saving rejects to file suite/common/jar.mn.rej
patching file suite/themes/classic/jar.mn
Hunk #2 FAILED at 30
Hunk #3 succeeded at 86 with fuzz 2 (offset 9 lines).
1 out of 3 hunks FAILED -- saving rejects to file suite/themes/classic/jar.mn.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 686168-SuiteHelpAdd.patch
I just checked and the patch applies clean to a current unmodified c-c. Could you check your tree. If you applied the error console patch before it will clash with it. Use hg import -f and edit the rejects manually if you need both patches at once. 

I will see if I can pull the history in here too if the patch is ok. Not easy because another repository.
Flags: needinfo?(iann_bugzilla)
Depends on: 1288981
File copy with history done via https://hg.mozilla.org/comm-central/pushloghtml?changeset=376136cbab3b
Had to use hg rebase in the end
Flags: needinfo?(iann_bugzilla)
Comment on attachment 8771867 [details] [diff] [review]
686168-SuiteHelpAdd.patch

Patch needs to be rebased now the files have been copied with history from m-c.
Attachment #8771867 - Flags: review?(iann_bugzilla)
Attachment #8771867 - Attachment is obsolete: true
Attachment #8774759 - Flags: review?(iann_bugzilla)
Moved all parts to helpviewer to distinguish it from the actual help. Kept the orginal locations for css and other stuff via skin and content statement.
Comment on attachment 8774759 [details] [diff] [review]
686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12]

r/a=me
Attachment #8774759 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8774759 [details] [diff] [review]
686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12]

https://hg.mozilla.org/comm-central/rev/b87713baaa13
Attachment #8774759 - Attachment description: 686168-SuiteHelpAdd-V2.patch → 686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.47
I just noticed that we still pull in the old help viewer via moz_help_viewer=1 in confvars.sh and modern theme files are in the wrong dir.

Reopening the bug for a quick followup fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Blocks: 1289851
Tested and works for me.
Attachment #8775265 - Flags: review?(iann_bugzilla)
Comment on attachment 8775265 [details] [diff] [review]
686168-SuiteHelpAdd-part2.patch

r=me
Attachment #8775265 - Flags: review?(iann_bugzilla) → review+
https://hg.mozilla.org/comm-central/rev/a744f83c0ab5

I think we are done here. See you in the follow up bugs.
Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → FIXED
Blocks: 1290756
Depends on: 1296668
You need to log in before you can comment on or make changes to this bug.