686168 - Move help viewer to comm-central

Status: RESOLVED FIXED

(SeaMonkey :: Help Viewer, defect)

Description

[Matheus Kerschbaum]

AFAICT help viewer is only used by SeaMonkey, so this code shouldn't live on mozilla-central.

Comment 2

[Philip Chee]

XULRunner applications use the help viewer as well. See bug 425541.

Comment 3

[Frank-Rainer Grahl (:frg)]

Actually this isn't a duplicate as IanN pointed out over irc.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 686168-SuiteHelpAdd.patch

Patch to move the help viewer over.

Comment 5

[Ian Neal]

patching file suite/common/jar.mn
Hunk #1 FAILED at 0
Hunk #2 FAILED at 125
2 out of 2 hunks FAILED -- saving rejects to file suite/common/jar.mn.rej
patching file suite/themes/classic/jar.mn
Hunk #2 FAILED at 30
Hunk #3 succeeded at 86 with fuzz 2 (offset 9 lines).
1 out of 3 hunks FAILED -- saving rejects to file suite/themes/classic/jar.mn.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 686168-SuiteHelpAdd.patch

Comment 6

[Frank-Rainer Grahl (:frg)]

I just checked and the patch applies clean to a current unmodified c-c. Could you check your tree. If you applied the error console patch before it will clash with it. Use hg import -f and edit the rejects manually if you need both patches at once. 

I will see if I can pull the history in here too if the patch is ok. Not easy because another repository.

Comment 7

[Ian Neal]

File copy with history done via https://hg.mozilla.org/comm-central/pushloghtml?changeset=376136cbab3b
Had to use hg rebase in the end

Comment 8

[Ian Neal]

Comment on attachment 8771867 [details] [diff] [review]
686168-SuiteHelpAdd.patch

Patch needs to be rebased now the files have been copied with history from m-c.

Comment 9

[Frank-Rainer Grahl (:frg)]

Attachment: 686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12]

Comment 10

[Frank-Rainer Grahl (:frg)]

Moved all parts to helpviewer to distinguish it from the actual help. Kept the orginal locations for css and other stuff via skin and content statement.

Comment 11

[Ian Neal]

Comment on attachment 8774759 [details] [diff] [review]
686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12]

r/a=me

Comment 12

[Ian Neal]

Comment on attachment 8774759 [details] [diff] [review]
686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12]

https://hg.mozilla.org/comm-central/rev/b87713baaa13

Comment 13

[Frank-Rainer Grahl (:frg)]

I just noticed that we still pull in the old help viewer via moz_help_viewer=1 in confvars.sh and modern theme files are in the wrong dir.

Reopening the bug for a quick followup fix.

Comment 14

[Frank-Rainer Grahl (:frg)]

Attachment: 686168-SuiteHelpAdd-part2.patch

Tested and works for me.

Comment 15

[Ian Neal]

Comment on attachment 8775265 [details] [diff] [review]
686168-SuiteHelpAdd-part2.patch

r=me

Comment 16

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/a744f83c0ab5

I think we are done here. See you in the follow up bugs.