Closed Bug 686168 Opened 9 years ago Closed 4 years ago
Move help viewer to comm-central
AFAICT help viewer is only used by SeaMonkey, so this code shouldn't live on mozilla-central.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 425541
XULRunner applications use the help viewer as well. See bug 425541.
Actually this isn't a duplicate as IanN pointed out over irc.
Assignee: nobody → frgrahl
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Patch to move the help viewer over.
Component: Build Config → Help Viewer
Product: Core → SeaMonkey
patching file suite/common/jar.mn Hunk #1 FAILED at 0 Hunk #2 FAILED at 125 2 out of 2 hunks FAILED -- saving rejects to file suite/common/jar.mn.rej patching file suite/themes/classic/jar.mn Hunk #2 FAILED at 30 Hunk #3 succeeded at 86 with fuzz 2 (offset 9 lines). 1 out of 3 hunks FAILED -- saving rejects to file suite/themes/classic/jar.mn.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh 686168-SuiteHelpAdd.patch
I just checked and the patch applies clean to a current unmodified c-c. Could you check your tree. If you applied the error console patch before it will clash with it. Use hg import -f and edit the rejects manually if you need both patches at once. I will see if I can pull the history in here too if the patch is ok. Not easy because another repository.
File copy with history done via https://hg.mozilla.org/comm-central/pushloghtml?changeset=376136cbab3b Had to use hg rebase in the end
Comment on attachment 8771867 [details] [diff] [review] 686168-SuiteHelpAdd.patch Patch needs to be rebased now the files have been copied with history from m-c.
Moved all parts to helpviewer to distinguish it from the actual help. Kept the orginal locations for css and other stuff via skin and content statement.
Comment on attachment 8774759 [details] [diff] [review] 686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12] r/a=me
Attachment #8774759 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 8774759 [details] [diff] [review] 686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12] https://hg.mozilla.org/comm-central/rev/b87713baaa13
Attachment #8774759 - Attachment description: 686168-SuiteHelpAdd-V2.patch → 686168-SuiteHelpAdd-V2.patch [Checked in: Comment 12]
I just noticed that we still pull in the old help viewer via moz_help_viewer=1 in confvars.sh and modern theme files are in the wrong dir. Reopening the bug for a quick followup fix.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Tested and works for me.
Attachment #8775265 - Flags: review?(iann_bugzilla)
Comment on attachment 8775265 [details] [diff] [review] 686168-SuiteHelpAdd-part2.patch r=me
Attachment #8775265 - Flags: review?(iann_bugzilla) → review+
https://hg.mozilla.org/comm-central/rev/a744f83c0ab5 I think we are done here. See you in the follow up bugs.
Status: REOPENED → RESOLVED
Closed: 4 years ago → 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.