Closed Bug 690668 Opened 9 years ago Closed 9 years ago

TEST-UNEXPECTED-FAIL | c:\talos-slave\test\build\xpcshell\tests\toolkit\components\passwordmgr\test\unit\test_storage_legacy_2.js | test failed (with xpcshell return code: 0), see following log:

Categories

(Core :: General, defect)

x86_64
Windows Vista
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla10

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

(Keywords: intermittent-failure, regression)

Attachments

(1 file)

After landing bug 675553, this perma-orange occurs on Win64.  But this doesn't occurs if using VC10SP1.
This depends on compiler.  This occurs when script uses boolean type.  When casting to bool, the value is converted to true except to 0.  We need cast to PRUint8 at first, then cast to bool.
Assignee: nobody → m_kato
Status: NEW → ASSIGNED
Keywords: regression
Attached patch fixSplinter Review
Attachment #563712 - Flags: review?(benjamin)
Blocks: 690843
Blocks: 438871
No longer blocks: 690843
Duplicate of this bug: 690843
Blocks: 690843
Since this broke up/down/tab in all dropdowns on x64, should the severity be increased?
How to apply the patch?
Duplicate of this bug: 692102
I can confirm (as the author of bug 692102) that it does indeed kill all of the drop down tab/arrow ordering.  I just had only thus far noticed it on the location bar.
Duplicate of this bug: 692116
I have the same issue with form in the web page, such as I input my username in Gmail login
(In reply to Makoto Kato from comment #2)
> Created attachment 563712 [details] [diff] [review] [diff] [details] [review]
> fix

Possibly sending this through try, would help Ben with his review ;-)
Attachment #563712 - Flags: review?(benjamin) → review+
Duplicate of this bug: 692282
Duplicate of this bug: 692233
https://hg.mozilla.org/mozilla-central/rev/8c82de08425d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Is this fix included in a future Firefox nightly update OR do we need to apply the fix ourselves (and if so how?)?
Verified fixed - Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:10.0a1) Gecko/20111006 Firefox/10.0a1
Status: RESOLVED → VERIFIED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.