Show compatibility error if an add-on uses geo.wifi.uri or geo.wifi.protocol

RESOLVED FIXED in 6.2.7

Status

addons.mozilla.org Graveyard
Compatibility Tools
P2
normal
RESOLVED FIXED
7 years ago
2 years ago

People

(Reporter: jorgev, Assigned: ashort)

Tracking

unspecified
6.2.7

Details

(Whiteboard: [fx9])

(Reporter)

Description

7 years ago
As explained in bug 689252, the preferences "geo.wifi.uri" and "geo.wifi.protocol" will cease to have any meaning in Firefox. We need to flag all instances of these preferences and show an error.

This is a compatibility error, so the add-on should not be upgraded in this case.

Message:

The "geo.wifi.*" preferences are no longer in use. See <LINK> for more information.

Link: https://bugzilla.mozilla.org/show_bug.cgi?id=689252

Affected add-on:

https://addons.mozilla.org/en-US/firefox/addon/geolocater/
(Assignee)

Comment 1

7 years ago
Since these are still readable, should this be an error instead of a warning? Not sure the validator can tell if an addon deals with the absence of these properties correctly.
(Reporter)

Comment 2

7 years ago
It is still an error because trying to access the preference without setting it first will throw an exception.
(Assignee)

Comment 4

7 years ago
Fixed. https://github.com/mozilla/amo-validator/commit/b0379f295723c392a0cd26bdde529d743a978f39
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 710784
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.