69434 - checkboxes and radio boxes still black on black

Status: RESOLVED WONTFIX

(SeaMonkey :: Themes, enhancement, P3)

Description

[Robert Praetorius]

(from the author of http://bugzilla.mozilla.org/show_bug.cgi?id=57429 
 now marked fixed, where this was mentioned in the original description.
 Mr. Hewitt acknowledges reports of "some color weirdness" but requests
 "Please file separate bugs specific to those issues" and if he'd
 rather track those bugs on a more specific basis, that's fine by me.)

I'm running Mozilla 0.8 now, which I presume incorporate Mr. Hewitt's
fixes for paying attention to MS Windows & Linux system colors, etc.
And, indeed, menus and dialog boxes do look much better in this
respect.  However, checkboxes and radio boxes in dialog boxes still
come out black on black.

I have the same workaround that I mentioned in 57429, namely
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=23210

Comment 1

[Stephen Walker]

*** Bug 69435 has been marked as a duplicate of this bug. ***

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 69435 has been marked as a duplicate of this bug. ***

Comment 3

[Robert Praetorius]

color prefs for reproducing this bug are in
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=17629

Comment 4

[Asa Dotzler [:asa]]

reassigning.

Comment 5

[Joe Hewitt (gone)]

Whoops! I missed this one last time around...

Comment 6

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 7

[timeless]

r=timeless

Comment 8

[Robert Praetorius]

I picked up the latest nighly build and merged your changes into
radio.css and checkbox.css in both 
bin\chrome\classic\skin\classic\global in the install directory
and skin\classic\global in the bin\chrome\classic.jar file.  I
still get black on black for radio and check boxes (see attached
.GIF)

I also performed the following experiment which may or may not
be relevant - with Use system colors checked in the color
preferences, I selected Windows Standard as the color scheme in
the appearance tab of Display Properties and opened 
bin\chrome\classic\skin\classic\global\check-check.gif in Mozilla.
It was visible as a black check mark on a white background.  I
switched to High Contract Black as the color scheme, reloaded my
Mozilla window, and the check mark disappeared (black on black).

Comment 9

[Robert Praetorius]

Attachment: screen shot of black and black radio buttons

Comment 10

[Joe Hewitt (gone)]

Robert, in your particular situation the checkbox will always be black on black.
 That is because your -moz-fiedl color is black.  We use an image for the
checkmark, and that image is black.  Unless we had a font at our disposal which
had a checkmark character, there is no way around this. The patch in this bug is
for using "-moz-field" for the checkbox background, which previously used "Window".

Comment 11

[Robert Praetorius]

If you change "there is no way around this" to "there is no way
around this given the current implementation of themes" I'll be
perfectly happy with your response.  Native Win32 UIs have no
trouble making the check mark appear with the designated
foreground and background colors, but, of course, they don't do
so in a customizable way.

Me, I'm just trying to avoid regressions from Netscape 4.X.  It's
not a lotta work to just wedge a coupla .GIFs into the .JAR for
now, so that's what I'll do in the meanwhile (which I recognize
may be a number of years).  I still prefer the feel of Mozilla
to the feel of IE and use it when I can.

One solution that comes to mind is constructing (when the check
mark .GIF is read) an inverse bitmap that's transparent where
the original isn't and vice versa.  But I'm no GUI wiz and will
leave that to someone who is.

Comment 12

[Joe Hewitt (gone)]

In order to truly fix this, the way Robert would like it to be fixed, we need
some extensions to allow painting of color-filled scalar graphics, or to be able
to filter bitmaps.  That's currently very pie-in-the sky.  An RFE bug is in order :)

I just committed the earlier patch, so marking fixed.

Comment 13

[Warner Young]

Hewitt, what about some kind of ability to just remap the palette on GIFs and
PNG8 images?  Wouldn't that allow you to fix this bug, too?  (In Win32, at
least, there is an API call that basically lets you load a bitmap but change
certain colors in it to other colors you specify)

Comment 14

[Patty Mac]

marking verified based on Joe H's patch. (windows 98: 2001-04-16-12-Mtrunk).

Comment 15

[Robert Praetorius]

as a former QA dude, I'm a little disturbed by the status/resolution
combination here.  I'm OK with the VERIFIED - I'm certainly willing to
believe that the behavior has officially been verified.  But I think
the FIXED should be WONTFIX, LATER or REMIND, given the other comments
and that fact that the bug is still there and the descriptions listed
at http://bugzilla.mozilla.org/bug_status.html .

Comment 16

[Robert Praetorius]

Attachment: radio buttons still black on black in build 2001041704

Comment 17

[hangas]

removing old milestone

Comment 18

[Joe Hewitt (gone)]

Since we have no way to use anything other than a bitmap for the check images, I
have to mark this WONTFIX.  Maybe someday if we could install special fonts or
use SVG we could fix this correctly.

Comment 19

[Boris Zbarsky [:bzbarsky]]

*** Bug 155713 has been marked as a duplicate of this bug. ***

Comment 20

[Boris Zbarsky [:bzbarsky]]

*** Bug 180456 has been marked as a duplicate of this bug. ***

Comment 21

[Boris Zbarsky [:bzbarsky]]

*** Bug 195983 has been marked as a duplicate of this bug. ***

Comment 22

[Robert Praetorius]

(this is the original reporter of the bug)

as I commented semi-recently in
http://bugzilla.mozilla.org/show_bug.cgi?id=71466#c5

I've gotten relief from this problem in Phoenix 0.5 and
Mozilla 1.3 alpha

Comment 23

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Perhaps due to the fix to bug 58755, although I'm not sure why.