70154 - (ctrl)+shift+home/end should select to beginning/end of webpage

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Jesse Ruderman]

Shift+Home and Ctrl+Shift+Home should select to the beginning of the document 
in Navigator.  Currently Shift+Home selects to the beginning of the line (even 
though Home jumps to the top of the page) and Ctrl+Shift+Home doesn't do 
anything.

Similarly for End.

Comment 1

[Jesse Ruderman]

Forgot to mention: these shortcuts work best if you click inside text first.  
The insertion point is invisible but still works.

Comment 2

[Alec Flett]

design issue, reassign to aaronl

Comment 3

[Kathleen :Brade]

I'm surprised that users would actually want this functionality given there isn't 
an obvious caret in the browser.

Comment 4

[Peter Lockhart]

this bug doesnt seem relevant since it does in fact work in email composition
and <textarea> widgets, just not on a webpage.
Perhaps this should be marked invalid ?

Comment 5

[Aaron Leventhal]

This is going to be important for "Browse with caret" mode that I'm working on.
That allows keyboard-only users to select and copy text.

Comment 6

[[e-mail]]

*** Bug 161923 has been marked as a duplicate of this bug. ***

Comment 7

[[e-mail]]

I created attachment 94635 [details] [diff] [review] to bug 161923 as a patch just for Windows because I
didn't think that those keys were used in other OSes.

Comment 8

[Kathleen :Brade]

r=brade on that attachment

Comment 9

[Tom Hatta]

On windows I find the common function for shift+home is to bring the selection
caret to the beginning of the line as opposed to the beginning of a document.
For comparison, here are text selection keyboard shortcuts for Mozilla textfields:

Ctrl+A           = Select all.
Shift+Right      = Expand selection by a character.
Ctrl+Shift+Right = Expand selection to the end of a word.
Shift+End        = Expand selection to the end of a line.
Ctrl+Shift+End   = Expand selection to the end of a textfield.

In an html document (outside of textfields and textareas) I can use keyboard
shortcuts for text selection after I initially select a word in a document by
double clicking on a word with a cursor. Once I have a portion of the html
document selected, I can expand text selection with all of the above keyboard
shortcuts with the exception of Ctrl+Shift+End.

Same situation when left/right, home/end is switched.

Comment 10

[Aaron Leventhal]

Should fix at the same time as bug 244953.

Comment 11

[Aaron Leventhal]

How about this?

Caret browsing off:
Home, End scroll to top/bottom without changing horizontal position.
Ctrl+Home, Ctrl+End scroll horizontally to beginning or end without changing
vertical position 

Caret browsing on:
Home, end move caret to beginning/end of line as it does now
Ctrl+Home, Ctrl+End move caret to very beginning or end of doc

Either:
Ctrl+Shift+Home, Ctrl+Shift+End
Select to beginning/end of doc

Agreements? Disagreements?

Comment 12

[Aaron Leventhal]

See also bug 143996

Comment 13

[Ginn Chen]

Attachment: patch

The command name in platformHTMLBindings.xml is cmd_selectTop/cmd_selectBottom
not cmd_selectMoveTop/cmd_selectMoveButtom.
So we need correct /dom/src/base/nsGlobalWindowCommands.cpp

Q: Should we correct /camino/src/embedding/CHBrowserView.mm?

Comment 14

[Kathleen :Brade]

Comment on attachment 172420 [details] [diff] [review]
patch

I'm unclear why you want to rename these commands.  Just to be compatible with
the same command names in the xml or is something broken?

I'm ok with the name changes but you will need to change Camino so it doesn't
have a regression which means that you'll need Simon Fraser or Mike Pinkerton
to give approval.

r- since this patch (as it is) is incomplete.

Comment 15

[[e-mail]]

(In reply to comment #14)
>(From update of attachment 172420 [details] [diff] [review] [edit])
>I'm unclear why you want to rename these commands.  Just to be compatible with
>the same command names in the xml or is something broken?
It appears that nsGlobalWindowCommands is inconsistent as the rest of Mozilla
(nsEditorCommands, nsNativeKeyBindings etc.) uses cmd_selectTop/Bottom.

Comment 16

[Ginn Chen]

Attachment: patch (include camino)

Comment 17

[Ginn Chen]

Comfirmed, the first patch will break Camino.
Thanks, brade.

I've tested the second patch on my build Camino.

It works well.

Comment 18

[Kathleen :Brade]

Comment on attachment 172548 [details] [diff] [review]
patch (include camino)

r=brade but it needs module owner permission; asking smfr but pink can also
approve.

Comment 19

[Ginn Chen]

Checking in dom/src/base/nsGlobalWindowCommands.cpp;
/cvsroot/mozilla/dom/src/base/nsGlobalWindowCommands.cpp,v  <-- 
nsGlobalWindowCommands.cpp
new revision: 1.15; previous revision: 1.14
done
Checking in camino/src/embedding/CHBrowserView.mm;
/cvsroot/mozilla/camino/src/embedding/CHBrowserView.mm,v  <--  CHBrowserView.mm
new revision: 1.51; previous revision: 1.50
done