WebGL google maps is upside down

VERIFIED FIXED in Firefox 10

Status

()

Core
Canvas: WebGL
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: jrmuizel, Assigned: jgilbert)

Tracking

({verified-beta})

10 Branch
mozilla11
All
Mac OS X
verified-beta
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox10+ fixed, firefox11 verified)

Details

(Whiteboard: [qa+][qa!:10])

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
Search for LAX with WebGL Maps and see that everything is flipped upside down.
(Assignee)

Comment 1

6 years ago
Does this not happen on other WebGL pages or demos?
(Reporter)

Comment 2

6 years ago
Not that I've seen.
(Assignee)

Comment 3

6 years ago
Does it replicate in Chrome?
(Reporter)

Updated

6 years ago
Keywords: regressionwindow-wanted
(Reporter)

Comment 4

6 years ago
(In reply to Jeff Gilbert [:jgilbert] from comment #3)
> Does it replicate in Chrome?

No.
I can't reproduce this with a local build. Graphics card is forced to integrated - Intel HD Graphics 3000.

Comment 6

6 years ago
Everything based on WebGL seems to be flipped upside down for me, not just google maps. (i.e. all the examples available at [1])

Reproduced with the 2011-11-22 Nightly on an OS X 10.7.2 MacBook Pro with an Intel HD 3000 graphics card (no discrete graphics card available on the machine, only the integrated one).  I'll be trying older builds as soon as I have some time.

[1]: http://forums.mozillazine.org/viewtopic.php?f=23&t=2090351

Screenshots:
http://img21.imageshack.us/img21/139/screenshot20111123at224.png
http://img207.imageshack.us/img207/4794/screenshot20111123at225.png
(Assignee)

Comment 7

6 years ago
Does this replicate with the pref cgl.prefer-fbo=true?

Comment 8

6 years ago
(In reply to Jeff Gilbert [:jgilbert] from comment #7)
> Does this replicate with the pref cgl.prefer-fbo=true?

No, it doesn't.  Setting that preference seems to fix it.
(Assignee)

Comment 9

6 years ago
Created attachment 576436 [details] [diff] [review]
Switch Mac to default to using FBOs instead of PBuffers

https://tbpl.mozilla.org/?tree=Try&rev=cf667016f3b2

I am going to need to confirm the absence of perf regressions between FBOs and PBuffers, but they should be very similar.
Attachment #576436 - Flags: review?(bjacob)
(Assignee)

Comment 10

6 years ago
From the earlier try run at https://tbpl.mozilla.org/?tree=Try&rev=48ffe4835f65 , it looks like we actually pass two new conformance tests by using FBOs.
Comment on attachment 576436 [details] [diff] [review]
Switch Mac to default to using FBOs instead of PBuffers

Review of attachment 576436 [details] [diff] [review]:
-----------------------------------------------------------------

Hurrah!
Attachment #576436 - Flags: review?(bjacob) → review+
¿uʍop ǝpısdn sıɥʇ sı :ɯɹıɟuoɔ oʇ ʇsnɾ ʞɔǝɥɔ ʞɔınb

Comment 13

6 years ago
d: (pǝddılɟ uɐɥʇ ɹǝɥʇɐɹ pǝʇɐʇoɹ sı sıɥʇ) ǝɹǝɥ uʍoɥs ǝnssı ǝɥʇ ǝʇınb ʇou s,ʇı ʇnq 'uʍop ǝpısdn sı sıɥʇ 'sǝʎ
(Assignee)

Comment 14

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c20e88fe6c1
Target Milestone: --- → mozilla11
(Assignee)

Updated

6 years ago
Blocks: 704615
https://hg.mozilla.org/mozilla-central/rev/9c20e88fe6c1
Assignee: nobody → jgilbert
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Duplicate of this bug: 703368
(Assignee)

Updated

6 years ago
Duplicate of this bug: 704615

Comment 18

6 years ago
(In reply to Emanuele Alimonda from comment #8)
> (In reply to Jeff Gilbert [:jgilbert] from comment #7)
> > Does this replicate with the pref cgl.prefer-fbo=true?
> 
> No, it doesn't.  Setting that preference seems to fix it.

I'm running the current Aurora (FF10) on OSX. I can't find this setting in about:config. Is it not in FF10, or is there another way to set it. I definitely have the bug :(
(Assignee)

Comment 19

6 years ago
It's a hidden pref, so you have to add it manually. (It won't show up by default) Just add a boolean pref called "cgl.prefer-fbo" and set it to true.

Comment 20

6 years ago
(In reply to Jeff Gilbert [:jgilbert] from comment #19)
> It's a hidden pref, so you have to add it manually. (It won't show up by
> default) Just add a boolean pref called "cgl.prefer-fbo" and set it to true.

Thanks, got it!
(Assignee)

Updated

6 years ago
Blocks: 718039
status-firefox10: --- → affected
status-firefox11: --- → fixed
Keywords: regressionwindow-wanted
As bug 718039 states this is still broken in Firefox 10. Asking for tracking Firefox 10.

Marking as verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:11.0a2) Gecko/20120113 Firefox/11.0a2 ID:20120113042010
Status: RESOLVED → VERIFIED
status-firefox11: fixed → verified
tracking-firefox10: --- → ?
Hardware: x86 → All
Version: unspecified → 10 Branch
(In reply to Henrik Skupin (:whimboo) from comment #21)
> As bug 718039 states this is still broken in Firefox 10. Asking for tracking
> Firefox 10.
> 
> Marking as verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
> rv:11.0a2) Gecko/20120113 Firefox/11.0a2 ID:20120113042010

Jeff - let's get this nominated for beta ASAP. This is a major regression that needs to be addressed on beta if deemed low risk.
tracking-firefox10: ? → +
(Assignee)

Comment 23

6 years ago
Created attachment 588952 [details] [diff] [review]
Switch Mac to default to using FBOs instead of PBuffers (fx10)

Patch for Beta (10).
Attachment #588952 - Flags: review?(bjacob)
Attachment #588952 - Flags: review?(bjacob) → review+
(Assignee)

Comment 24

6 years ago
Comment on attachment 588952 [details] [diff] [review]
Switch Mac to default to using FBOs instead of PBuffers (fx10)

[Approval Request Comment]
Regression caused by (bug #): Unknown, fixed here in 11+.
User impact if declined: WebGL on Mac may display upside-down.
Testing completed (on m-c, etc.): Nearly identical (simple) patch already in 11+.
Risk to taking this patch (and alternatives if risky): Switching the default for a hidden (afaik undocumented) pref should carry little risk.
Attachment #588952 - Flags: approval-mozilla-beta?
(In reply to Jeff Gilbert [:jgilbert] from comment #24)
> Regression caused by (bug #): Unknown, fixed here in 11+.

Bi-secting for bug 718039 showed that at least for Angrybirds it has been regressed with bug 695912.
Comment on attachment 588952 [details] [diff] [review]
Switch Mac to default to using FBOs instead of PBuffers (fx10)

[Triage Comment]
Approving for beta since this is a recent regression, WebGL is strategically important, and this fix has been deemed low risk. FWIW I was also able to reproduce on my MB Air.
Attachment #588952 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(Assignee)

Comment 27

6 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/4c6bfe0434b0
Whiteboard: [qa+]
QA will verify this with the next beta candidate builds.
status-firefox10: affected → fixed
Duplicate of this bug: 703368

Comment 30

6 years ago
(In reply to Jeff Gilbert [:jgilbert] from comment #9)
> Created attachment 576436 [details] [diff] [review]
> Switch Mac to default to using FBOs instead of PBuffers
> 
> https://tbpl.mozilla.org/?tree=Try&rev=cf667016f3b2
> 
> I am going to need to confirm the absence of perf regressions between FBOs
> and PBuffers, but they should be very similar.

if anything FBO should be faster. I've seen how slow pbuffering is on a project of mine
(Assignee)

Comment 31

6 years ago
In one of my tests, it appeared we were getting faster readback from PBuffers. I should think that PBuffers should be as fast as FBOs, since the driver could just use FBOs as the backing for PBuffers.

Comment 32

6 years ago
Reads may be faster under Pbuffer, but writes are where the benefits of FBO's is seen the most.

Comment 33

6 years ago
Created attachment 592087 [details]
screenshot

Hi guys.

I have verified this on:
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0 beta 6
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0) Gecko/20100101 Firefox/10.0 beta 6

The google maps in WebGl mode aren't flipped upside down anymore but I've noticed another behavior:
- On MacOS X 10.7 - Google Maps - WebGl - with side menu enabled you can see some random straight lines (see the atachament).These are disappearing when scrolling. If I hide the side menu, the lines are gone. 
- On MacOS X 10.6.8 - the lines are present with and without the side menu.

I'll set this as verified on beta since the image is displayed properly but should I file a new bug with this behavior? On Google Chrome the lines are not present.

Thanks

Updated

6 years ago
Keywords: verified-beta
Whiteboard: [qa+] → [qa+][qa!:10]
This visual bug is almost certainly a driver issue that we can't do much about. We could try to see what Chrome is doing differently to steer clear of it, but at this point it doesn't seem to be worth the effort.
(Assignee)

Updated

6 years ago
Duplicate of this bug: 703832
You need to log in before you can comment on or make changes to this bug.