Closed Bug 703115 Opened 8 years ago Closed 8 years ago

Use an indicator on the URL bar to reflect security state

Categories

(Firefox for Android :: General, defect, P3)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- verified
fennec 11+ ---

People

(Reporter: aaronmt, Assigned: sriram)

References

Details

(Whiteboard: [QA+])

Attachments

(1 file, 2 obsolete files)

bug 695477 added the functionality to the favicon. Last I heard, there is interest in putting the functionality back into a 'lock' on the URL bar.
Assignee: nobody → sriram
Attached patch WIP (obsolete) — Splinter Review
This patch changes the site security indicator from favicon to a new lock on the right.

We need better resources for HDPI and XHDPI screens. Also, I am thinking of reusing the same ImageButton for stop and site security. In which case, there needs more plumbing for this patch (probably would be fixed as a part of Bug 697726).
Attachment #575017 - Flags: feedback?(mark.finkle)
Attached patch Patch (obsolete) — Splinter Review
This patch takes care of the stop button. Though the site security gets updated, they are visible only if stop button is not visible.

I thought of coupling both the buttons into one, the same way as favicons. Though the images can be changed easily, there would be an extra overhead of adding and removing event listeners (as stop has an event listener which site security doesnt). Hence I am having two ImageButtons.

The assets in these arent final. They needs to be replaced with high resolution ones.
Attachment #575017 - Attachment is obsolete: true
Attachment #575017 - Flags: feedback?(mark.finkle)
Attachment #575033 - Flags: review?(mark.finkle)
Depends on: 697726
Attached patch PatchSplinter Review
I had wrongly deleted a line to stop Progress spinner. I've fixed it in this patch.
Attachment #575033 - Attachment is obsolete: true
Attachment #575033 - Flags: review?(mark.finkle)
Attachment #575051 - Flags: review?(mark.finkle)
Priority: -- → P3
Attachment #575051 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/a0b5bd8b07a7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Samsung Nexus S (Android 2.3.6)
20111118040220
http://hg.mozilla.org/projects/birch/rev/9999a423d8ab

Shall I file a follow-up future enhancement if desired for making these clickable for cert display?
Status: RESOLVED → VERIFIED
Flags: in-litmus?(fennec)
Whiteboard: [QA+]
Duplicate of this bug: 700940
tracking-fennec: --- → 11+
Verified on Aurora 11.0a2 (2012-01-15) also .
Blue lock displayed for Identify verified, site operator unknown. (e.g https://mail.google.com/mail/)
Green lock displayed for Identity verified.  (e.g https://www.paypal.com)

Test case created in litmus:
https://litmus.mozilla.org/show_test.cgi?id=44957
https://litmus.mozilla.org/show_test.cgi?id=44958
Flags: in-litmus?(fennec) → in-litmus+
You need to log in before you can comment on or make changes to this bug.