703115 - Use an indicator on the URL bar to reflect security state

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Aaron Train [:aaronmt]]

bug 695477 added the functionality to the favicon. Last I heard, there is interest in putting the functionality back into a 'lock' on the URL bar.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: WIP

This patch changes the site security indicator from favicon to a new lock on the right.

We need better resources for HDPI and XHDPI screens. Also, I am thinking of reusing the same ImageButton for stop and site security. In which case, there needs more plumbing for this patch (probably would be fixed as a part of Bug 697726).

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch takes care of the stop button. Though the site security gets updated, they are visible only if stop button is not visible.

I thought of coupling both the buttons into one, the same way as favicons. Though the images can be changed easily, there would be an extra overhead of adding and removing event listeners (as stop has an event listener which site security doesnt). Hence I am having two ImageButtons.

The assets in these arent final. They needs to be replaced with high resolution ones.

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

I had wrongly deleted a line to stop Progress spinner. I've fixed it in this patch.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/a0b5bd8b07a7

Comment 5

[Aaron Train [:aaronmt]]

Samsung Nexus S (Android 2.3.6)
20111118040220
http://hg.mozilla.org/projects/birch/rev/9999a423d8ab

Shall I file a follow-up future enhancement if desired for making these clickable for cert display?

Comment 7

[Carla Nadastean]

Verified on Aurora 11.0a2 (2012-01-15) also .
Blue lock displayed for Identify verified, site operator unknown. (e.g https://mail.google.com/mail/)
Green lock displayed for Identity verified.  (e.g https://www.paypal.com)

Test case created in litmus:
https://litmus.mozilla.org/show_test.cgi?id=44957
https://litmus.mozilla.org/show_test.cgi?id=44958