703501 - Linking to comment in top link is not useful for the common workflow of editing fields

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Max Kanat-Alexander]

When I click on the link at the top of a bugmail, it's nearly always to see/change fields, and not to comment. Even if it were to comment, my comment box stands normally at the top of the comments, so scrolling up to it is annoying. I'd really rather just have the link go to the bug itself, and let me make up my mind what I'm going to do on the page.

Comment 1

[:glob ✱]

this isn't a bmo specific customisation - bug 365709 and bug 697371

Comment 2

[Max Kanat-Alexander]

  Oh wow. That definitely needs to be reverted. If the link in comments is a problem, then just get rid of it. It wasn't a hugely-asked-for feature, and when we implemented it, it just caused trouble.

Comment 3

[Frédéric Buclin]

Not a blocker. This code didn't land in 4.2. 5.0 only. As I said already, we could offer two links, so that everybody is free to choose the one he needs:

https://bugzilla.mozilla.org/show_bug.cgi?id=422256    (this bug)
https://bugzilla.mozilla.org/show_bug.cgi?id=422256#c2 (this comment)

Personally, my workflow is the same as mkanat, i.e. I'm more interested in bug fields than the bug comment. So IMO, we either propose both links, or we remove the one pointing to the comment. But let's not have a 4th bug about this topic!

Comment 4

[Dave Miller [:justdave]]

Did someone backport this for bmo or something?  This is currently live on bmo and we're certainly not even running 4.2 yet (still 4.0.2)

Comment 5

[David Lawrence [:dkl]]

(In reply to Dave Miller [:justdave] from comment #4)
> Did someone backport this for bmo or something?  This is currently live on
> bmo and we're certainly not even running 4.2 yet (still 4.0.2)

Yes. It was a simple change so we added it to bmo/4.0 and bmo/4.2.

dkl

Comment 6

[Max Kanat-Alexander]

Yeah, I think two links is too much space to take up for too little value. Let's just remove this feature from the text email.

Comment 7

[David Lawrence [:dkl]]

(In reply to Max Kanat-Alexander from comment #6)
> Yeah, I think two links is too much space to take up for too little value.
> Let's just remove this feature from the text email.

I am not opposed to putting it back similar to what I had not too long ago. Where the main link at the top of the email was to the bug itself. And then have a separate link to the actual comment near the comment itself in the email. It was felt that it was too cluttered or that people thought the link was part of the comment text. If we can come up with a way to make the link look separate from the comment text, I still feel that it is useful to be there somewhere.

dkl

Comment 8

[David Lawrence [:dkl]]

Attachment: Patch to revert bug old bug link and add comment link with comments (v1)

Patch that puts old bug link back to the way it was and shows a link near the comment to the bug comment. 

dkl

Comment 9

[Frédéric Buclin]

Comment on attachment 577702 [details] [diff] [review]
Patch to revert bug old bug link and add comment link with comments (v1)

> --- Comment #[% comment.count %] from [% comment.author.identity %] ---
>+--- [% urlbase %]show_bug.cgi?id=[% bug.id %]#c[% comment.count FILTER none %]

No, you are reimplementing bug 365709, which is why bug 697371 was then filed and finally this bug. We don't want any link in the comment itself as it's really too confusing. Let's remove it. That was a bad idea.

Comment 10

[Max Kanat-Alexander]

  Agreed, let's just remove it.

Comment 11

[David Lawrence [:dkl]]

Attachment: Patch to revert to old bug link (v2)

Patch that returns text bugmail to old style of showing buglink with out link to comment.

dkl

Comment 12

[Frédéric Buclin]

Comment on attachment 578044 [details] [diff] [review]
Patch to revert to old bug link (v2)

r=LpSolit

Comment 13

[David Lawrence [:dkl]]

trunk:
Committing to: bzr+ssh://[e-mail]/bugzilla/trunk
modified template/en/default/email/bugmail.txt.tmpl
Committed revision 8025

bmo/4.0:
Committing to: bzr+ssh://[e-mail]/bmo/4.0
modified template/en/default/email/newchangedmail.txt.tmpl
Committed revision 7974

bmo/4.2:
Committing to: bzr+ssh://[e-mail]/bmo/4.2
modified template/en/default/email/bugmail.txt.tmpl
Committed revision 7971.