705874 - Binary XML file line #6: Error inflating class org.mozilla.gecko.BrowserToolbar (Startup crash on Android 2.1)

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P5)

Description

[Nicolas B. Pierron [:nbp]]

version: Nightly -- fennec-11.0a1.en-US.android-arm-1.apk (13.70 M) downloaded the 11-28 13:10

The logcat is available at http://pastebin.mozilla.org/1388756

About the phone:
Type: Samsung Galaxy S 1
Model: GT-I9000
Firmware: 2.1-update1
Baseband: I9000XXJF3
Kernel: 2.6.29 umts_scm@S1-BUILD05 #2
Build: ECLAIR

Comment 1

[Julien Vermet | JulienDev]

The logcat is not available anymore. Can you upload it again and change the "How long should your post be retained?" setting to forever?

Comment 2

[Tony Chung [:tchung]]

sounds like a 2.1 crasher.  will start adding [eclair] to the whiteboard to track these bugs

Comment 3

[Doug Turner (:dougt)]

ram - can you list the devices that have this problem - we probably want to just mark these devices as unsupported.

Comment 4

[Sriram Ramasubramanian [:sriram]]

This is usually caused in 2.1 devices. I'm not sure if it's a problem with AT&T locked phones though.
http://stackoverflow.com/questions/7619945/android-resources-not-found-on-some-devices -- this specifies the exact problem observed.
Also, most of the APIs we use are targeted for level 8 and not 5. This could cause even more crashes.

(The best way to see if we are API level 5 complaint is by using Romaxa's scripts and loading our project in eclipse. Eclipse will check every line against the specified SDK and will show as where we are not using API level 5 methods).

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

We should blocklist the bad phones or just drop eclair support

Comment 7

[Nicolas B. Pierron [:nbp]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #4)
> This is usually caused in 2.1 devices. I'm not sure if it's a problem with
> AT&T locked phones though.

My phone was unlocked when I bought it in France. (mid September 2010)
About the logcat, I can ask someone to dump one again because I no longer have it.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

dropping priority. we could be dropping 2.1 support too.

Comment 9

[Patrick Walton (:pcwalton)]

Attachment: Logcat.

Logcat attached.

Comment 10

[Sriram Ramasubramanian [:sriram]]

We are using both "match_parent" and "fill_parent" on XML layout files (and some parts of code).
http://developer.android.com/reference/android/view/ViewGroup.LayoutParams.html#MATCH_PARENT -- is introduced only in API Level 8. This could be a reason for the crash.

Comment 11

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch to use fill_parent instead of match_parent

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 592997 [details] [diff] [review]
patch to use fill_parent instead of match_parent

Brad mentioned that only the XML is a problem. The Java constants are the same value. Let's see if this works.

Comment 13

[Cristian Nicolae (:xti)]

This issue occurs on the latest Nightly build for Samsung Galaxy S (2.1).

Log: http://pastebin.mozilla.org/1471130

--
Mozilla/5.0 (Android;Linux armv7l;rv:13.0a1)Gecko/20120201
Firefox/13.0a1 Fennec/13.0a1
Device: Samsung Galaxy S
OS: Android 2.1-update1

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

From the log:

E/AndroidRuntime( 3862): Caused by: android.content.res.Resources$NotFoundException: File 
...
E/AndroidRuntime( 3862): Caused by: org.xmlpull.v1.XmlPullParserException: Binary XML file line #5: <bitmap> requires a valid src attribute

Which is:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/drawable/address_bar_bg.xml#6

Is something about that "src" value not legal?

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Cristian Nicolae (:xti) from comment #13)
> This issue occurs on the latest Nightly build for Samsung Galaxy S (2.1).
> 
> Log: http://pastebin.mozilla.org/1471130
What's in that log is a different bug. Can you file a new bug to track it separately?


(In reply to Mark Finkle (:mfinkle) from comment #14)
> From the log:
> 
> E/AndroidRuntime( 3862): Caused by:
> android.content.res.Resources$NotFoundException: File 
> ...
> E/AndroidRuntime( 3862): Caused by: org.xmlpull.v1.XmlPullParserException:
> Binary XML file line #5: <bitmap> requires a valid src attribute
> 
> Which is:
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/
> drawable/address_bar_bg.xml#6
> 
> Is something about that "src" value not legal?
Yea, it doesn't exist on eclair. In fact, none of our drawables do.

Comment 16

[Brad Lassey [:blassey] (use needinfo?)]

btw... landed this on inbound, changeset ab671e01a7da

Comment 17

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Brad Lassey [:blassey] from comment #15)
> (In reply to Cristian Nicolae (:xti) from comment #13)
> > This issue occurs on the latest Nightly build for Samsung Galaxy S (2.1).
> > 
> > Log: http://pastebin.mozilla.org/1471130
> What's in that log is a different bug. Can you file a new bug to track it
> separately?

I file bug 723151 for it

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ab671e01a7da

Comment 19

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 592997 [details] [diff] [review]
patch to use fill_parent instead of match_parent

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: 
crash on startup on eclair
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky):
String changes made by this patch:

Comment 20

[Cristian Nicolae (:xti)]

Verified fixed on:

Mozilla/5.0 (Android;Linux armv7l;rv:13.0a1)Gecko/20120203
Firefox/13.0a1 Fennec/13.0a1
Device: Samsung Galaxy S
OS: Android 2.1-update1

Comment 21

[Cristian Nicolae (:xti)]

Reopening bug for aurora nom

Comment 22

[Alex Keybl [:akeybl]]

Comment on attachment 592997 [details] [diff] [review]
patch to use fill_parent instead of match_parent

[Triage Comment]
Mobile only - approved for Aurora 12 and Beta 11.

Comment 23

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/06e1d3d61dda

Comment 24

[Brad Lassey [:blassey] (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f757c1020dec

Comment 25

[Andreea Pod]

Crash no longer reproducible.

Verified fixed on:
Firefox 11 (tinderbox build): 1328844077/09-Feb-2012 20:42 
20120209192117	
Firefox 12: Firefox 12.0a2 (2012-02-09)
Firefox 13: Firefox 13.0a1 (2012-02-09)

Device: Samsung Galaxy S Captivate 
OS: Android 2.1-update1