70628 - file picker initially displays repeated file names upon click

Status: VERIFIED INVALID

(SeaMonkey :: UI Design, defect)

Description

[Scott Anderson]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.12-20smp i686; en-US; 0.9) Gecko/20010228
BuildID:    2001022808

This just started in the past few builds (20010226 or so). In the Save File (or
Open File) dialog, clicking down through directories will sometimes replace the
file listing the filename just above the directory that was clicked, repeating
the name down the widget until the new directory tree is built, at which point
the correct files are shown.

Prior to 0226 for a few builds clicking on the directory would not show
anything, just a blank list, even though there were files in the directory. I'm
assuming the fix for that bug probably introduced the new one.

Reproducible: Sometimes
Steps to Reproduce:
right-click on a displayed page and do 'Save As' (or attempt to download a file
to get the Save File dialog). 

Find a directory with a lot of subdirectories. Double click a directory in the
middle of the list. Sometimes the entry just above the clicked directory will
replace all of the files in the listing for a second or so, at which point the
repeated names will then be replaced by the actual directory listing of the
double-clicked directory.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I've been seeing this too, and it's definitely a recent behavior

Comment 2

[sairuh (rarely reading bugmail)]

i see this too; odd paiting behavior.

bryner, would this belong to you? if not, punt as needed. :)

Comment 3

[Brian Ryner (not reading)]

I believe this is a general tree behavior, I've seen the same thing before in
mailnews when deleting messages.  cc-ing hyatt.

Comment 4

[janne hayrynen]

(linux build 2001031408)

this is also a serious performance issue.

for example:
i have over 500 files in the root of my home directory. when i open a save file
dialog, find the subdir i want to change to and double click it. then this
misbehaviour, "displaying repeated filenames" happens, cpu usage hops up to 100%
for 5-10 seconds before the dialog shows the selected directory and becomes
responsive again. it makes changing directories very slow and cumbersome, and
this is on a 600mhz machine.

so what is actually happening when this drawing-misbehaviour happens, what
really hogs the cpu cycles? maybe it's not just a drawing issue but related to
purging the file-entries from the view/memory (a xul issue?). i don't really
know how these dialogs work but i'd suspect there's a lot more room there for
optimization, in the same category as changing the pref panels etc.

Comment 5

[Boris Zbarsky [:bzbarsky]]

see also bug 72482

Comment 6

[sairuh (rarely reading bugmail)]

since i keep running into this, i don't find this trivial. also nominating for
beta1 and catfood.

Comment 7

[Brian Ryner (not reading)]

tree bug. which will go away with my outliner rewrite of filepiker.

Comment 8

[Boris Zbarsky [:bzbarsky]]

er... should this really be invalid?  Bryner, if you have a bug for the outliner
rewrite should this not be dupped against that?

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 75725 has been marked as a duplicate of this bug. ***

Comment 10

[sairuh (rarely reading bugmail)]

i couldn't find an existing bug for the filepicker rewrite, so filed bug 75838.

Comment 11

[Boris Zbarsky [:bzbarsky]]

*** Bug 80133 has been marked as a duplicate of this bug. ***

Comment 12

[sairuh (rarely reading bugmail)]

mass verification of Invalid bugs: to find all bugspam pertaining to this,
set your search string to "MagaritaLuisaChascarilloAvoidsInvalidBugs".

if you think this particular bug is *still* an open issue, please make sure of
the following before reopening:

a. where relevant, do check that it's actually still a problem with ***recent
trunk builds*** on the all appropriate platform[s]

b. provide clear, compelling reasons why this bug should be considered a valid one.