75838 - rewrite file picker to use outliner

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect)

Description

[sairuh (rarely reading bugmail)]

summary sez it all. sorry, bryner --i couldn't find an existing bug for this. i
want to file this so that issues like bug 70628 can be duped [or, dependent if
necessary] against it.

Comment 1

[Brian Ryner (not reading)]

I checked in a work-in-progress version of this rewrite.  To try it out:

cvs up -rOUTLINER_FILEPICKER_BRANCH themes/modern/global/filepicker.css
themes/classic/global/win/filepicker.css xpfe/components/filepicker/res/content

Comment 2

[Brian Ryner (not reading)]

In addition to the above files, you will also need to get xpfe/components/jar.mn
from the branch.

Comment 3

[sairuh (rarely reading bugmail)]

*** Bug 73509 has been marked as a duplicate of this bug. ***

Comment 4

[Peter Trudelle]

*** Bug 72482 has been marked as a duplicate of this bug. ***

Comment 5

[Peter Trudelle]

Not critical for beta, so moving to 0.9.2.  Brian says the work is done though,
so if reviews come in before Friday it would still be good to land this for beta.

Comment 6

[Peter "jag" Annema]

I've looked at the stuff on the branch, it looks good. r=jag

Comment 7

[Brian Ryner (not reading)]

Attachment: xpfe/components/filepicker/res/content/nsFileView.js

Comment 8

[Brian Ryner (not reading)]

Attachment: Patch to filepicker.js and .xul, jar.mn, and filepicker.css

Comment 9

[Brian Ryner (not reading)]

Note that xpfe/components/filepicker/res/content/filepicker.css is also removed,
with this landing.

Comment 10

[Dan Rosen]

bryner: peter said you needed a hand landing this. how may i be of service? :)

Comment 11

[Blake Ross]

outlinercell-inset-header on the outlinercols is unnecessary.  Also, some of 
the functions would be easier to read if they had more descriptive parameter 
names.

sr=blake with all the stuff we discussed...

Comment 12

[arik devens]

i hate to say this but i'm not convinced this is ready yet...

i've seen some strange visual bugs including the list being entirely one file
name while it loads, the scrollbar not scrolling dynamically in directories with
many files, and weird jumpyness as the list comes in...

i've also had it lock up on me and this is all just with very basic usage...

the keyboard control feels slugish and the buttons don't feel quite right.

anyway this feels harsh and some of it is prob the limitations of xul and
outliner... not sure...

Comment 13

[arik devens]

i approve, course it's already checked in but what they hey ;-)

Comment 14

[Brian Ryner (not reading)]

branch is checked in.

Comment 15

[sairuh (rarely reading bugmail)]

vrfy fixed with verif and debug bits from 5/23. new/separate issues to separate
bugs. :)

Comment 16

[Boris Zbarsky [:bzbarsky]]

*** Bug 103476 has been marked as a duplicate of this bug. ***