Closed Bug 706908 Opened 8 years ago Closed 7 years ago

add Windows 8 to the OS list for gfx driver blacklisting

Categories

(Core :: Graphics, defect)

All
Windows 8
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18
Tracking Status
firefox16 + fixed
firefox17 --- fixed
firefox18 --- fixed

People

(Reporter: bjacob, Assigned: joe)

References

Details

(Whiteboard: [Win8])

Attachments

(3 files, 1 obsolete file)

No description provided.
Blocks: 711656
Blocks: 715401
Blocks: 741105
OS: All → Windows 8
Assignee: nobody → joe
I presume this is how it'll come up, but lacking Windows 8 I can't test.
Attachment #652858 - Flags: review?(netzen)
Er, pretend that I added a comma after Windows 7 too.
Comment on attachment 652858 [details] [diff] [review]
add Windows 8 to the platform list

Review of attachment 652858 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with , added :D
Not sure if you care or not, but you have kWindowsServer2003 listed already.
Server 2012 has the same value of 0x60002
Attachment #652858 - Flags: review?(netzen) → review+
Attached patch support Windows 8 from gfxInfo (obsolete) — Splinter Review
This should support Windows 8 (and, incidentally, Mac OS X 10.8). Coming next: some tests.

Benoit, do you remember how we broke the blacklist accidentally in previous Firefox versions? I remember it being about us changing an enumerated value and some comparison being wrong. I just don't want to repeat that!
Attachment #652876 - Flags: review?(bjacob)
The bug I was referring to is bug 711656.
Forgot the widgets/cocoa part of the patch.
Attachment #652876 - Attachment is obsolete: true
Attachment #652876 - Flags: review?(bjacob)
Attachment #652914 - Flags: review?(bjacob)
Attachment #652915 - Flags: review?(bjacob)
These patches don't compile for me on Windows 8, due to a missing comma in the gfxWindowsPlatform.h enum.
You have to pretend it's there, see Comment 2 :D
Attachment #652914 - Flags: review?(bjacob) → review+
Attachment #652915 - Flags: review?(bjacob) → review+
Blocks: 744672
Whiteboard: [Win8]
Blocks: 786076
Comment on attachment 652858 [details] [diff] [review]
add Windows 8 to the platform list

[Approval Request Comment]
Bug caused by (feature/regressing bug #): none
User impact if declined: Inability for us to block hardware acceleration on Windows 8 at all
Testing completed (on m-c, etc.): On m-c for a while
Risk to taking this patch (and alternatives if risky): Could break all blacklisting, though it *shouldn't* since we have a lot of tests
String or UUID changes made by this patch: none
Attachment #652858 - Flags: approval-mozilla-beta?
Attachment #652858 - Flags: approval-mozilla-aurora?
Comment on attachment 652914 [details] [diff] [review]
support windows 8 and os x 10.8 from gfxInfo

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or UUID changes made by this patch:
Attachment #652914 - Flags: approval-mozilla-beta?
Attachment #652914 - Flags: approval-mozilla-aurora?
Attachment #652915 - Flags: approval-mozilla-beta?
Attachment #652915 - Flags: approval-mozilla-aurora?
Attachment #652858 - Flags: approval-mozilla-beta?
Attachment #652858 - Flags: approval-mozilla-beta+
Attachment #652858 - Flags: approval-mozilla-aurora?
Attachment #652858 - Flags: approval-mozilla-aurora+
Attachment #652914 - Flags: approval-mozilla-beta?
Attachment #652914 - Flags: approval-mozilla-beta+
Attachment #652914 - Flags: approval-mozilla-aurora?
Attachment #652914 - Flags: approval-mozilla-aurora+
Attachment #652915 - Flags: approval-mozilla-beta?
Attachment #652915 - Flags: approval-mozilla-beta+
Attachment #652915 - Flags: approval-mozilla-aurora?
Attachment #652915 - Flags: approval-mozilla-aurora+
Blocks: 804144
You need to log in before you can comment on or make changes to this bug.