710064 - Make the "Update Add-ons Automatically" checkbox state depend on the extensions.update.enabled pref, in addition to the existing extensions.update.autoUpdateDefault pref.

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Steffen Wilberg]

Attachment: patch

In bug 701987, I made it that enabling the "Update Add-ons Automatically" checkbox also enables the extensions.update.enabled pref. That checkbox should also show its unchecked state if extensions.update.enabled is false, because we can't install updates automatically if we don't even check for them.

The use case is a user who has set extensions.update.enabled to false in Firefox 10 or earlier. In Firefox 11, the checkbox has been removed from the main options window by bug 701987. If he checks the options in the gears menu, he should see whether or not everything is set up for automatic updates.

Comment 1

[Dave Townsend [:mossop]]

Comment on attachment 581095 [details] [diff] [review]
patch

Can we get some tests here?

Comment 2

[Steffen Wilberg]

Attachment: with tests

Here you are.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 582102 [details] [diff] [review]
with tests

Looks good, thanks

Comment 4

[Steffen Wilberg]

http://hg.mozilla.org/integration/mozilla-inbound/rev/fbf296760b0f

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/fbf296760b0f