Closed Bug 710064 Opened 8 years ago Closed 8 years ago

Make the "Update Add-ons Automatically" checkbox state depend on the extensions.update.enabled pref, in addition to the existing extensions.update.autoUpdateDefault pref.

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
In bug 701987, I made it that enabling the "Update Add-ons Automatically" checkbox also enables the extensions.update.enabled pref. That checkbox should also show its unchecked state if extensions.update.enabled is false, because we can't install updates automatically if we don't even check for them.

The use case is a user who has set extensions.update.enabled to false in Firefox 10 or earlier. In Firefox 11, the checkbox has been removed from the main options window by bug 701987. If he checks the options in the gears menu, he should see whether or not everything is set up for automatic updates.
Attachment #581095 - Flags: review?(dtownsend)
Comment on attachment 581095 [details] [diff] [review]
patch

Can we get some tests here?
Attached patch with testsSplinter Review
Here you are.
Assignee: nobody → steffen.wilberg
Attachment #581095 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #581095 - Flags: review?(dtownsend)
Attachment #582102 - Flags: review?(dtownsend)
Comment on attachment 582102 [details] [diff] [review]
with tests

Looks good, thanks
Attachment #582102 - Flags: review?(dtownsend) → review+
https://hg.mozilla.org/mozilla-central/rev/fbf296760b0f
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
No longer depends on: 712617
You need to log in before you can comment on or make changes to this bug.