711700 - Disco pane should assume compatible-by-default when in Firefox version 10 or newer

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Discovery Pane, defect, P1)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

As an intermediate step towards bug 711698, the disco pane should just assume compatible-by-default is enabled for Firefox versions 10 and newer. This will be accurate for everyone who hasn't altered one of the hidden preferences that control the Add-on Manager's compatibility behaviour.

Comment 1

[Wil Clouser [:clouserw]]

Do you have some more details on what this entails?  What do you expect to change?

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to Wil Clouser [:clouserw] from comment #1)
> Do you have some more details on what this entails?  What do you expect to
> change?

So, the Disco pane shows addons in various sections of the page - AFAIK, most of those section will only show addons that AMO thinks are compatible. Which means a lot of addons are filtered out and never shown. But with compatible-by-default, a lot more add-ons are compatible. That can mean the difference between an empty (or not very relevant) looking Recommended section, and a full one (and more relevant).

Other sections, like "Pick of the Month" display the add-on regardless of whether AMO thinks it's compatible. If AMO thinks it's incompatible, it shows a warning - eg, the current Pick of the Month is Spingpad, which only declares compatibility up to Firefox 10, so the "Add to Firefox" button is greyed out with the warning "Not available for Firefox 11.0a1". With compatible-by-default, that actually is compatible.

Also, Rob asked about whether Firefox 10 and above will send the compatibility mode in the URL. Bug 711693 will make that happen - but it most likely won't make it into Firefox 10 (10 is merging into Beta tomorrow, and that fix isn't a critical regression/crash fix). I plan on landing it in 12, and backporting it to 11 (which will be on Aurora). So until that bug is fixed, we can just assume that Firefox 10 and above is running with compatible-by-default enabled.

Comment 3

[Rob Hudson [:robhudson]]

Should this still be done first? Or should we jump straight into bug 711698?

Comment 4

[Wil Clouser [:clouserw]]

Are they dupes?

Comment 5

[Rob Hudson [:robhudson]]

Not quite. This one was to assume 10+ was compat by default b/c the Addons Manager wouldn't be sending the compat mode parameter yet. The other bug is when the AOM is sending the parameter and to use that, which would be more accurate since the user can change it.

I'm thinking we may have missed the window for this bug to be relevant and should implement bug 711698. But I'd defer to Blair since I'm not sure when the URL param landed or what version it might have gotten back ported to?

Comment 6

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(Sorry for the delay.)

(In reply to Rob Hudson [:robhudson] from comment #5)
> I'm thinking we may have missed the window for this bug to be relevant and
> should implement bug 711698. But I'd defer to Blair since I'm not sure when
> the URL param landed or what version it might have gotten back ported to?

It's in Firefox 12. So it won't be in a release version of Firefox until April 24th.

Comment 8

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/be87504

Comment 9

[krupa raj[:krupa]]

Please put this behind a flag or revert. It is not ready to go out.