Closed Bug 715347 (download-manager) Opened 8 years ago Closed 8 years ago

Add basic Download Manager support

Categories

(Firefox for Android :: General, defect, P2)

ARM
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 12
Tracking Status
firefox11 --- verified
firefox12 --- verified
fennec 11+ ---

People

(Reporter: mfinkle, Assigned: mfinkle)

References

Details

(Whiteboard: [QA-])

Attachments

(3 files)

Attached patch patchSplinter Review
Android has a Download Manager. Since SDK 12, the Download Manager has supported a simple way to add external downloads to the service:
http://developer.android.com/reference/android/app/DownloadManager.html#addCompletedDownload%28java.lang.String,%20java.lang.String,%20boolean,%20java.lang.String,%20java.lang.String,%20long,%20boolean%29

This patch adds simple support using this API:
* Show "Downloads" menu (if Honeycomb or greater) that opens the Android Download Manager activity.
* When a Gecko download completes, we send a message to Java and use the Download Manager API to add the file.

It's my hope that we could use raw SQLite access for older versions of Android, at least back to Gingerbread. That's as far back as the system Download Manager seems to be supported.
Attached image menu
"Downloads" in menu
Assignee: nobody → mark.finkle
Attached image download manager
Gecko download in the system Download Manager
OS: Linux → Android
Hardware: x86 → ARM
Looks good to me. This is all we really need, especially if we can get it on Gingerbread as well.
Comment on attachment 585896 [details] [diff] [review]
patch

Let's see if we can get this moving ahead and do the raw sqlite investigation in bug 695178
Attachment #585896 - Flags: review?(mbrubeck)
tracking-fennec: --- → 11+
Priority: -- → P2
Attachment #585896 - Flags: review?(mbrubeck) → review+
https://hg.mozilla.org/mozilla-central/rev/8522883040c0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Blocks: 695178
Aurora nom?
Depends on: 716420
Comment on attachment 585896 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: no ability to see downloads at all
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): low risk
Attachment #585896 - Flags: approval-mozilla-aurora?
Comment on attachment 585896 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #585896 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 717071
Depends on: 717231
Alias: download-manager
Depends on: 717257
Samsung Nexus S (Android 4.0.3)/Samsung Galaxy Tab 10.1 (Android 3.1)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120119 Firefox/12.0a1 Fennec/12.0a1
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20120119 Firefox/11.0a2 Fennec/11.0a2

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45163
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45164
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45165
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45166
Status: RESOLVED → VERIFIED
Flags: in-litmus+
Whiteboard: [QA-]
Depends on: 721802
You need to log in before you can comment on or make changes to this bug.