715347 - (download-manager) Add basic Download Manager support

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Android has a Download Manager. Since SDK 12, the Download Manager has supported a simple way to add external downloads to the service:
http://developer.android.com/reference/android/app/DownloadManager.html#addCompletedDownload%28java.lang.String,%20java.lang.String,%20boolean,%20java.lang.String,%20java.lang.String,%20long,%20boolean%29

This patch adds simple support using this API:
* Show "Downloads" menu (if Honeycomb or greater) that opens the Android Download Manager activity.
* When a Gecko download completes, we send a message to Java and use the Download Manager API to add the file.

It's my hope that we could use raw SQLite access for older versions of Android, at least back to Gingerbread. That's as far back as the system Download Manager seems to be supported.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: menu

"Downloads" in menu

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: download manager

Gecko download in the system Download Manager

Comment 3

[Madhava Enros [:madhava]]

Looks good to me. This is all we really need, especially if we can get it on Gingerbread as well.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585896 [details] [diff] [review]
patch

Let's see if we can get this moving ahead and do the raw sqlite investigation in bug 695178

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8522883040c0

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8522883040c0

Comment 7

[Aaron Train [:aaronmt]]

Aurora nom?

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 585896 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: no ability to see downloads at all
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): low risk

Comment 9

[Alex Keybl [:akeybl]]

Comment on attachment 585896 [details] [diff] [review]
patch

[Triage Comment]
Mobile only - approved for Aurora.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ddca2bf272dc

Comment 11

[Aaron Train [:aaronmt]]

Samsung Nexus S (Android 4.0.3)/Samsung Galaxy Tab 10.1 (Android 3.1)
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20120119 Firefox/12.0a1 Fennec/12.0a1
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20120119 Firefox/11.0a2 Fennec/11.0a2

https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45163
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45164
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45165
https://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=45166