Closed Bug 71600 Opened 25 years ago Closed 25 years ago

Email prefs are broken.

Categories

(Bugzilla :: Bugzilla-General, defect)

x86
All
defect
Not set
critical

Tracking

()

VERIFIED FIXED
Bugzilla 2.12

People

(Reporter: gerv, Assigned: dmosedale)

References

()

Details

Attachments

(2 files)

Andreas added a comment and CCed himself on the above bug; I did not get bug mail (and he was told so at the time.) I have turned off CC notification in my bug preferences for when I am the reporter, but not comment notification. I suspect that, at the moment, it seems that you don't get email if you are uninterested in _any_ of the things which happened. The correct logic is for you not to get mail only if you are uninterested in _all_ of the things which happened. I think we should consider posting to n.p.m.announce telling people not to use the email prefs until we've resolved this - people may be losing important mail. Gerv
Bumping severity; dataloss. Nominating for 2.14, if not before. This should probably be assigned to dmose, but I'll let someone else do that. Gerv
Severity: normal → critical
Target Milestone: --- → Bugzilla 2.14
Have to be a 2.12 blocker.
Keywords: patch, review
Blocks: 71611
Target Milestone: Bugzilla 2.14 → Bugzilla 2.12
Nice detective work, Gerv & Andreas. I've attached a slightly simplified version of the patch.
Assignee: tara → dmose
*** Bug 71554 has been marked as a duplicate of this bug. ***
No longer blocks: 71611
*** Bug 71611 has been marked as a duplicate of this bug. ***
Fix checked in.
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Dan: Your patch is simpler, and it may work correctly. Be aware, however, that it relies on the following assumptions: - whenever this code is executed, the $userFlagString contains entries for _all_ possible combinations of 'email' . $emailGroup . $attribute - there is no typo in the code that generates the parameters passed in to filterEmailGroup If one of these assumptions is violated at some point in the future, it can result in (possibly hard-to-debug) lost email notifications. The reason is that in the "simplified" patch $person can be removed from $filteredList without finding a matching flag that has a value different from 'on'. I'm not saying that something must be changed, but the price for the simpler version is less robust code. Btw, if you want even simpler code, you can remove these lines from the current version of processmail 796 if ($flagName !~ /$emailGroup/) { 797 next; 798 } 799
*** Bug 71798 has been marked as a duplicate of this bug. ***
This bug seem to still exist in some form. See bug 71798 and bug 71818. Also, I didn't get notified about the fact that somebody cced me.
> Also, I didn't get notified about the fact that somebody cced me. Note that I might have had the cc changed on cced bug disabled at that time. Nevertheless, I want to get mail, when I am the one being cced or removed. (Similarily, I want others to get mail, when I cc them without comment, no matter what their prefs are.)
I agree with Ben, but this bug is closed. Opened new bug 71912 to cover request to change the CC notifications.
Reopening based on bug 72755. Changing CCs is still excluding people that want other mail.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
*** Bug 72755 has been marked as a duplicate of this bug. ***
I just reopened a bug and added text to it. I was excluded from the recipients of the mail about that change. My preferences indicate that I _do_ want to see messages where the description has changed, but do _not_ want to see messages where _only_ the status has changed. I believe this is another manifestation of this bug.
Note that Nelson has Exclude Self turned off. (so he should be getting copies of his own bug changes)
I'm marking this fixed. This I believe to be a duplicate of 71798.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Verified. fixed after 13 months. Better late than never?
Status: RESOLVED → VERIFIED
That "verified" comment was intended for a different bug report. So, I'll reopen and mark resolved fixed again.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Markign resolved/fixed again. Still unverified.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
BTW, I received email copies of only 2 of the last 3 changes I made to this bug. I did not receive a copy of the message when I reopened the bug.
Nelson, b.m.o has not "cvs update"ed yet, so that's the current expected behaviour.
Someone please add a comment to this bug when bugzilla.mozilla.org is running the fixed code. Thanks.
b.m.o's update log shows this as the last update: cvs update -d -P -D "Tue Apr 3 17:48:58 PDT 2001" which is after this was checked in.
V.
Status: RESOLVED → VERIFIED
Moving closed bugs to Bugzilla product
Component: Bugzilla → Bugzilla-General
Product: Webtools → Bugzilla
Version: Bugzilla 2.11 → unspecified
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: