Closed Bug 716098 Opened 8 years ago Closed 7 years ago

TB: Keyboard Shortcuts broken(?)/wrong/incomplete in documentation: Ctrl+H, Ctrl+Alt+H

Categories

(Thunderbird :: Help Documentation, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla2007, Assigned: bugzilla2007)

References

(Blocks 1 open bug)

Details

(Whiteboard: [needs followup against kitsune, can't use {for} to show/hide block-level elements like table rows])

+++ This bug was initially created as a clone of Bug #716093 +++

Thunderbird Keyboard Shortcuts documentation (1) currently has this:

Hide Thunderbird: Ctrl+H
Hide Other Windows: Ctrl+Alt+H

This doesn't work for Windows (and I don't think it ever did, or should). Does it work on other OS?

Maybe somebody can explain the expected and current behaviour for all OS, so that we can fix the documentation, or create bugs as necessary.

(1) https://support.mozillamessaging.com/en-US/kb/keyboard-shortcuts
This works on OS X, but it's not a Thunderbird shortcut - it's a system-wide Mac shortcut.
Status: NEW → ASSIGNED
Assignee: nobody → sreepriya1111
So it is just enough to delete those two shortcuts?
IMHO we should reference those keys for the MAC (reasons later)
I think we should include these shortcuts even if they are system-wide MAC shortcuts, because
- they work from within TB and have direct effect on the TB window
- I suppose even system-wide shortcuts could be hijacked by applications, so we should document that we respect the system-wide shortcuts and they can be applied without harm in TB
- complete reference is important so that coders know which shortcuts are taken on MAC OS when they are looking for free shortcuts for all OS, especially because these shortcuts fall into the range of the TB shortcut pattern Ctrl+Key.

Assuming that these shortcuts don't work on Unix, this will be MAC-only.
I think we want to show nothing for Windows, so markup requires {for} on separate lines:

{for mac}
Hide Thunderbird...
Hide Other Windows...
{/for}
(In reply to Thomas D. from comment #4)
> I think we should include these shortcuts even if they are system-wide MAC
> Assuming that these shortcuts don't work on Unix,

sreepriya, pls verify if the following shortcuts do anything in Linux:

STR
- TB9 on Linux, main mail window, focus on message list:
- Ctrl+H?
- Ctrl+Alt+H?

To get on with this, I have updated the documentation (1), assuming this to be  MAC-only.

> I think we want to show nothing for Windows, so markup requires {for} on
> separate lines:
> 
> {for mac}
> Hide Thunderbird...
> Hide Other Windows...
> {/for}

Hmmm. I tried this, but it doesn't work:
{|
{for mac}
|-
|Mactext||Mactext
{/for}
|-
|Text||Text
|}

I think the problem here is
{for} is always parsed as a span, span is inline by definition and thus it can't have blocklevel children like <tr>. The mac-span ends up inside the previous <tr>, so the hidden Mactext will always be shown. Not good.

So there is currently no way of hiding entire table rows based on selectors. Not good, and I guess it could be fixed.

For the meantime, I didn't like empty rows, so I just bundled the mac-specific commands, with their captions showing on any OS, but showing no shortcuts for non-Mac OS.

(1) https://support.mozillamessaging.com/en-US/kb/keyboard-shortcuts/revision/5614
Blocks: 720379
I had fixed this in the documentation as explained above.
Assignee: sreepriya1111 → bugzilla2007
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [needs followup against kitsune, can't use {for} to show/hide block-level elements like table rows]
You need to log in before you can comment on or make changes to this bug.