Closed Bug 716621 Opened 9 years ago Closed 9 years ago

Folder label/caption/name with new messages are misaligned in folder pane (is nearer to or overlaps the folder icon)

Categories

(Thunderbird :: Theme, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 13.0

People

(Reporter: andreasn, Assigned: andreasn)

References

Details

(Keywords: regression)

Attachments

(6 files)

It looks like labels for folders with new messages gets slighly misaligned with the rest of the labels.
Just as a note, it seems like the text is pushed over, so it's likely not a problem with the icon.  My wild guess is that some image element has a space after it (or not), and that's what's causing the mis-alignment.
Attached patch Quick fixSplinter Review
Changes the padding-left of the text from 16 to 21px.
Duplicate of this bug: 718447
Attachment #587086 - Flags: ui-review?(bwinton)
I have never seen this on linux. Is this something recent?
I hit this for the first on the beta channel a few weeks ago, perhaps when I got my first 10.0 beta
Yes, I also hit this on 10.0 beta 2.
Checked with padding-left:31px in userChrome.css.
cancel.png is 16px*16px "white X on red background" icon, so it's convenient to know center of the icon. Text color is canged to Read for ease of test result checking.

userChrome.css content. 
> @namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
>
> treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true),
> treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true, selected),
> treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true, focus),
> treechildren::-moz-tree-cell-text(folderNameCol, newMessages-true, selected, focus),
> treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true),
> treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true, selected),
> treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true, focus),
> treechildren::-moz-tree-cell-text(folderNameCol, specialFolder-Inbox, newMessages-true, selected, focus)
> {
>    color: #FF0000 !important;
>    background-color: #dddddd !important;
>    font-weight: bold !important;
>    margin-left: -16px !important;
>    padding-left: 31px !important;
>    background-image: url("file:///C:/wada/@@@/Data/Omni/Omni/chrome/classic/skin/classic/messenger/icons/cancel.png") !important;
>    background-repeat: no-repeat !important;
>    background-position: left !important;
> }

Upper  screen shot : Tb 9.0.1 on Win-XP.
  In Tb 9, space between cancel icon and red Inbox is wider than
  ordinal folder, because padding-left:31px is used by userChrome.css.
Bottom screen shot : Tb trunk daily build on Win-XP.
> Mozilla/5.0 (Windows NT 5.1; rv:12.0a1) Gecko/20120129 Thunderbird/12.0a1
  In Tb 12.0a1, space between cancel icon and red Inbox is same as
  space between folder icon and folder name of ordinal folder,
  because same padding-left:31px is appropriate.

Space between account icon/folder icon(list-style-image) and account name/folder name(text box for list item) is different between Tb 9 and Tb 12.0a1(in Tb 12.0a1, perhaps 5px wider than Tb 9).
This is reason why larger padding-left: than Tb 9 is needed in Tb 10 or later.

Cause is tricky overlay of star icon on folder icon.
(1) Put a starmark image at left of text box by background-image.
(2) Shift string in text box(text of list item) to right by padding-left: AApx.
(3) Shift whole text box of list item to left by margin-left: -BBpx,
    in order to place starmark image upon folder icon(list-style-image).
In Tb on Win, icons for newMessages-true is added in second row of folder.png,
> http://mxr.mozilla.org/comm-central/source/mail/themes/qute/mail/icons/folder.png
and "star mark on folder icon" is controlled by image clip position only in folderpPane.css.
Inbox example in folderPane.css.
> treechildren::-moz-tree-image(folderNameCol, specialFolder-Inbox)
> { -moz-image-region: rect(0 48px 16px 32px); }
> treechildren::-moz-tree-image(folderNameCol, specialFolder-Inbox, newMessages-true)
> { -moz-image-region: rect(16px 48px 32px 32px); }
Many code changes and new folder.png is needed in this way than current slightly tricky way. But I think simplest way is best.
I can now see this too on Linux with TB10. It was not there in TB9.
Keywords: regression
Duplicate of this bug: 725124
There are also cases where the text is offset more that some pixels and even overlaps the icon. Is it the same problem? See bug 725124.
Summary: Folder labels with with new messages are misaligned in folder pane → Folder label/caption/name with new messages are misaligned in folder pane (is nearer to or overlaps the folder icon)
Comment on attachment 587086 [details] [diff] [review]
Quick fix

Okay, finally back on my request queue.

Since I don't have a linux box handy here, I'm going to pass this ui-r over to Andreas.

But I will say that if the UI is fine, the code seems reasonable.

Thanks,
Blake.
Attachment #587086 - Flags: ui-review?(nisses.mail)
Attachment #587086 - Flags: ui-review?(bwinton)
Attachment #587086 - Flags: review+
Attached image Patch in action
I can't take this ui-review from bwinton, as I did the patch.
This screenshot should make the review possible without a linux build though.
Comment on attachment 587086 [details] [diff] [review]
Quick fix

Reassigning this ui-review back to Blake. Hopefully the screenshot should do as evidence that this fix works.
Attachment #587086 - Flags: ui-review?(nisses.mail) → ui-review?(bwinton)
Comment on attachment 587086 [details] [diff] [review]
Quick fix

Looks good, based on the screenshot.  ui-r=me!  ;)

Thanks,
Blake.
Attachment #587086 - Flags: ui-review?(bwinton) → ui-review+
Duplicate of this bug: 728732
These bugs start to crop up because TB10 was released with the problem. And I still haven't got reply to comment 11. How should I proceed with duping the bugs?
Keywords: checkin-needed
Checked in: http://hg.mozilla.org/comm-central/rev/6ecb91c6405a
Assignee: nobody → nisses.mail
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 13.0
Still no answer and the reports continue, as this is only in TB13.
Duplicate of this bug: 748700
This issue is not fixed, I want the original behaviour back, not the large empty space between icon and text.
I haven't seen this bug before, but now I see it constantly in TB14 (Ubuntu 12.04 64-bit, Gnome). Sorry.
This doesn't appear to be fixed/resolved in Thunderbird 15.0.1 Linux (Ubuntu 12.04 32-bit), yet the status of this ticket is marked RESOLVED FIXED.
Folder text overlays icon image when receiving new email.
Problem still appears in TB 16.0.1, Ubuntu 12.04 64-bit.
(In reply to Yaron Sheffer from comment #26)
> Problem still appears in TB 16.0.1, Ubuntu 12.04 64-bit.

file anew bug please.
Or we should undupe bug 728732, bug 748700 and bug 725124 that have the same problem on the screenshot. So that no new bug needs to be filed.
You need to log in before you can comment on or make changes to this bug.