721504 - Set up compatibility bump for Thunderbird 10 -> 11

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Compatibility Tools, defect)

Description

[:Irving Reid (No longer working on Firefox)]

+++ This bug was initially created as a clone of Bug #707938 +++

We need to run a compatibility bump for all Thunderbird add-ons from version 10 to 11.

In addition to the Firefox 10 -> 11 changes, the specific list for Thunderbird is below.

Interface changes:

mailnews/base/public/nsIMsgProtocolInfo.idl: Bug 39121
   removed attribute specialFoldersDeletionAllowed

mailnews/compose/public/nsIMsgQuote.idl: Bug 351109
   Modified method nsIMsgQuote::quoteMessage, added parameter aOrigHdr

mailnews/compose/public/nsISmtpUrl.idl: Bug 711980
  Modified signature for nsIMailtoUrl::GetMessageContents:
     renamed to nsIMailtoUrl::getMessageContents (lower case 'g')
     most parameter types changed from ACString to AUTF8String
  Changed type of the following attributes from ACString to AUTF8String:
    nsISmtpUrl.fromPart
    nsISmtpUrl.followUpToPart
    nsISmtpUrl.organizationPart
    nsISmtpUrl.replyToPart
    nsISmtpUrl.priorityPart
    nsISmtpUrl.newsHostPart

mailnews/import/comm4x/public/nsIComm4xProfile.idl: CAN'T FIND CHANGE
  file removed
  interface nsIComm4xProfile removed

mailnews/import/public/nsIImportService.idl: bug 681647
  method [noscript] nsIImportService::ProxySend removed



Javascript changes:

mail/base/content/mailCore.js: Bug 644169
  onViewToolbarCommand() removed

mail/base/content/nsContextMenu.js: Bug 680192
  nsContextMenu() - added 'isShift' parameter to constructor
  nsContectMenu.initMenu() - added 'isShift' parameter

mail/base/modules/mailMigrator.js: Bug 712395
  MailMigrator.migrateMail()  renamed to migratePostAccountWizard()

mail/components/compose/content/MsgComposeCommands.js: Bug 708982
  function AddUrlAttachment() deprecated though still available

mailnews/extensions/newsblog/content/feed-subscriptions.js: Bug 705504
  makeFeedObject() added parameter aFolder to middle of parameter list

mailnews/extensions/newsblog/content/utils.js: Bug 705504
  deleteFeed() added aParentFolder parameter



Local file changes:

editor/ui/locales/en-US/chrome/composer/editorOverlay.dtd: Bug 694027
  the following strings were moved to editingOverlay.dtd:
    newToolbarCmd.label
    newToolbarCmd.tooltip
    openToolbarCmd.label
    openToolbarCmd.tooltip
    saveToolbarCmd.tooltip
    publishToolbarCmd.tooltip

mail/locales/en-US/chrome/messenger/messenger.dtd
  messengerWindow.title removed: Bug 701671
  folderContextSearchMessages.label renamed to folderContextSearchForMessages.label: Bug 652555
  folderContextSearchMessages.accesskey renamed to folderContextSearchForMessages.accesskey: Bug 652555

mail/locales/en-US/chrome/messenger/migration/migration.dtd: Bug 689437
  importFromSeamonkey2.label  renamed to importFromSeamonkey3.label
  importFromSeamonkey2.accesskey  renamed to importFromSeamonkey3.accesskey

editor/ui/locales/en-US/chrome/composer/editor.properties: Bug 102275
  untitled  renamed to untitledTitle with a parameter added (eg, untitled-1, untitled-2)

mail/locales/en-US/chrome/messenger/comm4xMailImportMsgs.properties
  File removed

mail/locales/en-US/chrome/messenger/importMsgs.properties: Bug 689437
  profileTitle  removed
  profileText  removed

mail/locales/en-US/chrome/messenger/messenger.properties: Bug 39121
  specialFolderDeletionErr  removed
  specialFolderDeletionErrTitle  removed

mail/locales/en-US/chrome/messenger/migration/migration.properties: Bug 689437
  sourceNameSeamonkey  removed
  sourceNameOExpress   removed
  sourceNameOutlook    removed


mail/locales/en-US/chrome/messenger/prefs.properties: Bug 709020
  failedDuplicateAccount  removed

Comment 1

[Mark Banner (:standard8)]

(In reply to Irving Reid (:irving) from comment #0)
> mailnews/compose/public/nsISmtpUrl.idl: Bug 711980
>   Modified signature for nsIMailtoUrl::GetMessageContents:
>      renamed to nsIMailtoUrl::getMessageContents (lower case 'g')
>      most parameter types changed from ACString to AUTF8String
>   Changed type of the following attributes from ACString to AUTF8String:
>     nsISmtpUrl.fromPart
>     nsISmtpUrl.followUpToPart
>     nsISmtpUrl.organizationPart
>     nsISmtpUrl.replyToPart
>     nsISmtpUrl.priorityPart
>     nsISmtpUrl.newsHostPart

We don't need to test for the attributes in the bump - ACString -> AUTF8String is just coping with L10n, so if extensions do use those interfaces, it'll seamlessly work better

> mailnews/import/comm4x/public/nsIComm4xProfile.idl: CAN'T FIND CHANGE
>   file removed
>   interface nsIComm4xProfile removed

Bug 689437

> mailnews/import/public/nsIImportService.idl: bug 681647
>   method [noscript] nsIImportService::ProxySend removed

No need to test for this in the bump. It was noscript anyway.

> mail/locales/en-US/chrome/messenger/comm4xMailImportMsgs.properties
>   File removed

Bug 689437

Comment 2

[Andrei [:sancus]]

This is fixed in https://github.com/Sancus/amo-validator/commit/6cf36906817d3c9e4c87c7e56ac7aad7be0df259 and will go live with the next AMO update.