722657 - Panning problems with iframes

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Martijn Wargers (dead)]

Attachment: testcase

Tested on the LG Optimus Black, Android 2.2.2 in portrait mode.

Steps to reproduce:
- Do a fling action upwards to scroll down in the iframe

Expected result:
- Content inside iframe scrolls downward in reasonable speed

Actual result:
- Content inside iframe scrolls down much slower than expected

Also, I noticed that swiping over the iframes doesn't really scroll the iframe content much, scrolling goes quite slow.

Comment 1

[Martijn Wargers (dead)]

I made a video of it here: http://www.youtube.com/watch?v=6P1p6z7BcKU

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Issue can be seen on reader.google.com

Comment 8

[Nathan Toone [:toonetown]]

Seeing the same issue with standard frameset on, for example, http://www.cougarfan.com/article.asp?ArtID=75914&URL=http://www.sltrib.com/sltrib/blogsbyusports/53873304-65/byu-martineau-rose-coach.html.csp

This page behaves almost exactly like http://di.se - (from bug 723945 - which was marked as a duplicate of this one)

Comment 9

[Kartikaya Gupta (email:[e-mail])]

While investigating some subdocument scrolling issues, I found a rather glaring bug that causes this issue. Will upload a patch shortly, it's an easy fix. Re-noming because I think this should block 1.0 - it happens on a range of websites and our subdocument scrolling behaviour really is quite atrocious.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

Attachment: Save the pending displacement if we can't send it right away

Comment 11

[Chris Lord [:cwiiis]]

Comment on attachment 620314 [details] [diff] [review]
Save the pending displacement if we can't send it right away

Review of attachment 620314 [details] [diff] [review]:
-----------------------------------------------------------------

heh, well caught :) Looks good to me.

::: mobile/android/base/ui/SubdocumentScrollHelper.java
@@ +60,5 @@
>  
>      private boolean mOverridePanning;
>      private boolean mOverrideScrollAck;
>      private boolean mOverrideScrollPending;
>      private boolean mScrollSucceeded;

I had a hard time reading this patch, I think it'd be good to add some documentation for these variables while you're changing code here.

Comment 12

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/6483b38af5c0

Fixed, but leaving open so it doesn't fall off the fennec-1.0 triage list; I still want the blocking nom to be resolved.

Comment 13

[Kartikaya Gupta (email:[e-mail])]

(In reply to Kartikaya Gupta (:kats) from comment #12)
> Fixed, but leaving open so it doesn't fall off the fennec-1.0 triage list; I
> still want the blocking nom to be resolved.

Actually, I'll just request aurora on the patch, seems simpler.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 620314 [details] [diff] [review]
Save the pending displacement if we can't send it right away

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: scrolling on pages with frames is barely possible
Testing completed (on m-c, etc.): locally, on m-c for a couple of days now and i haven't heard any complaints
Risk to taking this patch (and alternatives if risky): mobile-only, low risk
String changes made by this patch: none

Comment 15

[Demetrius S.]

Kats, I've noticed with the iframes is that even while scrolling down it is very easy to cause unintentional horizontal scrolling. This creates jerkiness. This is a problem when scrolling within the iframe and just scrolling the entire page.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

(In reply to Demetrius Schwab from comment #15)
> Kats, I've noticed with the iframes is that even while scrolling down it is
> very easy to cause unintentional horizontal scrolling. This creates
> jerkiness. This is a problem when scrolling within the iframe and just
> scrolling the entire page.

Yes, the patches on bug 732364 should fix this behaviour by applying axis-locking to the scrolling in iframes. Do you still see the issue on the latest nightly?

Comment 17

[Demetrius S.]

No the issue appears to have been solved

Comment 18

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2ab23fcaa8ca

Comment 19

[Cristian Nicolae (:xti)]

This issue is not reproducible anymore on page with iframes.

Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-16)
Firefox 14.0b3

Device: Galaxy Nexus
OS: Android 4.0.2