--enable-official-branding should be in the release mozconfig only whitelist

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: aki)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [automation][releases])

Attachments

(2 attachments)

(Reporter)

Description

7 years ago
We don't use this flag for anything but release builds.

2012-02-08 05:31:05,488 : ERROR : not in release mozconfig's whitelist (releases/mozilla-release/win32/nightly) : ac_add_options --enable-official-branding
Assignee: nobody → lsblakk

Comment 1

7 years ago
The flag appears to be useless with latest code, fx-10 built with --disable-officia-branding are still built with branding icons, I have also tested the current beta build and still see official branding icons and naming.
Comment 1 isn't relevant to this bug (and I'm pretty sure it's also inaccurate and/or a misunderstanding).
Assignee: lsblakk → aki
(Assignee)

Updated

7 years ago
Duplicate of this bug: 725309
(Assignee)

Comment 4

7 years ago
Created attachment 602193 [details] [diff] [review]
add -m and -l options to release_sanity.py to skip mozconfig and l10n dashboard checking

This isn't strictly required, but it made my local testing a lot less noisy by letting me specify -l to skip the l10n dashboard checks.
Attachment #602193 - Flags: review?(bhearsum)
(Assignee)

Comment 5

7 years ago
Created attachment 602194 [details] [diff] [review]
get firefox mozconfig checks to 0 errors

Tested against release-firefox-mozilla-{release,beta,esr10}.py.

* removed trailing whitespace
* removed old mobile platforms (maemo, linux-desktop, linux-android from non-esr10 branches)
* added the -j4 line to the branches
* added esr10 to the whitelist
* key off the branch_name instead of branch in the whitelist dict (fixed the --official-branding problem)

This patch is meant to apply on top of the patch in bug 725300 and the checkL10n patch in this bug, but may apply without them.
Attachment #602194 - Flags: review?(lsblakk)
(Reporter)

Comment 6

7 years ago
Comment on attachment 602193 [details] [diff] [review]
add -m and -l options to release_sanity.py to skip mozconfig and l10n dashboard checking

Review of attachment 602193 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a ton for doing this!
Attachment #602193 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 7

7 years ago
Comment on attachment 602193 [details] [diff] [review]
add -m and -l options to release_sanity.py to skip mozconfig and l10n dashboard checking

http://hg.mozilla.org/build/tools/rev/0789913f53fc
Attachment #602193 - Flags: checked-in+
Comment on attachment 602194 [details] [diff] [review]
get firefox mozconfig checks to 0 errors

looks good, hope the next run is smooth!
Attachment #602194 - Flags: review?(lsblakk) → review+
(Assignee)

Comment 9

7 years ago
Comment on attachment 602194 [details] [diff] [review]
get firefox mozconfig checks to 0 errors

http://hg.mozilla.org/build/tools/rev/34e5ef632769
Attachment #602194 - Flags: checked-in+
(Assignee)

Comment 10

7 years ago
Firefox release_sanity mozconfig runs should be clean now.
Fennec is still open in bug 725294.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.