725303 - --enable-official-branding should be in the release mozconfig only whitelist

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

We don't use this flag for anything but release builds.

2012-02-08 05:31:05,488 : ERROR : not in release mozconfig's whitelist (releases/mozilla-release/win32/nightly) : ac_add_options --enable-official-branding

Comment 1

[Jory A. Pratt [:anarchy]]

The flag appears to be useless with latest code, fx-10 built with --disable-officia-branding are still built with branding icons, I have also tested the current beta build and still see official branding icons and naming.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment 1 isn't relevant to this bug (and I'm pretty sure it's also inaccurate and/or a misunderstanding).

Comment 4

[Aki Sasaki (not active)]

Attachment: add -m and -l options to release_sanity.py to skip mozconfig and l10n dashboard checking

This isn't strictly required, but it made my local testing a lot less noisy by letting me specify -l to skip the l10n dashboard checks.

Comment 5

[Aki Sasaki (not active)]

Attachment: get firefox mozconfig checks to 0 errors

Tested against release-firefox-mozilla-{release,beta,esr10}.py.

* removed trailing whitespace
* removed old mobile platforms (maemo, linux-desktop, linux-android from non-esr10 branches)
* added the -j4 line to the branches
* added esr10 to the whitelist
* key off the branch_name instead of branch in the whitelist dict (fixed the --official-branding problem)

This patch is meant to apply on top of the patch in bug 725300 and the checkL10n patch in this bug, but may apply without them.

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 602193 [details] [diff] [review]
add -m and -l options to release_sanity.py to skip mozconfig and l10n dashboard checking

Review of attachment 602193 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a ton for doing this!

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 602193 [details] [diff] [review]
add -m and -l options to release_sanity.py to skip mozconfig and l10n dashboard checking

http://hg.mozilla.org/build/tools/rev/0789913f53fc

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 602194 [details] [diff] [review]
get firefox mozconfig checks to 0 errors

looks good, hope the next run is smooth!

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 602194 [details] [diff] [review]
get firefox mozconfig checks to 0 errors

http://hg.mozilla.org/build/tools/rev/34e5ef632769

Comment 10

[Aki Sasaki (not active)]

Firefox release_sanity mozconfig runs should be clean now.
Fennec is still open in bug 725294.