847898 - Disable Android beam support on beta/release until a release with permissions bump

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Bug 726335 adds support to Fennec for sending and receiving a URL via Android Beam to FF 22. However this requires a change to our app permissions, as we need the NFC permission to make this work. Since the permissions change will prevent auto-updating from the Play Store, we should defer this change until a release with other permissions changes.

Therefore this change should be commented out or backed out on Beta once FF 22 is on Beta; this bug tracks that.

Comment 1

[Alex Keybl [:akeybl]]

The combination of this and bug 715736 (disabled in bug 844935) may now warrant manual updates in FF22 - are there any other permissions changes planned in upcoming releases? We don't want to delay new feature indefinitely.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

23 or 24 is the current target for WebRTC which we believe to contain permission changes.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Note to future self: see what margaret did in bug 851170 and maybe do that here as well.

Comment 4

[Alex Keybl [:akeybl]]

We haven't decided whether to do this for FF23 yet, but we should track it nonetheless.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch for Firefox 22 (remove all NFC code)

I'd like to land this on FF 22 only (currently aurora) to remove the NFC/Android Beam code from that release. I considered ifdef'ing it out somehow but that looked more complicated than just removing it entirely.

Try build in progress at https://tbpl.mozilla.org/?tree=Try&rev=095437e73c79

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Patch for Firefox 23 (put NFC behind an enabled confvar)

This one is for Firefox 23 (currently on central) and takes advantage of the AppConstants.java setup that Brian added recently (also in 23). It moves the Android Beam stuff behind a confvar that is enabled but is trivial to disable. Still building this; will flag for review once it's tested.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 738188 [details] [diff] [review]
Patch for Firefox 23 (put NFC behind an enabled confvar)

Tested that this works as expected.

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 738188 [details] [diff] [review]
Patch for Firefox 23 (put NFC behind an enabled confvar)


>-        if (Build.VERSION.SDK_INT >= 14) {
>+        if (AppConstants.MOZ_ANDROID_BEAM && Build.VERSION.SDK_INT >= 14) {

I was kinda expecting you to use the preprocessor here, but I guess we are trying to avoid that and this check should still work OK.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Landed the aurora patch on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/17868c13aab4

Waiting for inbound to reopen to land there.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4eb83cbb0845

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4eb83cbb0845

Comment 12

[Aaron Train [:aaronmt]]

Do we have a bug tracking when we want to remember to turn these on?

Comment 13

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Aaron Train [:aaronmt] from comment #12)
> Do we have a bug tracking when we want to remember to turn these on?

I'm not sure. That said, it is enabled on Fx23 and would need a bug to disabled it (via confvars.sh) when Fx23 goes to Beta.

However, it is my recollection that Fx23 is our "new permissions" release, so leaving this enabled for Fx23 would work out nicely.

Comment 14

[Kartikaya Gupta (email:[e-mail])]

Yeah this should be enabled on 23+. Unless something has changed and 23 is no longer the new permissions release, nothing else should need to be done for Android Beam support. I don't know what the deal is for the wallpaper permission though, I recall that was also supposed to be added for 23+.