Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Drop Windows 2000 support in comm-central

RESOLVED FIXED in Thunderbird 13.0

Status

Thunderbird
OS Integration
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
Thunderbird 13.0
All
Windows Vista
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 600319 [details] [diff] [review]
fix

Gecko drop Windows 2000 support...
(Assignee)

Updated

6 years ago
Attachment #600319 - Flags: review?(dbienvenu)
Depends on: 699247
(Assignee)

Updated

6 years ago
Duplicate of this bug: 730220
(Assignee)

Updated

6 years ago
Duplicate of this bug: 730218

Comment 3

6 years ago
Comment on attachment 600319 [details] [diff] [review]
fix

Thx for the patch...
Is this patch removing support for the mail unread notifications that work in XP? We're still supporting XP, AFAICT, just not Win 2K. I'm referring specifically to the SHSetUnreadMailCounts removal.

Comment 4

6 years ago
the patch builds and runs fine; I'd just like to make sure about the xp/win2k issue.
Depends on: 730212
Comment on attachment 600319 [details] [diff] [review]
fix

Review of attachment 600319 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/src/nsMessengerWinIntegration.cpp
@@ +357,5 @@
>  nsMessengerWinIntegration::Init()
>  {
>    nsresult rv;
>  
> +  // load shell dll. If no such dll found, return

Update the comment too or leave the return in.

::: mailnews/base/src/nsMessengerWinIntegration.h
@@ +63,5 @@
>      QUNS_ACCEPTS_NOTIFICATIONS = 5,
>      QUNS_QUIET_TIME = 6
>  } MOZ_QUERY_USER_NOTIFICATION_STATE;
>  
>  // this function is exported by shell32.dll version 5.60 or later (Windows XP or greater)

Nit: Update this comment too.
(In reply to David :Bienvenu from comment #3)
> Is this patch removing support for the mail unread notifications that work
> in XP? We're still supporting XP, AFAICT, just not Win 2K. I'm referring
> specifically to the SHSetUnreadMailCounts removal.

They are not removed: they are just used unconditionally now, aren't they?
Assignee: nobody → m_kato
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 13.0

Comment 7

6 years ago
(In reply to Serge Gautherie (:sgautherie) from comment #6)
> 
> They are not removed: they are just used unconditionally now, aren't they?

ah, thx, Serge, I think you're right.

Comment 8

6 years ago
Comment on attachment 600319 [details] [diff] [review]
fix

thx for the patch!
Attachment #600319 - Flags: review?(dbienvenu) → review+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/comm-central/rev/96a18db9f160
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Summary: Drop Windows 2000 support for c-c → Drop Windows 2000 support in comm-central
You need to log in before you can comment on or make changes to this bug.