731102 - Apply image conversion script to all other uploaded images

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[Wil Clouser [:clouserw]]

So, over in bug 593267 there is a script (https://github.com/jbalogh/zamboni/commit/d3a8a4ae6921a20e22061036e40e753b4ec03dd4) which converts all the user images from gif/jpg to png.  This is great, but it turns out our collection icons and screenshots and stuff are still filled with jpgs and gifs.  We should review that script and run it on all the other user uploads too.

If we don't do this before PHP is turned off, we'll have to bring along these embarrassing rewrites:

>    ## fallback on jpg or gif
>    RewriteCond %{REQUEST_FILENAME} !-f
>    RewriteCond %{REQUEST_FILENAME} .jpg$
>    RewriteRule ^img/uploads/(.*)\.jpg$ /img/uploads/$1.gif [L]
>
>    RewriteCond %{REQUEST_FILENAME} !-f
>    RewriteCond %{REQUEST_FILENAME} .png$
>    RewriteRule ^img/uploads/(.*)\.png$ /img/uploads/$1.jpg [L,N]

Comment 1

[Wil Clouser [:clouserw]]

This only affects collection_icons/ and previews/

Comment 2

[Wil Clouser [:clouserw]]

Patch for this is at https://github.com/clouserw/zamboni/commit/7a076585b2fcb7c64ed6d14c9478fcd25c04b6ec

You can see the complete output after running on a clone of current production at khan:~clouserw/convert.out

You can see the aftermath of the filesystem from the clone of production at khan:/tmp/clouserw until it gets GC'd

Comment 3

[Wil Clouser [:clouserw]]

script is here: https://github.com/mozilla/zamboni/blob/master/apps/amo/management/commands/convert_images_to_png.py

Comment 4

[krupa raj[:krupa]]

this looks okay. Verified fixed at https://addons-dev.allizom.org/en-US/firefox/collections/krupakrupa/this-is-a-collection/ and https://addons-dev.allizom.org/en-US/developers/addon/amazon123-toolbar/edit