732089 - Maple: keep resolution on the document instead of the xul window

Status: RESOLVED DUPLICATE of bug 732971

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Currently we have to try to keep the per document zoom in sync with the top level resolution. We should just set the resolution on the individual document window.

We may need to do some additional work to keep the java zoom in sync with the document resolution, but we already have problems with this.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

So it seems like this doesn't work, because we only read the resolution out of the top level presShell.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

QA+ : verify also that zooming and panning in the foreground tab and then switching to background tab does not cause the new foreground tab to become blurry.

Comment 4

[Joe Drew (not getting mail)]

Kats tells me that this bug encapsulates cleanup that will be needed after bug 732564 (which works around it) lands. Thus, it doesn't block landing.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

See bug 724770 also. Ideally we want to store the zoom someplace that it can be saved/restored during forward/back/reload navigation, along with the scroll position.

Comment 6

[Joe Drew (not getting mail)]

Mats, it makes more sense to us for layout to own this, because we don't understand all the interactions of presshells/etc.

Kats, can you give a brief description of what needs to be done to presshells/etc?

Comment 7

[Kartikaya Gupta (email:[e-mail])]

So right now when we need to zoom content, we have to call setResolution() on the top-level window's pres shell (i.e. window.top.QueryInterface(Ci.nsIInterfaceRequestor).getInterface(Ci.nsIDOMWindowUtils).setResolution) for it to work. This means that every time we switch tabs (which are <browser> elements in a deck contained within the top-level XUL window) we are re-setting the resolution on the top level window. What we would like to be able to do is have a different resolution stored on each of the <browser> pres shells, and basically have Gecko be aware of this. This means (1) taking it into account when clamping scroll coordinates (bug 732016) and (2) saving/restoring the zoom the way it does scroll coordinates (bug 724770).

Feel free to ping me if this is unclear or needs further explanations.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Also apparently there is bug 732971 which is basically a duplicate of this.

Comment 9

[Brad Lassey [:blassey] (use needinfo?)]

This seems like a dupe of bug 732971 to me. Please un-dupe if I'm wrong.