Closed Bug 739041 Opened 8 years ago Closed 8 years ago

Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey. (test_384370.js + 3 other failures)

Categories

(SeaMonkey :: Bookmarks & History, defect, P2, critical)

defect

Tracking

(firefox14 fixed, seamonkey2.11 fixed, seamonkey2.12 fixed)

VERIFIED FIXED
seamonkey2.12
Tracking Status
firefox14 --- fixed
seamonkey2.11 --- fixed
seamonkey2.12 --- fixed

People

(Reporter: sgautherie, Assigned: sgautherie)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [perma-orange] [test which aborts the suite])

Attachments

(5 files, 3 obsolete files)

7.70 KB, patch
neil
: review+
neil
: feedback+
Details | Diff | Splinter Review
8.24 KB, patch
mak
: review+
Details | Diff | Splinter Review
4.33 KB, patch
mak
: review+
neil
: feedback+
Details | Diff | Splinter Review
39.51 KB, patch
Details | Diff | Splinter Review
1.15 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
Might need to port 715099 first...

*****

{
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_384370.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_384370.js | couldn't import legacy bookmarks file: TypeError: importer.importHTMLFromFile is not a function - See following stack:

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_457441-import-export-corrupt-bookmarks-html.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_457441-import-export-corrupt-bookmarks-html.js | couldn't import corrupt bookmarks file: TypeError: ies.importHTMLFromFile is not a function - See following stack:

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarks_html.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarks_html.js | couldn't import legacy bookmarks file: TypeError: importer.importHTMLFromFile is not a function - See following stack:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/head.js | 2147500036 - See following stack:

TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarksRestoreNotification.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarksRestoreNotification.js |   Restore should not have failed - See following stack:
buildbot.slave.commands.TimeoutError: command timed out: 1200 seconds without output, attempting to kill
}
(Untested.) Can you check whether they succeed by themselves?
Attachment #609112 - Flags: review?(iann_bugzilla)
Depends on: 739056
(In reply to Serge Gautherie (:sgautherie) from comment #0)
> Might need to port 715099 first...

I filed bug 739056.
I don't know whether that actually blocks either patch here: testing should tell...
Severity: major → critical
Whiteboard: [perma-orange] → [perma-orange] [test which aborts the suite]
Comment on attachment 609112 [details] [diff] [review]
(Av1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part

Jens, could you test this/these patch?
Attachment #609112 - Flags: feedback?(jh)
Summary: Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey → Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey. (test_384370.js + 3 other failures)
Comment on attachment 609112 [details] [diff] [review]
(Av1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part

Ping for test and review.
Attachment #609112 - Flags: review?(neil)
Comment on attachment 609112 [details] [diff] [review]
(Av1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part

>+      var jsonFile = Services.dirsvc.get("ProfD", Ci.nsILocalFile);
>+      jsonFile.append("bookmarks.exported.json");
Please move all the code relating to the JSON file here, not just some of it.

>+  // Avoid default bookmarks import.
>+  gluesvc.QueryInterface(Ci.nsIObserver).observe(null, "initial-migration", null);
Presumably this relies on application changes?

>     // Force nsSuiteGlue::_initPlaces().
>     print("Simulate Places init");
>+    waitForImportAndSmartBookmarks(function () {
>+      // Check bookmarks.html has been imported, and a smart bookmark has been
>+      // created.
>+      let itemId = bs.getIdForItemAt(bs.toolbarFolder,
>+                                     SMART_BOOKMARKS_ON_TOOLBAR);
>+      do_check_eq(bs.getItemTitle(itemId), "example");
>+      // Check preferences have been reverted.
>+      do_check_false(Services.prefs.getBoolPref(PREF_IMPORT_BOOKMARKS_HTML));
>+
>+      next_test();
>+    });
>     bg.QueryInterface(Ci.nsIObserver).observe(null,
>                                               PlacesUtils.TOPIC_INIT_COMPLETE,
>                                               null);
The comment has got separated from the code on which it it commenting...
[This happens several times in this file.]
Comment on attachment 609112 [details] [diff] [review]
(Av1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part

(In reply to neil@parkwaycc.co.uk from comment #6)

> >+      var jsonFile = Services.dirsvc.get("ProfD", Ci.nsILocalFile);
> >+      jsonFile.append("bookmarks.exported.json");
> Please move all the code relating to the JSON file here, not just some of it.

I'm not sure what you want exactly:
my patch is how (the SM test was and) the FF test (still) is; I would rather keep them in sync'.

> >+  // Avoid default bookmarks import.
> >+  gluesvc.QueryInterface(Ci.nsIObserver).observe(null, "initial-migration", null);
> Presumably this relies on application changes?

Yes, see patch Bv1.

> The comment has got separated from the code on which it it commenting...
> [This happens several times in this file.]

Right, I'll sync' that, after patch Cv1-FF review.
Attachment #609113 - Flags: review?(neil)
(In reply to Serge Gautherie from comment #8)
> (In reply to comment #6)
> > (From update of attachment 609112 [details] [diff] [review])
> > >+      var jsonFile = Services.dirsvc.get("ProfD", Ci.nsILocalFile);
> > >+      jsonFile.append("bookmarks.exported.json");
> > Please move all the code relating to the JSON file here, not just some of it.
> I'm not sure what you want exactly:
> my patch is how (the SM test was and) the FF test (still) is; I would rather
> keep them in sync'.
There's no point splitting the JSON code into two functions. I want it all done in the same function. This should have been done in bug 730849, but you got away with it because of variable scoping, so you could alternatively move the callback to be an inner function of the test function.

> > >+  // Avoid default bookmarks import.
> > >+  gluesvc.QueryInterface(Ci.nsIObserver).observe(null, "initial-migration", null);
> > Presumably this relies on application changes?
> Yes, see patch Bv1.
Then, as per comment 1, those tests are unlikely to work without the changes.

> > The comment has got separated from the code on which it it commenting...
> > [This happens several times in this file.]
> Right, I'll sync' that, after patch Cv1-FF review.
Fair enough.
Comment on attachment 609113 [details] [diff] [review]
(Bv1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, application part
[Checked in: See comment 28]

>+        Components.utils.import("resource://gre/modules/BookmarkHTMLUtils.jsm");
>+        BookmarkHTMLUtils.importFromURL(fp.fileURL.spec, false);
Well, this seemed to work; at least I didn't get any errors. I don't have a convenient bookmark export file to test with though, unless there's one lying around in the test suite somewhere perhaps? Maybe mak knows of one.

> Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
> Components.utils.import("resource://gre/modules/Services.jsm");
> Components.utils.import("resource://gre/modules/AddonManager.jsm");
>+XPCOMUtils.defineLazyModuleGetter(this, "BookmarkHTMLUtils",
>+                                  "resource://gre/modules/BookmarkHTMLUtils.jsm");
> Components.utils.import("resource:///modules/Sanitizer.jsm");
> Components.utils.import("resource:///modules/mailnewsMigrator.js");
Odd placement...

>-          Services.obs.removeObserver(importObserver, "bookmarks-restore-success");
>-          Services.obs.removeObserver(importObserver, "bookmarks-restore-failed");
My copy of nsSuiteGlue.js just says "this", not "importObserver"...
Comment on attachment 609113 [details] [diff] [review]
(Bv1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, application part
[Checked in: See comment 28]

Seems to work. r=me with nits fixed.
Attachment #609113 - Flags: review?(neil) → review+
Comment on attachment 609112 [details] [diff] [review]
(Av1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part

r=me with nits fixed, once it's tested (I might test it myself later).
Attachment #609112 - Flags: review?(neil) → review+
Comment on attachment 612547 [details] [diff] [review]
(Cv1-FF) test_browserGlue_prefs.js: Move comment back to its related code
[Checked in: See comment 14]

Review of attachment 612547 [details] [diff] [review]:
-----------------------------------------------------------------

repeating r=me!

::: browser/components/places/tests/unit/test_browserGlue_prefs.js
@@ +85,5 @@
>  
>        run_next_test();
>      });
> +    // Force nsBrowserGlue::_initPlaces().
> +    print("Simulate Places init");

while here, please change it to do_log_info

@@ +118,5 @@
>  
>        run_next_test();
>      });
> +    // Force nsBrowserGlue::_initPlaces().
> +    print("Simulate Places init");

while here, please change it to do_log_info

@@ +153,5 @@
>  
>        run_next_test();
>      });
> +    // Force nsBrowserGlue::_initPlaces()
> +    print("Simulate Places init");

while here, please change it to do_log_info

@@ +189,5 @@
>  
>        run_next_test();
>      });
> +    // Force nsBrowserGlue::_initPlaces()
> +    print("Simulate Places init");

while here, please change it to do_log_info

@@ +221,5 @@
>  
>        run_next_test();
>      });
> +    // Force nsBrowserGlue::_initPlaces()
> +    print("Simulate Places init");

while here, please change it to do_log_info

@@ +256,5 @@
>  
>        run_next_test();
>      });
> +    // Force nsBrowserGlue::_initPlaces()
> +    print("Simulate Places init");

while here, please change it to do_log_info
Attachment #612547 - Flags: review?(mak77) → review+
Comment on attachment 612547 [details] [diff] [review]
(Cv1-FF) test_browserGlue_prefs.js: Move comment back to its related code
[Checked in: See comment 14]

https://hg.mozilla.org/mozilla-central/rev/ad90865125a2
Cv1, with comment 13 suggestion(s).
Attachment #612547 - Attachment description: (Cv1-FF) Move comment back to its related code → (Cv1-FF) Move comment back to its related code [Checked in: See comment 14]
Well, it's not much of a test...
With no patches: 12 pass, 5 fail, 2 hang
With both patches: 15 pass, 4 fail
(In reply to neil@parkwaycc.co.uk from comment #9)
> you could alternatively
> move the callback to be an inner function of the test function.

Is this patch what you want?
Attachment #612942 - Flags: feedback?(neil)
Attachment #612547 - Attachment description: (Cv1-FF) Move comment back to its related code [Checked in: See comment 14] → (Cv1-FF) test_browserGlue_prefs.js: Move comment back to its related code [Checked in: See comment 14]
Comment on attachment 612942 [details] [diff] [review]
(Dv1-FF) test_384370.js: Move after_import() into run_test(), Use Services.prefs too

>+        var jsonFile = Services.dirsvc.get("ProfD", Ci.nsILocalFile);
>+        jsonFile.append("bookmarks.exported.json");
Moving the function means that you don't have to redefine this...
Attachment #612942 - Flags: feedback?(neil) → feedback-
Dv1-FF, with comment 17 suggestion(s).
Attachment #612942 - Attachment is obsolete: true
Attachment #612971 - Flags: review?(mak77)
Attachment #612971 - Flags: feedback?(neil)
Attachment #612971 - Flags: review?(mak77) → review+
Attachment #612971 - Flags: feedback?(neil) → feedback+
Comment on attachment 612971 [details] [diff] [review]
(Dv1a-FF) test_384370.js: Move after_import() into run_test(), Use Services.prefs too
[Checked in: Comment 19]

https://hg.mozilla.org/mozilla-central/rev/239052b7e7b9
Attachment #612971 - Attachment description: (Dv1a-FF) test_384370.js: Move after_import() into run_test(), Use Services.prefs too → (Dv1a-FF) test_384370.js: Move after_import() into run_test(), Use Services.prefs too [Checked in: Comment 19]
Av1, resync'ed with Cv1a-FF and Dv1a-FF.
Attachment #609112 - Attachment is obsolete: true
Attachment #609112 - Flags: review?(iann_bugzilla)
Attachment #609112 - Flags: feedback?(jh)
Attachment #613030 - Flags: review?(neil)
Comment on attachment 613030 [details] [diff] [review]
(Av1a) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part
[Checked in: Comment 21]

http://hg.mozilla.org/comm-central/rev/01b27caa4bd8
Attachment #613030 - Attachment description: (Av1a) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part → (Av1a) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, tests part [Checked in: Comment 21]
Attachment #613030 - Flags: review?(neil)
Comment on attachment 609113 [details] [diff] [review]
(Bv1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, application part
[Checked in: See comment 28]

(In reply to neil@parkwaycc.co.uk from comment #10)

> I don't have a
> convenient bookmark export file to test with though, unless there's one
> lying around in the test suite somewhere perhaps?

This one?
http://mxr.mozilla.org/comm-central/find?text=&string=bookmarks.preplaces.html
http://mxr.mozilla.org/comm-central/search?string=bookmarks.preplaces.html&case=1&find=%2Fplaces%2Ftests%2F

> > Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
> > Components.utils.import("resource://gre/modules/Services.jsm");
> > Components.utils.import("resource://gre/modules/AddonManager.jsm");
> >+XPCOMUtils.defineLazyModuleGetter(this, "BookmarkHTMLUtils",
> >+                                  "resource://gre/modules/BookmarkHTMLUtils.jsm");
> > Components.utils.import("resource:///modules/Sanitizer.jsm");
> > Components.utils.import("resource:///modules/mailnewsMigrator.js");
> Odd placement...

I put it with the other gre/ and in A->B order :-|
If you do not want it there, just tell me where else to put it.

> >-          Services.obs.removeObserver(importObserver, "bookmarks-restore-success");
> >-          Services.obs.removeObserver(importObserver, "bookmarks-restore-failed");
> My copy of nsSuiteGlue.js just says "this", not "importObserver"...

Your Hg copy does because I fixed bug 741068 in the meantime ;-)


(In reply to neil@parkwaycc.co.uk from comment #15)
> Well, it's not much of a test...
> With no patches: 12 pass, 5 fail, 2 hang
> With both patches: 15 pass, 4 fail

I'll take that as an improvement ftb, as do have more bugs to port in this area :-|
Attachment #609113 - Flags: review?(iann_bugzilla) → feedback?(neil)
Try run for ae393e474d02 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ae393e474d02
Results (out of 29 total builds):
    success: 27
    warnings: 2
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/sgautherie.bz@free.fr-ae393e474d02
Comment on attachment 612971 [details] [diff] [review]
(Dv1a-FF) test_384370.js: Move after_import() into run_test(), Use Services.prefs too
[Checked in: Comment 19]

(In reply to Mozilla RelEng Bot from comment #23)
>     https://tbpl.mozilla.org/?tree=Try&rev=ae393e474d02

Succeeded.
(In reply to Serge Gautherie (:sgautherie) from comment #21)
> http://hg.mozilla.org/comm-central/rev/01b27caa4bd8

Ftr, with tests patch only:

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333782898.1333784170.19076.gz
WINNT 5.2 comm-central-trunk debug test xpcshell on 2012/04/07 00:14:58

test_384370.js
test_457441-import-export-corrupt-bookmarks-html.js
test_bookmarks_html.js
fail with "3 == 4" instead of "importHTMLFromFile is not a function".

test_bookmarksRestoreNotification.js
succeeds now.

test_browserGlue_corrupt_nobackup_default.js
still times out.
Comment on attachment 609113 [details] [diff] [review]
(Bv1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, application part
[Checked in: See comment 28]

> Components.utils.import("resource://gre/modules/XPCOMUtils.jsm");
> Components.utils.import("resource://gre/modules/Services.jsm");
> Components.utils.import("resource://gre/modules/AddonManager.jsm");
>+XPCOMUtils.defineLazyModuleGetter(this, "BookmarkHTMLUtils",
>+                                  "resource://gre/modules/BookmarkHTMLUtils.jsm");
> Components.utils.import("resource:///modules/Sanitizer.jsm");
> Components.utils.import("resource:///modules/mailnewsMigrator.js");
I think I'd prefer it on its own with blank lines before and after i.e.
Components.utils.import(...); (×5)

XPCOMUtils.defineLazyModuleGetter(...);

// etc.
Attachment #609113 - Flags: feedback?(neil) → feedback+
(In reply to Serge Gautherie from comment #22)
> (In reply to comment #10)
> > I don't have a
> > convenient bookmark export file to test with though, unless there's one
> > lying around in the test suite somewhere perhaps?
> This one?
mak pointed me to one, it might have been that one.

> > >-          Services.obs.removeObserver(importObserver, "bookmarks-restore-success");
> > >-          Services.obs.removeObserver(importObserver, "bookmarks-restore-failed");
> > My copy of nsSuiteGlue.js just says "this", not "importObserver"...
> Your Hg copy does because I fixed bug 741068 in the meantime ;-)
Fair enough. At least I get to blame IanN this time :-)
Comment on attachment 609113 [details] [diff] [review]
(Bv1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, application part
[Checked in: See comment 28]

http://hg.mozilla.org/comm-central/rev/abbe21c88c1a
Bv1, unbitrotted and with comment 26 suggestion(s).
Attachment #609113 - Attachment description: (Bv1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, application part → (Bv1) Port |Bug 482911 - [HTML5] Re-implement bookmarks.html parsing using the HTML5 parser| to SeaMonkey, application part [Checked in: See comment 28]
(In reply to Serge Gautherie (:sgautherie) from comment #25)

> test_384370.js
> test_457441-import-export-corrupt-bookmarks-html.js
> test_bookmarks_html.js
> fail with "3 == 4" instead of "importHTMLFromFile is not a function".

Still there.
SeaMonkey uses different numbers than Firefox in its two first tests [and I didn't touch that], I'm not sure what the cause is with the 3rd one though its hopefully the "same" one.
Neil, could you investigate what may have changed wrt that compared to before (= as in aurora/13 for example)?

> test_browserGlue_corrupt_nobackup_default.js

succeeds now.
(In reply to Serge Gautherie (:sgautherie) from comment #3)
> (In reply to Serge Gautherie (:sgautherie) from comment #0)
> > Might need to port 715099 first...
> 
> I filed bug 739056.
> I don't know whether that actually blocks either patch here: testing should
> tell...

Marco, would you know whether this bug actually depends on bug 739056?
(In reply to Serge Gautherie (:sgautherie) from comment #29)
> > test_browserGlue_corrupt_nobackup_default.js
> 
> succeeds now.

which revealed, on Linux and OS X:
{
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_browserGlue_smartBookmarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_browserGlue_smartBookmarks.js | 5 == 6 - See following stack:
}
which probably has the  "same" cause as the 3 other failures...
(In reply to Serge Gautherie (:sgautherie) from comment #30)
> Marco, would you know whether this bug actually depends on bug 739056?

most/all of the migration stuff is untested, so shouldn't block these tests from passing, the tests there may rather depend on changes to browserGlue.
Bug 743692 (additional) regression is fixed now.

***

This bug failures remain:
{
TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_384370.js | 3 == 4 - See following stack:

TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_457441-import-export-corrupt-bookmarks-html.js | 3 == 4 - See following stack:

TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarks_html.js | 3 == 4 - See following stack:

TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_browserGlue_smartBookmarks.js | 5 == 6 - See following stack:
}

(To be investigated...)
Fix
{
TEST-UNEXPECTED-FAIL | e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarks_html.js | 3 == 4 - See following stack:
[...]
JS frame :: e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarks_html.js :: testImportedBookmarks :: line 333
JS frame :: e:/builds/slave/test/build/xpcshell/tests/suite/common/places/tests/unit/test_bookmarks_html.js :: <TOP_LEVEL> :: line 174
}

Marco, can you confirm that it is expected that the separator is not imported (anymore?)?
Attachment #622141 - Flags: review?(iann_bugzilla)
Attachment #622141 - Flags: feedback?(mak77)
(In reply to Serge Gautherie (:sgautherie) from comment #34)
> Marco, can you confirm that it is expected that the separator is not
> imported (anymore?)?

The separators should be imported afaik, it's their names we don't import anymore, but this one doesn't even have a name...
The firefox bookmarks preplaces doesn't have a separator, so there may even be an actual regression here, indeed the old code had an handleSeparator, the new code is missing it :(

File a proper bug please.
Attachment #622141 - Flags: feedback?(mak77) → feedback-
Depends on: 753205
(In reply to Marco Bonardo [:mak] from comment #35)
> The separators should be imported
> 
> File a proper bug please.

Bug 753205 Submitted
Attachment #622141 - Attachment description: (Ev1) Fix regression "from" bug 731663 patch Av1b-SM → (Ev1) Fix regression "from" bug 731663 patch Av1b-SM [Fixed by bug 753205]
Attachment #622141 - Attachment is obsolete: true
Attachment #622141 - Flags: review?(iann_bugzilla)
This patch fixes the last 3 failures.

I did a brief history search:
*It looks like Firefox did this (implicitly) in bug 515435.
*I'm loath to try to track SeaMonkey story.


[Approval Request Comment]
No risk, test-only.
Attachment #622240 - Flags: review?(iann_bugzilla)
Attachment #622240 - Flags: approval-comm-aurora?
Comment on attachment 622240 [details] [diff] [review]
(Fv1) head_bookmarks.js: Fix DEFAULT_BOOKMARKS_ON_MENU value, Add documentation
[Checked in: Comment 39 & 41]

Whoever reviews this first.
Attachment #622240 - Flags: review?(neil)
Attachment #622240 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 622240 [details] [diff] [review]
(Fv1) head_bookmarks.js: Fix DEFAULT_BOOKMARKS_ON_MENU value, Add documentation
[Checked in: Comment 39 & 41]

http://hg.mozilla.org/comm-central/rev/57eea920a92e
Attachment #622240 - Attachment description: (Fv1) head_bookmarks.js: Fix DEFAULT_BOOKMARKS_ON_MENU value, Add documentation → (Fv1) head_bookmarks.js: Fix DEFAULT_BOOKMARKS_ON_MENU value, Add documentation [Checked in: Comment 39]
Attachment #622240 - Flags: review?(neil)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: seamonkey2.11 → seamonkey2.12
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1336731331.1336733556.26269.gz
Linux comm-central-trunk debug test xpcshell on 2012/05/11 03:15:31

V.Fixed, but for test_bookmarks_html.js which is bug 753205.

*****

(In reply to Marco Bonardo [:mak] from comment #32)
> (In reply to Serge Gautherie (:sgautherie) from comment #30)
> > Marco, would you know whether this bug actually depends on bug 739056?
> 
> shouldn't block these tests from passing,

No dependency afterall.
Status: RESOLVED → VERIFIED
No longer depends on: 739056
Whiteboard: [perma-orange] [test which aborts the suite] → [SM2.11 misses Fv1 patch] [perma-orange] [test which aborts the suite]
Attachment #622240 - Flags: approval-comm-aurora? → approval-comm-beta?
Attachment #622240 - Flags: approval-comm-beta? → approval-comm-beta+
Depends on: 767776
Whiteboard: [SM2.11 misses Fv1 patch] [perma-orange] [test which aborts the suite] → [c-n: 57eea920a92e to c-b][SM2.11 misses Fv1 patch] [perma-orange] [test which aborts the suite]
Keywords: checkin-needed
https://hg.mozilla.org/releases/comm-beta/rev/ef40a8db4ca6
Keywords: checkin-needed
Whiteboard: [c-n: 57eea920a92e to c-b][SM2.11 misses Fv1 patch] [perma-orange] [test which aborts the suite] → [SM2.11 misses Fv1 patch] [perma-orange] [test which aborts the suite]
Whiteboard: [SM2.11 misses Fv1 patch] [perma-orange] [test which aborts the suite] → [perma-orange] [test which aborts the suite]
Attachment #622240 - Attachment description: (Fv1) head_bookmarks.js: Fix DEFAULT_BOOKMARKS_ON_MENU value, Add documentation [Checked in: Comment 39] → (Fv1) head_bookmarks.js: Fix DEFAULT_BOOKMARKS_ON_MENU value, Add documentation [Checked in: Comment 39 & 41]
I'm still seeing this:
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1341492578.1341494097.13538.gz

TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_384370.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_398914.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_421483.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_457441-import-export-corrupt-bookmarks-html.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_bookmarks_html.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_bookmarksRestoreNotification.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_corrupt.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_corrupt_nobackup.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_corrupt_nobackup_default.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_distribution.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_migrate.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_prefs.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_restore.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_shutdown.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_browserGlue_smartBookmarks.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_clearHistory_shutdown.js | test failed (with xpcshell return code: 3), see following log:
TEST-UNEXPECTED-FAIL | e:\builds\slave\test\build\xpcshell\tests\suite\common\places\tests\unit\test_leftpane_corruption_handling.js | test failed (with xpcshell return code: 3), see following log:
(In reply to Philip Chee from comment #42)

> I'm still seeing this:
> http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1341492578.1341494097.
> 13538.gz

That is bug 767776 actually.
Depends on: 779716
You need to log in before you can comment on or make changes to this bug.