74145 - Caret appears in previously disabled input field when you enable it

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Kathleen :Brade]

In a Composer window, choose Insert Image
Click on the custom size radio button
Notice the caret blinking in the Height editbox.
Type "111"

Nothing appears in height editfield but the caret is blinking there.
The editfield needs to really take focus so typing works or the caret shouldn't 
blink.

(Oh, and if it were up to me, I'd put the focus in the width editfield instead of 
the height editfield).

Comment 1

[Charles Manske]

This used to work fine until brade commented it out in "doDimensionEnabling()"
in version 1.65!
Here's what caused the regression:
// not sure why we want to give the width field focus;
// it certainly doesn't make sense to do this in a generic
// enable/disable function which could be called at any time
//if (enable)
//  dialog.widthInput.focus();

But brade's point is correct, so the fix is to have a separate method that
does both "doDimensionEnabling()" and then sets focus to "width" edit field.

The reason that the caret jumps into the height editfield is not clear to
me at all, but it's why I included the "focus()" call in the first place.

Comment 2

[Charles Manske]

Attachment: Add new method onSelectImageSizeRadio that sets focus to "width" edit field

Comment 3

[Charles Manske]

Kathy: ready for review.

Comment 4

[Charles Manske]

Small change: I will use "SelectCustomSizeRadio()" as the new method name.

Comment 5

[Charles Manske]

So the real problem here is that setting a previously disabled input widget to
enabled causes a caret to appear. This is a general problem and should be solved
in editor-owned caret-setting code. Ignore 4/1/1 patch -- it's not the right
thing to do.

Comment 6

[Charles Manske]

Tony and I worked on this -- fix is in his tree.
r=cmanske

Comment 7

[anthonyd]

accepting

Comment 8

[anthonyd]

Attachment: dont set caret when enabling editor box

Comment 9

[Simon Fraser [no longer active]]

Erm, OK, but why are we still setting the selection to SELECTION_ON, when the 
field might not be focussed?

Comment 10

[anthonyd]

talked with sfraser, and checked in.

Comment 11

[Simon Fraser [no longer active]]

*** Bug 39999 has been marked as a duplicate of this bug. ***

Comment 12

[Simon Fraser [no longer active]]

*** Bug 66698 has been marked as a duplicate of this bug. ***

Comment 13

[Simon Fraser [no longer active]]

*** Bug 42003 has been marked as a duplicate of this bug. ***

Comment 14

[Kathleen :Brade]

verified on Mac mozilla optimized build from 4am today (including verification
of duplicate bugs).

Comment 15

[Serge Gautherie (:sgautherie)]

Acting on Duplicate resolution from bug 39999 comment 18:

*Moving 'Blocks: bug 39985, bug 64451' from bug 39999 to bug 74145.
 (Take further action as needed.)