742020 - "About Firefox" dialog has a gray strip at the bottom since 2012-03-27 nightly

Status: VERIFIED WORKSFORME

(Firefox :: General, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: screenshot of brokenness (from 2012-03-27 nightly)

STR:
 1.  Help | About Nightly

ACTUAL RESULTS: Gray strip at the bottom of the dialog
EXPECTED RESULTS: No gray strip.

See attached screenshots.

Regression range, from mozgregression tool:
Last good nightly: 2012-03-26
First bad nightly: 2012-03-27

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ba4983d9c1f9&tochange=c3cb87871829

This persists in today's nightly, too:
Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120403 Firefox/14.0a1

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: screenshot of expected rendering (from 2012-03-26 nightly)

Comment 2

[Daniel Holbert [:dholbert]]

(Note that in these About screenshots, the "Check for updates" / "Apply Update" button isn't visible -- that's because I've chmod'd the directory to be non-writable.  I've verified that I hit the same bug (gray strip at the bottom) when the button is visible, too, though.)

Also: from comparing the two screenshots, the primary difference seems to be that in the old build, "Updates available" is italicized, which compresses that phrase slightly and makes the window a few pixels skinnier.  That, in turn, bumps "channel" down to a new line, which makes the contents as a whole taller, so they fill up the dialog.

In contrast, in the new build, "channel" is _not_ on its own line, so the dialog's contents are shorter, which means they don't quite fill the dialog's requested height. (so it gets padded with gray at the bottom)

Something like that.

CC'ing margaret, since she was the last one I heard of to touch the "about" dialog and might have a chance of knowing what's going on. :)

Comment 3

[Daniel Holbert [:dholbert]]

I'm running Ubuntu 12.04 beta2, BTW.

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #2)
> Also: from comparing the two screenshots, the primary difference seems to be
> that in the old build, "Updates available" is italicized

Aha -- that changed in aboutDialog.css in this cset:
  http://hg.mozilla.org/mozilla-central/rev/178fcd971e59
which is in the regression range from comment 0.

Comment 5

[Daniel Holbert [:dholbert]]

Dao / Ian -- per the 2nd & 3rd paragraphs in Comment 2, bug 701205's italicization change has made the overall contents of the "About Firefox" dialog shorter, which in turn causes it to have an out-of-place gray strip at the bottom.

Can we adjust the height of the dialog to fix this, or something?

Comment 6

[Daniel Holbert [:dholbert]]

(See also bug 649366, which tracks the fact that this dialog pads with gray in the first place.  Previously, that gray padding was only visible when you manually changed the size of the dialog, but as of this bug here, it's visible all the time.)

Comment 7

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Possible fix

Daniel does this fix the problem for you?  Interestingly on my nightly on ubuntu 10.04 I always have a thin bar of that colour that is seemingly impossible to get rid of, possibly to do with the rounded corners?

Comment 8

[Dão Gottwald [:dao]]

Comment on attachment 612062 [details] [diff] [review]
Possible fix

see bug 649366 comment 9

Comment 9

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Better fix

This seems like a better fix since it accomplishes what I tried and failed to do before, which is to make the container expand to fill the window.  This is better than my previous patch as it will also fix this problem (and the resizing one) for aurora, whereas my previous patch was nightly-only. (Though actually testing aurora's about dialog, it doesn't seem to line break as much as nightly's does, but I can't see an obvious CSS reason for that)

Comment 10

[Daniel Holbert [:dholbert]]

I can confirm that "better fix" seems to fix it for me.

(It's actually slightly more complicated than that -- in my local build (no patch applied), it says "You are currently on the *default* update channel" since I haven't set the channel mozconfig option. Since "default" is slightly wider than "nightly", it pushes "channel" down to the next line and ends up looking like attachment 611940 [details] (with "channel" wrapped, which makes the dialog's contents taller, which prevents there from being a gray bar).  However, if I resize the window to be slightly wider so that the word 'channel' doesn't wrap, then I get the gray strip. That's all with current mozilla-central.

_BUT_, if I apply "better fix" and repeat all of that, I end up with a black bar at the bottom instead of gray. And if I manually increase the height of the dialog, it pads with black, too.  As long as that color is configurable per-channel (which I'm guessing, given that it's not hardcoded into "better fix"), then this patch seems to fix it for me.)

Comment 11

[Alex Keybl [:akeybl]]

Dao - how do you feel about Ian's fix? Should we get this reviewed and landed?

Comment 12

[Dão Gottwald [:dao]]

This isn't going to affect beta and release channel builds, so we don't need to track this.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

[Triage Comment]
Removing tracking as per comment 12

Comment 15

[Liviu Cirdei]

I don't see any gray strip on latest Nightly (50.0a1) so I will close this. If anyone can still reproduce, feel free to reopen the bug.

Comment 16

[Daniel Holbert [:dholbert]]

Yup, I haven't run into this for quite a while. Verified that this looks OK in Nightly 50, too. Thanks!