74244 - Shortcut for History (Command-H) collides with Hide (OS-reserved)

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Henri Sivonen (:hsivonen)]

Mac OS X reserves the key combination command-H for hiding the frontmost
application. In Mozilla this key combination is used as a shortcut for History.

Suggested solution: Changing the shortcut for History.

Comment 1

[Jesse Ruderman]

cc mpt and aaronl

Comment 2

[timeless]

wasn't command-m also mentioned somewhere?

Comment 3

[John Bafford]

Cmd-M is used for minimize, however, this is application-specific as to whether 
it's used or not. And Cmd-H can be overridden by specifying another menu item 
with that shortcut.

Comment 4

[Alec Flett]

this is a design issue, not a bug. off to german

Comment 5

[Alec Flett]

my bad, I meant aaronl

Comment 6

[Andrew Thompson]

>Cmd-M is used for minimize, however, this is application-specific as to whether 
>it's used or not.

I tested this for Aaron L. In my experience command-m does currently minimise
Mozilla, so it is an issue we need to solve.

Aaron knows about these issues. Whether he has bugs open on them or not I don't
know.

Comment 7

[Aaron Leventhal]

We'll take this up at the next keyboard UI meeting in early May.

Comment 8

[Matthew T (active 1999-2002)]

Since, in the absence of a private jet, I probably won't be at this meeting, 
I'll just use this bug to suggest a two-pronged approach:

(1) beating Apple's UI designers with a clue-stick until they stop trying to
    steal keyboard shortcuts for infrequently-used windowing features;

(2) supporting Shift+accel+H, in addition to accel+H, for opening the
    History window.

Comment 9

[John Bafford]

mpt: I like that approach. When shall we commence the beating?

Comment 10

[Aaron Leventhal]

I have already beaten at least one of them.

The response was a deafening silence.

Do we have a separate bug filed yet for Cmd+M? We could use Accel+Shift+M for 
that as well, but I'm a little bit nervous about taking that; it would be such a 
useful key for a mail/message related command. If F10 worked to access the menu, 
Mac users could always type F10 F E M, but that's a bit much. Suggestions from 
the mac folks?

Comment 11

[Henri Sivonen (:hsivonen)]

We have now: bug 75898.

Comment 12

[Aaron Leventhal]

=> Mac kbd team

Comment 13

[rubydoo123]

over to Paul, since this is a navigator decision

Comment 14

[Adam Masri]

From bug 29086, I came across this list of keybindings.

http://www.mozilla.org/projects/ui/accessibility/mozkeyintro.html#xref

Here you will find a discussion about MacOS X's use of Cmd-M & Cmd-H. My $0.02
about this is that when Apple decides they want a keystroke, you're really not
going to change their minds. It's been quite some time since Apple grabbed a
keystroke for their own use across the entire UI, and they don't do it
haphazardly. From what I've read about the Dock thru the various rumor sites, it
sounds like Apple is going to make it better and more tweakable over time, not
disgard it as some in the Mac community might want. If app developers follow
Apple's rules, and these keys really do the same thing across all apps, then
they are truly useful for the entire OS X community.
Therefore, I'd suggest that we change the keybinding for History. From the
keybindings document, it looks like we could grab Cmd-Shift-H for history on OS
X. For parity, I'd suggest changing it on MacOS 9 as well, unless there's a
problem there. Moz is a totally new browser; there's no better time to do this
than now.

- Adam

Comment 15

[Steve Dagley]

[OSX+] now is used to indicate stop ship bugs - this isn't

Comment 16

[timeless]

*** Bug 101400 has been marked as a duplicate of this bug. ***

Comment 17

[Paul Chen]

ui issue, reassigning to german

Comment 18

[Prachi Gauriar]

In order to solve this problem, we could do what Apple did with the Finder. The
key binding to create a new Folder in the Classic Mac OS Finder was Command-N.
However, to make the Mac OS X Finder be more "well-behaved," Command-N now
creates a new window, and Command-Shift-N creates a new folder. 

We could do something analogous for this bug: Make Command-Shift-H open the
History window and leave the OS reserved Command-H as the Hide Mozilla command.
That way, Command-Shift-H still makes a bit of intuitive sense (H for History),
but leaves the reserved keys alone, as the general Mac OS X user would expect.

Comment 19

[Boris Zbarsky [:bzbarsky]]

*** Bug 108372 has been marked as a duplicate of this bug. ***

Comment 20

[Andrew Thompson]

Sounds good to me. 

In later version of X we simply seem to steal the event rather than both effects 
firing (as was the problem on early 10.X releases), but it still needs fixing.

Actually, its a bit weird. If we have open windows, we get the event, if all our 
windows and minimized, the OS sees the event and hides Moz.

Comment 21

[Bill Vinson]

Just wondering if this was still being looked at.  Since the event is stolen, 
sometimes it works for history and sometimes it works for Hiding.  It gets kind 
of annoying as you get used to Cmd-H in all your other apps :)

Shouldn't it get assigned?

Comment 22

[Mike Pinkerton (not reading bugmail)]

well, german left the company, so uh, i guess this should be reassigned. my
recommendation is to keep cmd-h to be "hide" and remap history to something else
(maybe just on mac).

Comment 23

[Bill McGonigle (not currently reading bugmail; please contact directly)]

Please only change cmd-h in the OSX version - the poor OS9 users would get
confused and the people concerned about seamless keystroke migration from NS4
would also get upset.  I was going to say, "only in the carbon version", but the
mach-o version also applies.

Comment 24

[Aaron Leventhal]

Attachment: Tested -- works

Comment 25

[Aaron Leventhal]

Comment on attachment 64321 [details] [diff] [review]
Tested -- works

Sorry, accidentally posted this to the wrong bug.

Comment 26

[Steve Dagley]

*** Bug 108372 has been marked as a duplicate of this bug. ***

Comment 27

[Steve Dagley]

As I commented in #75898 I'm now in the camp that sez we should support the OS X
system defined actions for command-h and command-m.  Switching to
shift-command-H for History on the OS X keybindings sounds like the least
objectionable 'fix'.

Comment 28

[Aaron Leventhal]

Steve, what do you think we should use for opening a mail?

Comment 29

[Steve Dagley]

I'd go with the shift-command-m for new mail

Comment 30

[Aaron Leventhal]

Marking nsbeta1

The solution agreed upon at the macdev meeting:
Command+shift+H should bring up history on OS X
Command+H or Command+shift+H should bring up history on OS 9

Comment 31

[Gilles Durys]

*** Bug 127197 has been marked as a duplicate of this bug. ***

Comment 32

[Chris Casciano]

Since I've oficially made moz my default browser in OSX (in the last few
weeks... before i was running it 60/40 over IE5.1.3) this bug has really gotten
on my nerves. Since the the history window takes a good few seconds to appear
its a very disruptive user error when all i wanted to do was make the app dissapear.


Is there any way, via the keybindings mechanism perhaps, that I can make cmd-h
hide mozilla, or even *do nothing* instead of taking the time to open history?
At least until a real fix is in.

Comment 33

[Bruce Davidson]

*** Bug 133222 has been marked as a duplicate of this bug. ***

Comment 34

[Kathleen :Brade]

Attachment: override keybinding in communicator overlay

Comment 35

[Steve Dagley]

Comment on attachment 77045 [details] [diff] [review]
override keybinding in communicator overlay

r=sdagley

Comment 36

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 77045 [details] [diff] [review]
override keybinding in communicator overlay

sr=[e-mail]

Comment 37

[Kathleen :Brade]

add some keywords

Comment 38

[Paul Baker]

I'm not a big C programmer so I'm not sure what that patch is doing for sure,
but it looks like it is explicitly setting command+H to open the History window
*INSTEAD* of the OS default of Hiding Mozilla. Please don't commit this if this
is the case. We Mac users would rather have command+H hide mozilla and something
else open the history window.

Comment 39

[m_mozilla]

> we mac users would rather have

speak for yourself :)

This mac user likes the way BBEdit works. You get a dialog the first time you do
it which asks you which you would prefer... the behavior that accel-H had before
OS X, or the new OS X behavior. You pick, and it remembers. You can change your
mind in the prefs.

With BBEdit, I don't use accel-H to hide.

With Mozilla, if I had the choice, I wouldn't use accel-H to hide.

-matt

Comment 40

[Jaime Rodriguez, Jr.]

adt1.0.0+ for checkin, pending lorikaplan's approval.

Comment 41

[timeless]

paul: you may not be a c coder, but that hardly matters, the key is in the 
modifiers, for more info please visit http://www.xulplanet.com

Comment 42

[Asa Dotzler [:asa]]

Comment on attachment 77045 [details] [diff] [review]
override keybinding in communicator overlay

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 43

[Kathleen :Brade]

fix checked in

note: this affects ALL Mac OS (not just OSX)

Comment 44

[:deanis74]

Did historyCmd.key need to be redefined?  It's already defined in TasksOverlay.dtd.

Comment 45

[Kathleen :Brade]

yes, it needed to be defined because that file already had a dtd set (and it
didn't contain the history command shortcut key).

Comment 46

[Lori Kaplan]

Approved by UI. Change needed to support OS X usage of cmd-h for OS. 

Comment 47

[Kathleen :Brade]

*** Bug 135888 has been marked as a duplicate of this bug. ***

Comment 48

[sairuh (rarely reading bugmail)]

vrfy fixed using 2002.04.09.08 comm bits on mac 10.1.3.

Comment 49

[sairuh (rarely reading bugmail)]

tested on os 9.1 (emulated), 2002.04.09.08: cmd+H does nothing (expected) and
cmd+shift+H brings up history.

in both os x and os 9, the menu item correctly lists shift+cmd+H for Go > History.

Comment 50

[Boris Zbarsky [:bzbarsky]]

*** Bug 138182 has been marked as a duplicate of this bug. ***