743360 - Make SUMO Advanced search sticky / remember previous form values

Status: RESOLVED FIXED

(support.mozilla.org :: Search, defect)

Description

[Noah (NoahSUMO/SolidSnake) [:Noah]]

Currently the search results fields of Article contains, Post contains & Thread contains (from the Knowledge Base, Support Questions & Discussion forums AS tabs) are cleared and replaced by a default of "crashes youtube" when traveling back to the advanced search page after completing a search.

I'd like to suggest we remove this default value and use the last used search term instead. I have been using the advanced search a lot lately to monitor forum issues and if I make a typo or would like to refine my keyword choice (say from 'safe mode crash' to 'safe mode stuck') I don't have the option to correct it. I'm forced to erase the default text and retype my keywords.

Also I noticed that all other values (ex. Language, Category, Relevant to, Tags, Created before/after, Last updated before/after, etc) I selected were erased after returning from a search. I'd like it if we remembered those too. It especially sucks when I'm trying to do date searching with Created before/after or Last updated before/after and it erases them everytime I return to the AS page.

Advanced search url:
https://support.mozilla.org/en-US/search?a=2

Comment 1

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

This seems similar to this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=746840

Comment 2

[Anush [:anushbmx]]

Kitsune already use a cookie (LAST_SEARCH_COOKIE) to stores the last searched search term. It can be used to replace the default text in Advanced search if last search exist.

Comment 3

[Wayne Mery (:wsmwk)]

(In reply to Anush [:anushbmx] from comment #2)
> Kitsune already use a cookie (LAST_SEARCH_COOKIE) to stores the last
> searched search term. It can be used to replace the default text in Advanced
> search if last search exist.

Having this would be great.

FWIW chrome is currently more helpful because the back history does not clear the fields when you get back to https://support.mozilla.org/en-US/search/advanced

Comment 4

[Anush [:anushbmx]]

Possible solution PR : https://github.com/mozilla/kitsune/pull/2740

Comment 5

[Michael Cooper [:mythmon]]

The PR has been merged. This has been deployed to prod.

Comment 6

[Alice Wyman]

Problem with profile links (user questions and answers)caused by this fix?
See https://support.mozilla.org/en-US/forums/contributors/711689
Quote from jscher2000:
"When I click a user questions link in their profile recently, I often get no results."
"I've just noticed that above the list of suggested articles, in the fail message, is a reference to the last text search I ran in Advanced Search."

Comment 7

[the-edmeister]

This Bug may have fixed a particular fault with the Advanced Search @ SUMO, but it created a Bug for Knowledge Base searches as I explained here.
https://support.mozilla.org/en-US/forums/contributors/711691?last=67535#post-67535

"Form fill" was returning previous entries for Knowledge Base article searches, but now that is overruled by the auto-fill for the exact previous, which then needs to be triple-clicked to "highlight all" before trying to enter a letter to "call up" "Form fill" entries from the past.

IMO, each of those types of searches KB / Postings / Threads should have a different state for the "contains" field. For the KB I think it should be empty as it was before this Bug was fixed.

Comment 8

[Wayne Mery (:wsmwk)]

hmm.  I agree the KB search should be separate.

If it helps users of kb search I'm OK backing this out.  Because remembering the text for support questions is at most only 1/3 of the fields typically used in my searches (product, date, etc)

Comment 9

[Alice Wyman]

A bigger reason I think that this fix should be backed out is because of the problem I mentioned in comment 6 (problem with user profile links to questions and answers after a search is made). A workaround, as jscher2000 mentioned in https://support.mozilla.org/en-US/forums/contributors/711689#post-67518 is to add &q= at the end of the user link query to clear the previous text query.

Comment 10

[Safwan Rahman (:safwan)]

(In reply to Alice Wyman from comment #9)
> A bigger reason I think that this fix should be backed out is because of the
> problem I mentioned in comment 6 (problem with user profile links to
> questions and answers after a search is made). A workaround, as jscher2000
> mentioned in
> https://support.mozilla.org/en-US/forums/contributors/711689#post-67518 is
> to add &q= at the end of the user link query to clear the previous text
> query.

I have rewrite the patch and a PR has been made. Which will fix the issue when it goes into production. So no need to backed out the patch! :)

1. https://github.com/mozilla/kitsune/pull/2747

Comment 11

[Alice Wyman]

(In reply to Safwan Rahman from comment #10)

> I have rewrite the patch and a PR has been made. Which will fix the issue
> when it goes into production. So no need to backed out the patch! :)
> 
> 1. https://github.com/mozilla/kitsune/pull/2747

Based on the above I've reopened this bug.

Comment 12

[Michael Cooper [:mythmon]]

Safwan's PR has been merged and deployed.

Comment 13

[Alice Wyman]

The problems reported in these contributor forum threads still haven't been fixed:

https://support.mozilla.org/en-US/forums/contributors/711689 Problem with profile links (user questions and answers)
https://support.mozilla.org/en-US/forums/contributors/711691 Another issue with the Advanced Search feature that just started ...

Does a new bug report need to be filed?

Comment 14

[Safwan Rahman (:safwan)]

(In reply to Alice Wyman from comment #13)
> The problems reported in these contributor forum threads still haven't been
> fixed:
> 
> https://support.mozilla.org/en-US/forums/contributors/711689 Problem with
> profile links (user questions and answers)
> https://support.mozilla.org/en-US/forums/contributors/711691 Another issue
> with the Advanced Search feature that just started ...
> 
> Does a new bug report need to be filed?

I can not understand what is causing the Error! I will take deep look into it to find out whats happening there. Its really unfortunate that the search is acting like this. Really bit frustrated! Mythmon may have more input about this

Comment 15

[Alice Wyman]

IMHO, rather than spend more developer time on yet another fix for something that really wasn't broken in the first place, I think the fixes for this bug should just be backed out.

Comment 16

[Alice Wyman]

 (In reply to Safwan Rahman from comment #14)
> (In reply to Alice Wyman from comment #13)
> > The problems reported in these contributor forum threads still haven't been
> > fixed:
> > 
> > https://support.mozilla.org/en-US/forums/contributors/711689 Problem with
> > profile links (user questions and answers)
> > https://support.mozilla.org/en-US/forums/contributors/711691 Another issue
> > with the Advanced Search feature that just started ...
> > 
> > Does a new bug report need to be filed?
> 
> I can not understand what is causing the Error! I will take deep look into
> it to find out whats happening there. Its really unfortunate that the search
> is acting like this. Really bit frustrated! Mythmon may have more input
> about this

The reported problems appear to be fixed now.