74355 - Set tooltip to bug title for full-url buglinks

Status: RESOLVED FIXED

(Bugzilla :: User Interface, enhancement, P3)

Description

[Jesse Ruderman]

All of these should get tooltips, but the last one doesn't:

bug 31322

bug 
#31322

http://bugzilla.mozilla.org/show_bug.cgi?id=31322

Comment 1

[Jesse Ruderman]

And I guess it might make sense to cross the last one out, too.

Comment 2

[Dave Miller [:justdave]]

hmm, that'd be interesting to do.  Bugzilla doesn't even know that's a bug link.  
All it knows is it's a URL so it hyperlinks it.

I suppose it could check if the beginning of the URL is 
"%urlbase%/show_bug.cgi?id="

Comment 3

[Andreas Franke (gone)]

-> Bugzilla product, User Interface component, reassigning.

Comment 4

[Jacob Steenhagen]

*** Bug 108411 has been marked as a duplicate of this bug. ***

Comment 5

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 6

[Bradley Baetz (:bbaetz)]

*** Bug 114585 has been marked as a duplicate of this bug. ***

Comment 7

[Dave Miller [:justdave]]

*** Bug 120515 has been marked as a duplicate of this bug. ***

Comment 8

[Bradley Baetz (:bbaetz)]

*** Bug 161858 has been marked as a duplicate of this bug. ***

Comment 9

[Dave Miller [:justdave]]

The User Interface component now belongs to Gerv.  Reassigning all UNCONFIRMED
and NEW (but not ASSIGNED) bugs currently owned by Myk (the previous component
owner) to Gerv.

Comment 10

[Dave Miller [:justdave]]

Reassigning back to Myk.  That stuff about Gerv taking over the User Interface
component turned out to be short-lived.  Please pardon our confusion, and I'm
very sorry about the spam.

Comment 11

[Dave Miller [:justdave]]

*** Bug 217879 has been marked as a duplicate of this bug. ***

Comment 12

[Dave Miller [:justdave]]

Enhancements which don't currently have patches on them which are targetted at
2.18 are being retargetted to 2.20 because we're about to freeze for 2.18. 
Consideration will be taken for moving items back to 2.18 on a case-by-case
basis (but is unlikely for enhancements)

Comment 13

[Dave Miller [:justdave]]

Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004.  Anything flagged
enhancement that hasn't already landed is being pushed out.  If this bug is
otherwise ready to land, we'll handle it on a case-by-case basis, please set the
blocking2.20 flag to '?' if you think it qualifies.

Comment 14

[David D. Kilzer (ddk)]

Attachment: Patch v1.0

Updated quoteUrls() in globals.pl to process bug link URLs before other URLs.

Handles both 'urlbase' and 'sslbase' (if set).

Comment 15

[Max Kanat-Alexander]

No enhancement can block, at this point in the dev. process.

Comment 16

[Max Kanat-Alexander]

Comment on attachment 208618 [details] [diff] [review]
Patch v1.0

Unfortunately my regex-foo is not strong enough to be able to review changes to this particular function. :-) This looks basically correct, and I think it's a good idea.

However, do note that we just moved these functions into Bugzilla::Template, in bug 284875.

Comment 17

[David D. Kilzer (ddk)]

Attachment: Patch v2.0

Changes from Patch v1.0:

- Updated bit rot after Bug 284875 was applied:
  - Fixed contributor portion of the patch.
  - Applied to Bugzilla/Template.pm instead of globals.pl.
  - Changed GetBugLink() method to get_bug_link().
- Tested locally with Bugzilla 2.23.

Comment 18

[Vlad Dascalu]

Comment on attachment 213248 [details] [diff] [review]
Patch v2.0

I kinda stared at the thing for half an hour, wondering if \0 does something special, until I read the comments in that file:

    # We use /g for speed, but uris can have other things inside them
    # (http://foo/bug#3 for example). Filtering that out filters valid
    # bug refs out, so we have to do replacements.
    # mailto can't contain space or #, so we don't have to bother for that
    # Do this by escaping \0 to \1\0, and replacing matches with \0\0$count\0\0
    # \0 is used because its unliklely to occur in the text, so the cost of
    # doing this should be very small
    # Also, \0 won't appear in the value_quote'd bug title, so we don't have
    # to worry about bogus substitutions from there

Kind of clicked then :) Nice! Tested successfully on the tip.

Comment 19

[David D. Kilzer (ddk)]

Comment on attachment 213248 [details] [diff] [review]
Patch v2.0

I just realized that this line of code is completely unnecessary because nothing is done with the $tmp variable:

>+              ~($tmp = html_quote($1)) &&

It should be removed and the next line down should get the tilde:

>+              ~($things[$count++] = get_bug_link($3, $1)) &&

I'll fix this tonight (unless you're okay with fixing it on checkin).

Comment 20

[David D. Kilzer (ddk)]

Attachment: Patch v2.1

Removed unneeded code from Patch v2.0 per Comment #19.

Retested on local Bugzilla 2.23.

Comment 21

[Vlad Dascalu]

Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.44; previous revision: 1.43
done

Comment 22

[Max Kanat-Alexander]

Added to relnotes in bug 349423. Please let me know if I missed any critical information about this bug in the release notes.