744648 - Update icon uploader to match required assets for new design

Status: RESOLVED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P3)

Description

[Justin Scott [:fligtar]]

These are the asset sizes needed for apps in the marketplace: http://people.mozilla.org/~smartell/marketplace/style/#apps

There are 3 main items:
* app icon - should be uploaded at 64px and scaled down to other sizes
* store tile - 120px used in browse pages. this is optional, and if it's not uploaded, we'll center the app icon on a cool background (sean is working on this)
* large promo - this should be in the admin section of the app and can only be uploaded/modified by admins. this is used for apps featured on landing pages.

Comment 1

[Andy McKay]

I suspect we'll need to be able to in the future localise these icons, promo's especially. That's probably out of of scope for now but something we'll need to do in a couple of months, so lets not make it to hard to do later.

Comment 2

[Davor Spasovski [:spasovski]]

mine mine mine!

Comment 3

[Justin Scott [:fligtar]]

On the platform side, 512px is the largest supported on Mac and 256 on Windows. So... let's say they can upload an icon at 256 and we'll scale it down to what we need?

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/d2e6ce5

Admins can now upload promo graphics for apps:
https://marketplace-dev.allizom.org/en-US/developers/app/in-app-payment-tester/edit

I'm keeping this bug open to support the "store tile" graphics (which will supplement the app icons). I'll resume work on that after I push a few ratings bugs.

Comment 5

[Christopher Van Wiemeersch [:cvan]]

Had this in a branch, resuming work on this this week.

Comment 6

[Wil Clouser [:clouserw]]

What is left to do on this bug?

Comment 7

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #6)
> What is left to do on this bug?

* store tile - 120px used in browse pages. this is optional, and if it's not uploaded, we'll center the app icon on a cool background (sean is working on this)

Comment 8

[Matt Basta [:basta]]

Merged in validator:

https://github.com/mozilla/amo-validator/commit/d5fffcaad7902d4bdab77fbefa6453528f323eff

Comment 9

[Christopher Van Wiemeersch [:cvan]]

(In reply to Matt Basta from comment #8)
> Merged in validator:
> 
> https://github.com/mozilla/amo-validator/commit/
> d5fffcaad7902d4bdab77fbefa6453528f323eff

I think you meant to put this in https://bugzilla.mozilla.org/show_bug.cgi?id=760343

Comment 10

[Matt Basta [:basta]]

It's applicable to both

Comment 11

[Matt Basta [:basta]]

Merged:

https://github.com/mozilla/zamboni/commit/96e1535cddcc72f803eb37a8383fd779b0d4241b

Comment 12

[Matt Basta [:basta]]

Nevermind, cvan has more to do for this

Comment 13

[Wil Clouser [:clouserw]]

(In reply to Matt Basta [:basta] from comment #12)
> Nevermind, cvan has more to do for this

What else is there to do?

Comment 14

[Christopher Van Wiemeersch [:cvan]]

(In reply to Wil Clouser [:clouserw] from comment #13)
> (In reply to Matt Basta [:basta] from comment #12)
> > Nevermind, cvan has more to do for this
> 
> What else is there to do?

(In reply to Wil Clouser [:clouserw] from comment #6)
> What is left to do on this bug?

* store tile - 120px used in browse pages. this is optional, and if it's not uploaded, we'll center the app icon on a cool background (sean is working on this)

^ That part was never done.

Comment 15

[Christopher Van Wiemeersch [:cvan]]

Bump!

Comment 16

[krupa raj[:krupa]]

While we're waiting for promo images, we should centre the icons on a white background.

Comment 17

[Matt Basta [:basta]]

Fixed:

https://github.com/mozilla/zamboni/commit/5985e0074c4c8b47f360beecfa7b307e1c9a3401

Comment 18

[Matt Basta [:basta]]

Sorry, wrong bug. :(

Comment 19

[Wil Clouser [:clouserw]]

Under review, will land early this milestone

Comment 20

[Matt Basta [:basta]]

This landed today, mostly here: https://github.com/mozilla/zamboni/commit/bc098c83ca23caa922d8acc7fc7dbe9ddecc559b