745081 - Allow access to individual filter properties to support customizable item filters

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Matthew Mecca [:mmecca]]

We currently support a limited number of predefined item filters that filter items based on date range, status, and due date collectively. Exposing the filter properties individually would allow users to create custom views that could combine those property filters in a customized way.

This will allow customizable filtering toolbar controls to be used in the calendar filter bars in Bug 728011.

Additionally this can allow the currently applied filter properties to be exposed to other areas like the print dialog.

Comment 1

[Matthew Mecca [:mmecca]]

Attachment: Fix v1

This patch creates a new calFilterProperties object that contains a set of filter properties, and allows the calFilter object to define sets of filter properties by a filter name. The filter properties can then be applied by either the calFilterProperties object or the defined filter name. 

The previously available filters for the unifinder and task trees are made available as predefined filter properties.

Comment 2

[Matthew Mecca [:mmecca]]

I considered moving the calFilter.js code to modules/calFilter.jsm - what are your thoughts on this?

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 614682 [details] [diff] [review]
Fix v1

Review of attachment 614682 [details] [diff] [review]:
-----------------------------------------------------------------

Great work, this looks really promising!

::: calendar/base/src/calFilter.js
@@ +147,5 @@
> +            return (this[prop] == aFilterProps[prop]);
> +        }, this);
> +    },
> +
> +    LOG: function cFP_LOG() {

Maybe expand this by an argument aString, that might ease debugging in the future.

@@ +148,5 @@
> +        }, this);
> +    },
> +
> +    LOG: function cFP_LOG() {
> +        cal.LOG("calFilterProperties" + 

We often use [calFilterProperties] as a scheme

@@ +714,5 @@
> +
> +        let oneDay = cal.createDuration();
> +        oneDay.days = 1;
> +        this.mTomorrow = this.mToday.clone();
> +        this.mTomorrow.addDuration(oneDay);

What about:

this.mTomorrow = this.mToday.clone();
this.mTomorrow.day++;

?

Comment 4

[Matthew Mecca [:mmecca]]

Attachment: Fix v2

Fixes a few issues with v1:

- Adapts the today pane's Show completed Tasks checkbox.
- Fixes an issue with filters based on the current-view date range inadvertently modifying the view's end date.
- Adds a clone method to calFilterProperties to avoid inadvertently modifying the defined filter properties.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 617177 [details] [diff] [review]
Fix v2

Looks good, r=philipp

Comment 6

[Matthew Mecca [:mmecca]]

Pushed to comm-central - http://hg.mozilla.org/comm-central/rev/02bb6cc0fe6e

Comment 7

[berggeist01]

Hi, the bug is not fixed in Firefox 17.0.8 - Ligh 1.9.1 the problem is:

all my tasks have only a final date and no start date. It is not possible to print tasks which must be finished on a special date. I think the problem is, that you include all no set start date task in the selected time frame. The following implementation will be correct.

for one Task to print must be checked:

is set a start date? ->
YES: is the date in the selected time frame? YES: -> put it in the basket (to print)
NO: do nothing

is set a final date? ->
YES: is the date in the selected time frame? YES: -> is the item not in the basket? -> NO: put it in the basket (to print)
NO: do nothing

done.

Do you know what i mean?

It will be great if you can correct that or explain, what I understand wrong (that functionality) and we find a other/better solution.

Thanks
Peter

Comment 8

[berggeist01]

in Lightning 2.6 and Thunderbird 24 exist the problem only in the List layout in the month and week layout the problem seems be fixed

Comment 9

[Martin Schröder [:mschroeder]]

Peter, can you please file a new bug on the remaining issue? This way the developers can better track the remaining problems and work to be done. Thank you!