Update the Downloads command to open the Downloads view instead of the Downloads Panel

VERIFIED FIXED in Firefox 17

Status

()

Firefox
Downloads Panel
VERIFIED FIXED
5 years ago
4 years ago

People

(Reporter: smaug, Assigned: Paolo)

Tracking

unspecified
Firefox 17
x86_64
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
The downloads button is hidden after browser startup, and one needs to first click
tools->downloads to get the button visible temporarily and then click "Show all downloads"
in the doorhanger. The doorhanger is faraway from the menu.
This is not a good UI.
(Assignee)

Comment 1

5 years ago
Created attachment 630685 [details] [diff] [review]
Update the Downloads command to open the Downloads view instead of the Downloads Panel.

For new downloads, this shows the Downloads window (that in the future will be
the Downloads view in the library) according to Downloads window preferences,
but only if the Downloads indicator is currently invisible for any reason
(that should avoid getting no download notifications at all).

The menu command always shows the Downloads window.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Attachment #630685 - Flags: review?(mak77)
(Assignee)

Updated

5 years ago
Blocks: 766013

Updated

5 years ago
Depends on: 746591

Comment 2

5 years ago
I had this problem with Nightly running on updated 64-bit Ubuntu versions, but everything is fine now ; the Download Manager icon displays as soon as I launch Nightly (currently 16.0a1 (2012-06-18)....

Henri
Comment on attachment 630685 [details] [diff] [review]
Update the Downloads command to open the Downloads view instead of the Downloads Panel.

Review of attachment 630685 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/downloads/content/indicator.js
@@ +182,5 @@
> +  get isVisible()
> +  {
> +    if (!this._placeholder)
> +    {
> +      return false;

warning: c# braces detected!

::: browser/components/preferences/main.js
@@ -39,5 @@
> -    // These radio-buttons should not be visible if we have enabled the Downloads Panel.
> -    let shouldHide = !DownloadsCommon.useToolkitUI;
> -    showWhenDownloading.hidden = shouldHide;
> -    closeWhenDone.hidden = shouldHide;
> -  },

Is the preferences changes removal something we'll have to undo when moving to the new view? If so I'm not sure if we want to add them back now just to remove them again soon...
But it's easy code, so I don't have strong feelings.
Attachment #630685 - Flags: review?(mak77) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 646867 [details] [diff] [review]
Update the Downloads command to open the Downloads view instead of the Downloads Panel.

(In reply to Marco Bonardo [:mak] (Away 28 Jul - 12 Aug) from comment #3)
> warning: c# braces detected!

:-) Fixed!

> Is the preferences changes removal something we'll have to undo when moving
> to the new view? If so I'm not sure if we want to add them back now just to
> remove them again soon...
> But it's easy code, so I don't have strong feelings.

I think we should show the preferences to allow controlling the Downloads
window, while it'a accessible in the meantime.
Attachment #630685 - Attachment is obsolete: true
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d3e80ee5ec1
Target Milestone: --- → Firefox 17
(Assignee)

Updated

5 years ago
Summary: Showing all the downloads is difficult after startup → Update the Downloads command to open the Downloads view instead of the Downloads Panel
https://hg.mozilla.org/mozilla-central/rev/3d3e80ee5ec1
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Depends on: 785757
Depends on: 809022
Verified on the latest Nightly that the the menu command and the keyboard shortcuts always show the Downloads window and not the Downloads panel.

Verified on Windows 7, Ubuntu 12.04 and Mac OS X 10.7:

Mozilla/5.0 (Windows NT 6.1; rv:19.0) Gecko/19.0 Firefox/19.0        
Build ID: 20121111030749
Mozilla/5.0 (X11; Linux i686; rv:19.0) Gecko/19.0 Firefox/19.0        
Build ID: 20121112030753
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:19.0) Gecko/19.0 Firefox/19.0        Build ID: 20121112030753
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.