751128 - "Add to Firefox" button is not disabled for incompatible unreviewed add-ons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Cristian Boldan]

Steps to reproduce:
1. Load AMO homepage and submit an add-on with maxVersion smaller than the used Firefox version and an add-on with minVersion bigger than the used Firefox version (ex. if FF12 is used, and add-on with maxVersion < 12 and another add-on with minVersion > 12) or load the add-on details page for these add-ons:
https://addons-dev.allizom.org/en-US/firefox/addon/xmax-version-12/
https://addons-dev.allizom.org/en-US/firefox/addon/xmin-version-12/

Expected results:
"Add to Firefox" button is disabled and there is text displayed under it "Not available for Firefox 12" 

Actual results:
"Add to Firefox" buttons are not disabled and user is able to download the add-on with no issues.

Notes/Issues:
Verified in FF12 (Win 7).
Uploading the add-ons used.

Comment 1

[Cristian Boldan]

Attachment: max version < 12

Comment 2

[Cristian Boldan]

Attachment: min version > 12

Comment 3

[Victor Carciu]

Reproducible also for reviewed addons with maxVersion < FF version in use. 
For example "Video Download Helper" should not be compatible with Nightly or Release firefox versions: https://addons-dev.allizom.org/en-US/firefox/addon/video-downloadhelper/?src=search

Comment 4

[Christopher Van Wiemeersch [:cvan]]

This seems like it should be fixed

Comment 6

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/c5a22b8

Comment 7

[Christopher Van Wiemeersch [:cvan]]

Properly fixing

Comment 8

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/4eafe53

Comment 9

[Cristian Boldan]

Issue is still reproducing in 
https://addons-dev.allizom.org/en-US/firefox/addon/xmax-version-12/ and
https://addons-dev.allizom.org/en-US/firefox/addon/xmin-version-12/
for unreviewed add-ons in FF12 and
https://addons.mozilla.org/en-US/firefox/addon/video-downloadhelper/ for fully reviewed add-on with maxVersion = 13.* in rdf in FF15 (Nightly)

Comment 10

[Christopher Van Wiemeersch [:cvan]]

(In reply to Cristian Boldan from comment #9)
> Issue is still reproducing in 
> https://addons-dev.allizom.org/en-US/firefox/addon/xmax-version-12/ and
> https://addons-dev.allizom.org/en-US/firefox/addon/xmin-version-12/
> for unreviewed add-ons in FF12 and
> https://addons.mozilla.org/en-US/firefox/addon/video-downloadhelper/ for
> fully reviewed add-on with maxVersion = 13.* in rdf in FF15 (Nightly)

Per this bug, the "Add to Firefox" button is disabled for incompatible+unreviewed add-ons. The issue you're describing where the minVersion < user's version but the app install is not disabled ... that's bug 751980.

Comment 11

[Cristian Boldan]

Fixed due to D2C changes.
Closing bug.