75596 - new server dialog mis-sized (too short)

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

BUILD: linux 2001-04-11 CVS with PSM2

DISPLAY: 1280x1024 19" monitor, 75dpi, 75DPI fonts.

STEPS TO REPRODUCE:
1)  Go to https://www.rsiaa.org/rsiauth/cgi-bin/home.pl

EXPECTED RESULTS:
The dialog is sized correctly.

ACTUAL RESULTS:
The dialog is too short -- one cannot see the third radio button and the
OK/Cancel buttons.  Combined with bug 75595, this makes the dialog unusable.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Screenshot

Comment 2

[Boris Zbarsky [:bzbarsky]]

OK, upon some investigation, there are actually two separate issues here:

1)  The initial window height is specified as 360px.  This is not big enough

2)  If the initial height specification is taken out, the window is sized
correctly for its original content.  However, when the setText() calls in onLoad
happen the height of the content increases.  The window does not size to
accomodate this.

Comment 3

[John Unruh]

Milestone 2.0.

Comment 4

[John Unruh]

*** Bug 75615 has been marked as a duplicate of this bug. ***

Comment 5

[Bob Lord]

Reporter: Is this still a problem?  It looks fixed on my WinME box.

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 76141 has been marked as a duplicate of this bug. ***

Comment 7

[Boris Zbarsky [:bzbarsky]]

I won't be able to test this correctly till Monday (I don't have access to the
one box I have around on which I saw it till then).  I'll report back on
Monday.  Nothing has checked about the dialog XUL or JS.... has there been a
generic dialog-sizing checkin I missed?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Er.... I mean "nothing has changed", not "nothing has checked"

Comment 9

[Boris Zbarsky [:bzbarsky]]

This has gotten worse.  Seeing it with a debug build from 2001-05-05 on my home
computer.  Migrated NS 4.x profile.  Resolution 1152x864, 100dpi.  I've tried
setting mozilla's DPI setting to 0,80, and 96.  All look about the same -- the
font size changes but not enough to compensate for the size of the dialog.

One other note.  The <separator> elements in this dialog are far too tall.

Comment 10

[Ken Snider]

I Dunno - see this attachment. This is under Win2k, 1280x1024 96dpi.

Perhaps this is a non-Windows issue?

Comment 11

[Ken Snider]

Attachment: Screenshot of the Dialog under Win2k

Comment 12

[Ken Snider]

*** Bug 79046 has been marked as a duplicate of this bug. ***

Comment 13

[robbe]

It seems that somebody tried to cut corners and hardcoded the dialog height,
because dynamic sizing did/does not work. Now, this can be just right for Ken,
but it can't possibly work on all installation. For sure it doesn't on mine.

Comment 14

[Boris Zbarsky [:bzbarsky]]

Soo....  simple way to reproduce is to put

* { font-size: 15pt } 

in userChrome.css.  I have a friend who's done that to make the fonts readable
(bad vision) and this bites him all the time.

I've tested some more on a variety of systems and I have come to the conclusion
that it all depends on the font one is using by default.  The original system I
tested on is identical (same screen/dpi/resolution) to a system which
worksforme, so it must be a matter of fonts.  I can certainly attach some
screenshots as I retest this on a variety of setups...

The point is that the dialog is not doing sizing correctly so it's a problem for
some font setups.

Comment 15

[Boris Zbarsky [:bzbarsky]]

Attachment: screenshot: fresh profile Linux mozilla displayed on a Sun box, SunOS 5.7, 1152x900, 90dpi

Comment 16

[Boris Zbarsky [:bzbarsky]]

Tried another Linux box (debian 2.2 default install, 1280x1024, 75dpi, Mozilla
set to 96 dpi).  Looks identical to attachment 30452 [details]

Comment 17

[Ken Snider]

This definately seems to be affecting Unix/Linux boxen more than windows
systems. However if the problem really is as Boris suggests, then It's safe to
assume that it can be exhibited on ANY os, given the right fontset or dpi settings.

Comment 18

[John Unruh]

*** Bug 79454 has been marked as a duplicate of this bug. ***

Comment 19

[John Unruh]

*** This bug has been marked as a duplicate of 75610 ***

Comment 20

[Boris Zbarsky [:bzbarsky]]

reopening...  Why exactly is this a dup of bug 75610??

This is about the dialog not being sized properly to start with.  75610 is about
the dialog not drawing parts that used to be obscured when it is resized.

75610 applies to all modal dialogs.  This one is only a problem with this
particular dialog that happends to be doing some weird things with dynamic text
insertion and setting a fixed height.

Comment 21

[Boris Zbarsky [:bzbarsky]]

*** Bug 79647 has been marked as a duplicate of this bug. ***

Comment 22

[Boris Zbarsky [:bzbarsky]]

*** Bug 80903 has been marked as a duplicate of this bug. ***

Comment 23

[Boris Zbarsky [:bzbarsky]]

*** Bug 80914 has been marked as a duplicate of this bug. ***

Comment 24

[Ken Snider]

*** Bug 79843 has been marked as a duplicate of this bug. ***

Comment 25

[Bob Lord]

*** Bug 75615 has been marked as a duplicate of this bug. ***

Comment 26

[Bob Lord]

*** Bug 76628 has been marked as a duplicate of this bug. ***

Comment 27

[David P. Drinan]

Assigning to javi.

Comment 28

[Boris Zbarsky [:bzbarsky]]

*** Bug 85985 has been marked as a duplicate of this bug. ***

Comment 29

[John Unruh]

*** Bug 86024 has been marked as a duplicate of this bug. ***

Comment 30

[Jacek Piskozub]

Adding mostfreq at 10 dups.

Comment 31

[David Einstein]

*** Bug 86211 has been marked as a duplicate of this bug. ***

Comment 32

[John Unruh]

*** Bug 86111 has been marked as a duplicate of this bug. ***

Comment 33

[Tom Mraz]

*** Bug 86580 has been marked as a duplicate of this bug. ***

Comment 34

[Javier Delgadillo]

Attachment: Dialog if height/width are removed

Comment 35

[Javier Delgadillo]

There is a xul rendering bug at play here.  If I remove the width/height
attributes from the xul source, the dialog should automagically size itself. 
But I'm not seeing that at all.  :(

It looks like we'll have to leave in hard-coded width and height for now and
just add key press events to the dialog.

Comment 36

[Boris Zbarsky [:bzbarsky]]

Please see item 2 of my comment from 2001-04-11 13:24.

Perhaps a call to sizeToContent() would be in order here?  I tried that at some
point and it did not help, but maybe I just put it in the wrong place...
sizeToContent() is also somewhat buggy on Linux, so testing that on a Windows
system where this bug happens would be nice.

At the very least, I would recommend making the default height 400px.  This
should still be fine on 640x480 screens and will help things a lot...

Comment 37

[Stephane Saux]

-> P1

Comment 38

[Tom Mraz]

*** Bug 86836 has been marked as a duplicate of this bug. ***

Comment 39

[Stephane Saux]

PDT for PSM

Comment 40

[John Unruh]

*** Bug 86907 has been marked as a duplicate of this bug. ***

Comment 41

[Stephane Saux]

PDT+ as per Steve Elmeer 6/20/2001

Comment 42

[Javier Delgadillo]

Attachment: Patch to increase height by 20 pixels and enable key events for dialog.

Comment 43

[Javier Delgadillo]

ddrinan: Please review.

Comment 44

[David P. Drinan]

r=ddrinan

Comment 45

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 46

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.2 closed tree.
(on behalf of drivers)

Comment 47

[Stephane Saux]

*** Bug 86292 has been marked as a duplicate of this bug. ***

Comment 48

[Javier Delgadillo]

patch checked in.

Comment 49

[Javier Delgadillo]

marking fixed for real this time.

Comment 50

[John Unruh]

Reopening. This patch also needs to be applied to Expired Cert and Cert Name 
non-match dialog boxes.

Comment 51

[Javier Delgadillo]

Attachment: applying patch to other 2 dialogs.

Comment 52

[Ian McGreer]

r=mcgreer

Comment 53

[Stephane Saux]

see related bug 87203.

Comment 54

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 55

[Stephen Walker]

*** Bug 87427 has been marked as a duplicate of this bug. ***

Comment 56

[chris hofmann]

a=chofmann 092 branch and trunk

Comment 57

[Javier Delgadillo]

Patch checked into trunk and branch.

Comment 58

[Boris Zbarsky [:bzbarsky]]

*** Bug 84796 has been marked as a duplicate of this bug. ***

Comment 59

[Javier Delgadillo]

Re-opening due to Buig 87451 (typo in patch)

Comment 60

[Javier Delgadillo]

checked in fix for typo.

Comment 61

[John Unruh]

Verified.

Comment 62

[Boris Zbarsky [:bzbarsky]]

*** Bug 89521 has been marked as a duplicate of this bug. ***

Comment 63

[Lapo Luchini]

I still have the problem using Win32 2001070604 build.
(installed from scratch, of course)

Comment 64

[John Unruh]

*** Bug 87203 has been marked as a duplicate of this bug. ***

Comment 65

[Boris Zbarsky [:bzbarsky]]

*** Bug 94391 has been marked as a duplicate of this bug. ***

Comment 66

[Olaf]

Hey, I suggest to make that dialog user resizable. I would be fine with that and
could close 94956 that I entered and that quickly was marked as duplicate of
this one. 

BTW, I use Win98SE german with "Große Schriftarten" (could mean "big fonts" in
English in Win9x's screen properties dialog) @ 1152x864x32
Build is 0.9.3/2001080110

Comment 67

[Boris Zbarsky [:bzbarsky]]

*** Bug 114214 has been marked as a duplicate of this bug. ***