Closed Bug 764243 (SQLite3.7.13) Opened 8 years ago Closed 8 years ago

Upgrade to SQLite 3.7.13

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: RyanVM, Assigned: RyanVM)

References

()

Details

Attachments

(2 files)

Not sure if it really brings us anything (mak?), but why not?
https://tbpl.mozilla.org/?tree=Try&rev=fc7f79c8bd9b
Attachment #632507 - Flags: review?(mak77)
Assignee: nobody → ryanvm
Status: NEW → ASSIGNED
Attachment #632508 - Flags: review?(mak77)
This is a very important release for IndexedDB. In particular:

 - Avoid resetting the schema of shared cache connections when any one connection closes. Instead, wait for the last connection to close before reseting the schema.
 - Add interfaces sqlite3_quota_ferror() and sqlite3_quota_file_available() to the test_quota.c module.
Thanks Ben, I was unsure if those changes were affecting indexedDB, good to know they actually improve it.
Also, with this version upgrade, we can (and should) remove the MAX_SCHEMA_RETRY config option from the makefile at http://mxr.mozilla.org/mozilla-central/source/db/sqlite3/src/Makefile.in#90 since we should no longer hit this case.
Depends on: SQLite3.7.12.1
Alias: SQLite3.7.13
(In reply to ben turner [:bent] from comment #4)
> Also, with this version upgrade, we can (and should) remove the
> MAX_SCHEMA_RETRY config option from the makefile at
> http://mxr.mozilla.org/mozilla-central/source/db/sqlite3/src/Makefile.in#90
> since we should no longer hit this case.

The description in the changelog is a bit cryptic, it only says the schema is not reset on closing a connection, though there are many more cases where the schema gets reset, that are not there (just to nominate a few, PRAGMA foreign_key, sqlite3_create_function and sqlite3_create_collation). So just creating connections had similar issues to closing them iirc.
Do we have evidence this is no more the case?
Attachment #632508 - Flags: review?(mak77) → review+
Comment on attachment 632507 [details] [diff] [review]
Upgrade to SQLite 3.7.13 - SQLite changes

Review of attachment 632507 [details] [diff] [review]:
-----------------------------------------------------------------

We can handle the MAX_SCHEMA_RETRY thing in a bug apart, since by itself won't hurt, though should be clarified regardless, so please file it as a dependency.
Attachment #632507 - Flags: review?(mak77) → review+
https://hg.mozilla.org/mozilla-central/rev/d86438b941f9
https://hg.mozilla.org/mozilla-central/rev/47be099e523c
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
(In reply to Marco Bonardo [:mak] from comment #5)
> The description in the changelog is a bit cryptic, it only says the schema
> is not reset on closing a connection

I think that is the only relevant change that was made, correct.

> Do we have evidence this is no more the case?

Try seemed very happy with it, even with the indexedDB tests that hit this problem in the past.

I'll file a followup.
(In reply to ben turner [:bent] from comment #8)
> Try seemed very happy with it, even with the indexedDB tests that hit this
> problem in the past.

Well, if it wasn't for this:
http://mxr.mozilla.org/mozilla-central/source/dom/indexedDB/test/Makefile.in#105

We basically introduced the retry to reduce the hit ratio of that failure, and by figuring out 6 retries are quite a few in high-load cases, then the test got disabled, so hard to tell, this change may have improved things, or not.
Blocks: SQLite3.7.14
You need to log in before you can comment on or make changes to this bug.