764939 - [calendar] Switch win32 build slaves to Visual C++ 2010

Status: RESOLVED FIXED

(Calendar :: Build Config, defect)

Description

[Stefan Sitter [:ssitter]]

Now that Visual C++ 2010 is available on the win32 build slaves (Bug 757500) we should switch the build to actually use it. Any ideas what needs to be done for this? Maybe a patch similar to the one in Thunderbird Bug 751592?

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, something like that should be the right step. I'll make sure to reconfigure buildbot this afternoon.

Comment 2

[Stefan Sitter [:ssitter]]

The switch to vc10 was done for Thunderbird 15, therefore we need to switch both comm-aurora and comm-central builders. Maybe we can store the config files inside the source tree like done for Thunderbird, i.e. the builders correctly setup itself during the merge days?

Comment 3

[Mark Banner (:standard8)]

(In reply to Philipp Kewisch [:Fallen] from comment #1)
> Yes, something like that should be the right step. I'll make sure to
> reconfigure buildbot this afternoon.

No need to reconfig buildbot for this, just check in the changes to the mozconfigs here:

http://hg.mozilla.org/build/buildbot-configs/file/d62b0ac0b092/calendar/win32

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

build/buildbot-configs changeset b6a2f979f8c8

Comment 5

[Stefan Sitter [:ssitter]]

We just need to remember to repeat the change for comm-beta and comm-release once Lightning 1.7 is merged to that branch.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Agreed. I'm not sure yet how we could get the mozconfigs into the tree. There surely will be code that loads the in-tree mozconfigs and we'd have to tell it to also load the calendar mozconfigs if --enable-calendar is passed. Since thats a mozconfig option itself, we'd need some other way to determine when to build calendar (environment var?). Maybe a new bug would be good for that.