768797 - Access key for "Don't save" button not working anymore in composition's "Save Message?" confirmation prompt on MAC

Status: NEW

(Thunderbird :: Mail Window Front End, defect)

Description

[Ludovic Hirlimann [:Usul]]

STR :

1. Cmd - N to compose a new message
2. close the compose window
3. warning mesage comes up

try to chosse don't save using either ctrl-d or cmd-d nothing happens.

I get this little warning in  the console

Comment 1

[:aceman]

Which warning? Forgot to paste the text?

Comment 2

[Ludovic Hirlimann [:Usul]]

(In reply to :aceman from comment #1)
> Which warning? Forgot to paste the text?

I mean the popup windows asking you if you are sure that you want to save/nosave your draft.

Comment 3

[:aceman]

Also, if you are on Trunk, did you notice that the shortcut for "don't save" changed to "n" in bug 759053? (Who may have done such a thing:-))

The shortcut keys should be shown on the buttons. Aren't they on Mac?

Comment 4

[Ludovic Hirlimann [:Usul]]

(In reply to :aceman from comment #3)
> Also, if you are on Trunk, did you notice that the shortcut for "don't save"
> changed to "n" in bug 759053? (Who may have done such a thing:-))

That works.

> The shortcut keys should be shown on the buttons. Aren't they on Mac?

No they aren't and the convention is to use the first letter in the button what ever the button says.

Comment 5

[:aceman]

OK, so the "regression" is bug 759053.
If you do not agree with the reasoning there and still want to change the key back on Mac, let's CC some of the guys that agreed to the change. And notice it is in Toolkit.

And if the keys really are not shown on Mac, then I'd agree with you. How could anybody figure out the key is "n".

I'll see if the key can be made platform dependent.

Comment 6

[:aceman]

/mozilla/mobile/android/components/PromptService.js (View Hg log or Hg annotations)
    line 228 -- bTitle = PromptUtils.getLocaleString("DontSave");
/mozilla/mobile/xul/components/PromptService.js (View Hg log or Hg annotations)
    line 408 -- bTitle = PromptUtils.getLocaleString("DontSave");
/mozilla/toolkit/components/prompts/src/nsPrompter.js (View Hg log or Hg annotations)
    line 156 -- buttonLabel = PromptUtils.getLocalizedString("DontSave");

It is in JS files, but if they could be made preprocessed, it should be possible to have different keys for each platform.

Comment 7

[Chris Andrichak]

this is a duplicate of bug 265277
https://bugzilla.mozilla.org/show_bug.cgi?id=265277

Comment 8

[:aceman]

It is a dupe by appearance but technically it is not. Bug 265277 was filed long ago and the cmd-D shortcut was implemented since, just not marked in that bug (unknown by which bug, but comment 0 here proves it has worked). But since bug 759053 this regressed again and was changed to Cmd-N.
Not sure how to mark the bugs now.

Comment 9

[Chris Andrichak]

In 17.0.8 and 26.0a1 Daily neither n/cmd-n or d/cmd-d does anything (using OSX 10.7.5). It's definitely a problem, whichever bug best applies...

Comment 10

[Sam Grinter]

Ever since Mac OS Lion the default shortcut for Don't Save has been Command-[delete], and Command-d goes to the desktop if you are choosing a save location. Thunderbird seems to use Command-d in this way; if you are in the Save Message As dialogue box, then Command-d will change the path to the Desktop. Perhaps we should use Command-[delete] as the shortcut for Don't Save in the Mac version?