Closed Bug 76917 Opened 24 years ago Closed 24 years ago

Insert|Link needs an accelerator (accel+L?????)

Categories

(Core :: DOM: Editor, defect)

Product:
Core
Component:
DOM: Editor
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.1

People

(Reporter: nbaca, Assigned: Brade)

References

Details

Build 2001-04-19-04: NT4, Linux Overview: Composer should have an accelerator for the Insert|Link menu item. I found this because Mail's HTML/New message window is also effected. According to the Mail spec the Insert|Link accelerator should be Ctrl+Shift+L but this conflicts with Composer. Using Ctrl+L also has a conflict because it is used by the Mail 3pane to forward a message. a. Ctrl+Shift+L - From browser: opens the "Open Web Location" dialog - From composer: opens the "Open Web Location" dialog - From html/new message compose: does nothing - From 3pane: does nothing b. Ctrl+L - From browser: puts focus in the Browser's Location editfield - From composer: does nothing - From html/new message compose: does nothing - From mail's 3pane: ctrl+l, forwards a message
Keywords: nsbeta1
In reference to the mail spec it is actually called "Mail Compose Menu" (http://mozilla.org/mailnews/specs/compose/Comp_Menus.html).
Giving to brade.
Assignee: beppe → brade
Why is Ctrl+L used to forward a message?
I don't think the conflict with Mail 3pane matters. There's lots of differences between that and other modules, and since "insert link" makes no sense in mail 3pane, why is it a conflict? (I agree with timeless, it isn't a very good mnemonic for "forward message" anyway!) Whatever the current Mail spec says for the accelerator is also not important as long as we resolve all current key conflicts.
I didn't say anything. Ctrl-L is 4xp, probably older.
Status: NEW → ASSIGNED
Keywords: 4xp
OS: Windows NT → All
Summary: Insert|Link needs an accelerator (ctrl+l, ctrl+shift+l...) → Insert|Link needs an accelerator (ctrl+l)
Target Milestone: --- → mozilla0.9.1
accel+L should not be used to forward a message for four reasons: (1) the shortcut for forwarding a message should be consistent with the Navigator shortcut for `Send Page', and Navigator already uses accel+L for Open Location (or to focus the location field); (2) accel+L should be used for focusing the location toolbar in mail/news (once it is implemented), for consistency with Navigator; (3) accel+L should be used for inserting a link in both message composition (as this bug suggests) and Composer, and Composer also has a `Send Page' command; (4) it's inconsistent with the 4xp use of accel+K for forwarding a message. (All this is covered in greater detail in bug 66884.) But since neither message composition nor Composer are ever likely to have a location toolbar of any sort (no, Timeless, really they won't), I don't see the harm in using accel+L for inserting a link in these two areas.
(4) it's inconsistent with the 4xp use of accel+K for forwarding a message. MPT: WHAT??? netscape4.76U windows2000: ctrl-k resulted in compact folder, not forward message. The one thing it did manage to do was forget which of my 109 unread email messages are new.
OK, let's try this again. The change for open web location from accel-L to accel-shift-L broke an existing keybinding in Composer. We have accel-shift-L for Remove Link so now that needs a new keybinding. Suggestions? If not, I'll make it accel-L since more users probably will want that on a keybinding as opposed to inserting a new link. :-/ Possibilities I see include (with accel of course): D, shift-D E, shift-E shift-I J, shift-J R, shift-R T There are others but these seem like the best candidates to me.
Summary: Insert|Link needs an accelerator (ctrl+l) → Insert|Link needs an accelerator (accel+L?????)
Target Milestone: mozilla0.9.1 → mozilla0.9.2
I'm Ok with using accel+L for "remove/discontinue link" instead of insert link. Maybe we can live without an accelerator for the latter. But we're getting a domino effect here. If we change to that, we should also change the keybinding for "remove/discontinue text styles", which is currently accel+shift+K. I vote for using accel+R or accel+T for that one. I.e., we should use the same pattern: just "accel" or "accel+shift" for both the "remove" keybindings. I oppose using any letter that doesn't seem to have any association with the action, such as E, J, and D. Is accel+shift+S used for anything? I'd prefer to use that for Check Spelling instead of the current accel+K, and use accel+K for "insert Link" if we want one for that.
Blocks: 66884
*** Bug 78058 has been marked as a duplicate of this bug. ***
Note: Ctrl+Shift+L for Insert Link was added to the spec because thats what it was in 4.x. I don't think its critical Insert Link have an accelerator and will remove it from the spec.
If this is going to make the UI freeze deadline, we need to make a decision today. How about: Insert > Link accel-L Format > Discontinue Link (or Remove Link) accel-shift-K Format > Remove All Text Styles accel-shift-Y
Target Milestone: mozilla0.9.2 → mozilla0.9.1
I don't like the last 2, too obscure, and I think they will be used a lot. I'd prefer: Insert > Link accel-shift-L (or no keybinding) Format > Discontinue Link (or Remove Link) accel-L Format > Remove All Text Styles accel-T
Darn, I just realized I wanted "accel+T" for "fixed width" I thought I filed a bug on that before, but can't seem to find it. That's an old keybinding we used in 4.x. and I use it all the time in email when inserting blocks of code. So maybe Kathy's are OK, but is accel+shift+T used? I think that's a better mnemonic than "accel+shift+Y".
accel+T for "fixed width font" has already been fixed.
FYI, in Mail: Accel+L - Mail Forward Accel+T - Get Messages Accel+Shift+T - Get All New Messages
So this means that in Mail Compose, Accel+Shift+T won't "Get All New Mail" like it does in 3 Pane, but will instead change to "Fixed Width Font"? I think its nice to try and avoid using the same accelerators for different puposes in different windows if at all possible, although I understand this is sometimes unavoidable. But I think having the same accelerator do one thing in Mail Compose and another thing in 3 Pane Mail is bad.
Typo, sorry i meant "Accel+T" above, NOT "Accel+Shift+T".
I agree with mpt, but I do see one problem with using accel+L for insert link: it would be good to have the shortcut for finishing a link should be shift+ (insert link), but accel+shift+L is "open web location" in Navigator. I'd rather not have different shortcuts for "open web location" in Navigator and Composer.
All of the accelerators noted by jglick should only work in the Mail window, not Mail Composer. So there shouldn't be a conflict. The accelerators applicable to "Web Composer" should work in both "web" and "mail" Composer.
I just used Mail Composer from todays build (yea! assertions are gone!) and *none* of the 'standard' editing key accelerators are working: accel+b for bold, accel+I for italics, etc. Is this a known problem? About general problem: It would be real nice if we could have the same accelerators, and we certainly should do that when functionalility makes sense in each app, e.g., Open Location. But mail and Composer are both heavy users of accelerators and thus have lots of conflicts. Having "Get Mail" and "Forward" mail, etc work in Mail Composer doesn't seem nearly as useful as being able to edit the message efficiently. (Also think about accessibility issues.)
Accel+B, accel+I, etc. not working in message compose is bug 78063.
ok, based on the comments today, this is my new proposal: Insert > Link accel-L Format > Discontinue Link (or Remove Link) accel-shift-K Format > Remove All Text Styles accel-shift-T Format > Font > Fixed Width accel-T (more similar to other formatting mnemonics)
r=cmanske I'd really prefer if Mail Composer would use these accelerators as well, and not override for mail window features ("Get Message", "Forward Mail", etc.). Note that those commands don't exist in Mail Composer's menus, which is another good arguement to not use the accelerators. (Will they even work on Mac if command isn't in a menu?)
cc'ing akkana to see if she has any comments on this...
The proposed bindings are fine with me (don't conflict with anything that I'm aware of), though the two T bindings don't seem related so they might be a bit hard to remember. (But better than nothing, and I have no better suggestions to propose.)
Brade, What about "Forward message", "Go to Mail Location bar", and "Spell Check" ? Insert > Link accel-L Format > Discontinue Link (or Remove Link) accel-shift-K Format > Remove All Text Styles accel-shift-T Format > Font > Fixed Width accel-T (more similar to other formatting mnemonics) Aaron
I agree that Mail Compose and Editor should use the same accelerators for formatting functions. And understand that sometimes accelerators have to be re-used in diff components for different functions. I just think its bad to use accelerators that perform one function in Mail 3 Pane and another in Mail Compose (since although they are different windows, they are the same component). It would be nice nice if Editor and Mail compose could use accelerators that AREN'T used in 3 Pane Mail.
But in Mail Composer, your main task is *writing* a message, not managing your messages. Thus it seems much closer to the "Web Composer" component than it does to the main Mail window.
Agree the tasks are same, which is why Editor and Mail Compose should use the same accelerators for formatting. But in Mail Compose, the user is still mentally "in the Mail application". A sub-task of 3 Pane Mail, Mail Compose, shouldn't have accelerators that conflict with the parent application.
I'd think "remove text styles" would be used more often than "fixed width font", since almost every "fixed width font" would be matched with a "remove text styles" at the end. So shouldn't those shortcuts be switched to make "remove text styles" easier to hit?
The following commands are not menu items in Mail Compose as of yesterday morning: Forward message Go to Mail Location bar Get Messages Get All New Messages I didn't take any of those keybindings into account since they aren't in the menus and didn't seem to work. Spellcheck is accel-k (and isn't changing) Jesse--remove text styles probably will be used more often than fixed width font, but I thought it was a better fit for the remove text styles to use the shift (like redo on Mac, like remove link, and searching backwards). Also, Bold, Italic and other formatting items don't use the shift key.
To Jesse: Actually, there is currently a bug in that setting "fixed-width" via accel+T really should be a toggle, but instead it just sets it. So having "accel+t" set fixed-width, and accel+shift+T turn it off sounds like a nice combination to me!
fixed
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Build 2001-05-09-04: WinMe Build 2001-05-09-08: Mac 9.04 Build 2001-05-09-10, mozilla build: Linux RH 6.2 It's not clear to me what is supposed to be checked. I used brade's 5/7 statements as a guide. All of these accelerators are present and most of them work: - Insert > Link accel-L - Format > Discontinue Link (or Remove Link) accel-shift-K - Format > Remove All Text Styles accel-shift-T - Format > Font > Fixed Width accel-T
can we mark this VERIFIED ? lemme know..
verified.
Status: RESOLVED → VERIFIED
Ninoschka Baca--those are the correct keybindings. Do all of the keybindings work? If not, could you please check if the menu items work (if the menu item works and the keybinding doesn't, this bug should be reopened). If the menu item and keybinding don't work, file a new bug. Can you be more specific about what you are seeing when you say "most of them work?"
Reopening (I was going to log a separate bug on this specific issue but reopening due to brade's suggestion) Linux only problem: The following menu item works but the keybinding does not: - Remove Text Styles, Accel+Shift+T
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Ninoschka Baca--this is very interesting. I asked around and got this reply: Yes, Ctrl-Shift-t should be consumed by a ComposeIM module in European locales, and no application which uses the input method can get it. This is true on Solaris, too. See /usr/X11R6/lib/X11/locale/iso8859-1/Compose. This is for iso8859-1 locales: en_US and wetern european, you will see the entries starting with "Ctrl<T>". For example, the first entry: Ctrl<T> <plus> <plus> : "#" numbersign means: when you type Ctrl-Shift-t followed by two plus(+) keys, the input method should compose "#" as a string and XK_numbersign as a keysym. Toshi Ninoschka Baca--I am going to resolve this bug as fixed since the keybindings are all working everywhere except ctrl-shift-t on Linux and Solaris (it does work on HPUX) due to this IME conflict. Can you please file a new bug on this issue so we don't morph this bug any more? You can assign that bug to me. THANKS!
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Ninoschka, please verify and mark verified-fixed when you get chance.. thanks!
Verified Fixed. Note: Bug# 80384 covers the problem using accel-shift-T on linux.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.