775766 - Add "Copy Email Address" to long press context menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

A long press on a "mailto:" link should open the context menu with a "Copy Email Address" option.

This is similar to bug 744662, where you may share email addresses (but it keeps the "mailto:" in the link).

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch

As per the TODO on line 1107 (https://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#1107), it might be better to begin moving the context menu items to individual classes, rather than the current mass copy/paste block. I think it would be best to file a followup bug and do it at least after the remaining long press options are implemented ("Copy phone number" and "Copy image location", as per bug 718437). Do you agree?

Also note that this patch builds on the patch in bug 769886 ("Copy link") which may not be on mozilla-central yet.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch v2

Updated single quotes to double quotes for consistency.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 644113 [details] [diff] [review]
Patch v2

This looks fine, but Wes is re-organizing the place where context menu actions are initialized. You'll need to rebase for that.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch v3

Rebase to inbound (including wesj's patch). Moved r+.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To checker-in:
Apply bug 769886 before applying this patch.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1be98690ab78

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1be98690ab78

Comment 8

[Aaron Train [:aaronmt]]

Aurora/Beta nom?

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Aaron Train [:aaronmt] from comment #8)
> Aurora/Beta nom?

While this bug is a simple change, it relies on several code changes which may not be as simple or low risk. As this is not an essential fix, I think it would be safer to leave it on central.

Comment 10

[Ioana Chiorean]

Build ID: 17.0a2 (2012-10-08)Aurora Channel
          18.0 (2012-10-08) Nightly Channel
          19.0 (2012-10-09) Nightly Channel
Device: Samsung Galaxy Nexus
OS: Android 4.1


Marking bug as Verify Fixed.

Comment 11

[Ioana Chiorean]

Attachment: Screenshot

Screen with the option and the menu for e-mails.