770195 - Kuma: Refine wiki-editable custom CSS feature

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Wiki pages, defect, P4)

Description

[Les Orchard [:lorchard]]

In bug 768492, I added a quick hack to use Template:CustomCSS as a wiki-editable custom CSS file. It works, but overloads the template feature as a way to enforce access control on the CSS resource. The resource isn't a real template, and I added a small hack to serve that one resource up as Content-Type: text/css.

This works, but in case I haven't used the word enough, it's a hack. Let's revisit this feature and see if we can't make it less of a hack in terms of access control and moving the custom CSS out of the Template:* namespace

Comment 2

[Jean-Yves Perrier [:teoli]]

The hack also lowers performance. Like all document pages, the HTTP headers of this one are set so that we always reload the page.

This means every document reload the page (and don't even do a CONDITIONAL GET). 

We must be sure that the final solution will allow this resource to be cached adequately (I think this is possible but not trivial), or at the very least don't request more than a CONDITIONAL GET, though, as this is css it blocks rendering until it is loaded and parsed (to prevent FOUC).

Meanwhile, to track this, I mark it as blocking our loading time perf meta bug: bug 783527 .

(I don't think this raise much the priority of this bug for the moment, we have plenty of other perf improvements to do)

Comment 3

[Luke Crouch [:groovecoder]]

I also overloaded the Template feature for Promote-MDN (i.e., https://developer.mozilla.org/en-US/docs/Template:Promote-MDN?raw=1)

My thought was to create a new protected "MDN:" or "Content" namespace of pages with their own permissions.