77122 - context menu for <input type=image> has frame options, lacks image and form-submit options

Status: VERIFIED WORKSFORME

(SeaMonkey :: UI Design, defect)

Description

[Jesse Ruderman]

Noticed while looking at bug 69882:

The context menu for an image submit button looks like the context menu for a 
blank part of a frame (even on a non-framed page).  It should have image- and 
page-related items that would be shown for an image link, and form-related 
items that would be shown on a normal form-submit button.

I'm not getting any javascript errors.

Comment 1

[rods (gone)]

reassigning

Comment 2

[Vladimir Ermakov]

Hmm I cant even put out an IMAGE submenu on windows 98 build 2001-06-04-09-0.9.1

Comment 3

[Eric Pollmann]

--> Context Menu Guru

Comment 4

[sairuh (rarely reading bugmail)]

*** Bug 97476 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

nominating for 0.9.5...

from bug 97476: image options missing in context menu for INPUT TYPE=IMAGE,
including View Image, Save Image and Copy Image Location.

however, in bug 97476, this appears to be a problem on win32 [eg, winNT and
win2k], but not on linux or mac os x.

sample test sites [bring up the context menu on the button images]:

http://www.centrum.cz/
http://www.mesec.cz/
http://hotbot.lycos.com/

Comment 6

[Ashley Bischoff (blog at handcoding.com)]

Is bug 101550 related to or a dupe of this bug?

Comment 7

[Bill Law]

No, bug 101550 concerns missing support for context menus for client-side image
maps.  This is not that.

Comment 8

[Bill Law]

*** Bug 78558 has been marked as a duplicate of this bug. ***

Comment 9

[Bill Law]

->context menu owner

Steve, here's another one.  I haven't looked at this in a while so I don't know 
what state this is in.  Thanks.

Comment 10

[Heikki Toivonen (remove -bugzilla when emailing directly)]

*** Bug 83883 has been marked as a duplicate of this bug. ***

Comment 11

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 12

[Sebastian Biallas]

This is now a WFM with Build ID 2002022103, Win 98.

Comment 13

[Boris Zbarsky [:bzbarsky]]

*** Bug 127230 has been marked as a duplicate of this bug. ***

Comment 14

[Ashley Bischoff (blog at handcoding.com)]

Still seeing this with 2002022103 on Win2k. 

Sebastian: You tried right clicking on one of the "More" images at the URL
above? I see now "View Image" in the context menu for those :-/.

Comment 15

[Sebastian Biallas]

This bug is about wrong context menu for <input type=image> images (frame
context menu instead of image context menu). When I click on the "more" image I
get the correct image context menu (Block images from server, Save image, Copy
image location etc., no frame options). Also tested with some dups.
So this is definitly a WFM for me. (See also bug 127230 comment #3)

(@abischøff  >>I see now "View Image" in the context menu for those<<, you meant
"I see no ...", did you?)

Comment 16

[Ashley Bischoff (blog at handcoding.com)]

Sebastian: Keyword "pp"? Perhaps there's something divergent between Win98 (your
OS) and Win2k (mine) ?

Removing "mozilla0.9.5" keyword (that's long gone). 

Comment 17

[Boris Zbarsky [:bzbarsky]]

*** Bug 122708 has been marked as a duplicate of this bug. ***

Comment 18

[Chris Lyon]

*** Bug 129747 has been marked as a duplicate of this bug. ***

Comment 19

[Sebastian Biallas]

Attachment: proposed patch

(first patch, maybe complete crap)
I tried to find the reason for this bug and noticed that onpopupshowing of the
contextmenu is called 3 times on a <input type=image> element, but wasnt able
to figure out the reason for this. When its called the first time the context
menu was ok, so I added a wrapper which takes the first constructed context
menu.

Please note that this is a workaround (although it works perfect); a real patch
would have changed onpopupshowing calling behaviour.

I tested this only on win98 and hope that it will work on other platforms too.

Comment 20

[Sebastian Biallas]

Attachment: yet better patch

Comment 21

[Boris Zbarsky [:bzbarsky]]

*** Bug 137385 has been marked as a duplicate of this bug. ***

Comment 22

[Boris Zbarsky [:bzbarsky]]

blake, any idea what's up here?

Comment 23

[Boris Zbarsky [:bzbarsky]]

Reading today's checkin log, I see the following comment (revision 3.79 of
layout/html/forms/src/nsImageControlFrame.cpp):

"Stop image control frame stomping on the event status. This stops context menu
events being propogated to their parents and sent twice for input elements with
images. bugscape=14131 r=[e-mail] sr=[e-mail]"

I suspect that this checkin will fix this bug...  but since I cannot reproduce
the bug to start with I can't really test that.  So if someone who's seeing this
could please try tomorrow's build, that would be great.

Comment 24

[Neil Marshall]

This is fixed on the 2002050204 trunk build.

Comment 25

[Blu3]

Here's another bug.  Can't "Copy Image Location" via the context menu from
<input type=image ...>, clipboard remains unaltered.

Comment 26

[Stephen P. Morse]

Closing out as fixed per comments 23 and 24.  If I'm wrong and it's still a 
problem, then reopen.

Comment 27

[Blu3]

Reopening. Context menu may have options, but they really should work be
functional. Last revisited w/ 2002 0511 08.

Comment 28

[Blu3]

That is, reopening due to comment #25

Comment 29

[Stephen P. Morse]

reassigned to component owner

Comment 30

[Samir Gehani]

Steve, this covers more of your domain: context menus, images, and forms.  What
component should it be assigned to?  I'll let you decide.

Comment 31

[Stephen P. Morse]

It looks like this bug is morphing.  The bug is about the image items not
appearing in the context menu.  And that has since been fixed according to the
many WFMs found in this report.  It also works for me as I just tried it.

So it was closed out as WFM and then in comment 28 Blu3 said "reopening per
comment 25.  But you can't do that -- comment 25 is an entirely different bug. 
If you want to persue that, then open a new report on it.  But the symptoms
described in this but are no longer present.  So closing out once again as WFM.

Comment 32

[Paul Wyskoczka]

v